13157733617

Committed 05 Feb 2025 12:49PM UTC coverage: 57.712% (-1.1%) from 58.82%

Build # 13157733617

Build Type

Pull #9447

github

Committed by

yyforyongyu

Commit Message

sweep: rename methods for clarity

We now rename "third party" to "unknown" as the inputs can be spent via
an older sweeping tx, a third party (anchor), or a remote party (pin).
In fee bumper we don't have the info to distinguish the above cases, and
leave them to be further handled by the sweeper as it has more context.

Pull Request Pull Request #9447: sweep: start tracking input spending status in the fee bumper

Run Details

83 of 87 new or added lines in 2 files covered. (95.4%)

19472 existing lines in 252 files now uncovered.

103634 of 179570 relevant lines covered (57.71%)

24840.31 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

0.0

/lncfg/protocol_legacy_on.go

//go:build dev
// +build dev

package lncfg

// Legacy is a sub-config that houses all the legacy protocol options.  These
// are mostly used for integration tests as most modern nodes should always run
// with them on by default.
//
//nolint:ll
type LegacyProtocol struct {
        // LegacyOnionFormat if set to true, then we won't signal
        // TLVOnionPayloadOptional. As a result, nodes that include us in the
        // route won't use the new modern onion framing.
        LegacyOnionFormat bool `long:"onion" description:"force node to not advertise the new modern TLV onion format"`

        // CommitmentTweak guards if we should use the old legacy commitment
        // protocol, or the newer variant that doesn't have a tweak for the
        // remote party's output in the commitment. If set to true, then we
        // won't signal StaticRemoteKeyOptional.
        CommitmentTweak bool `long:"committweak" description:"force node to not advertise the new commitment format"`
}

// LegacyOnion returns true if the old legacy onion format should be used when
// we're an intermediate or final hop. This controls if we set the
// TLVOnionPayloadOptional bit or not.
func (l *LegacyProtocol) LegacyOnion() bool {
        return l.LegacyOnionFormat
}

// NoStaticRemoteKey returns true if the old commitment format with a tweaked
// remote key should be used for new funded channels.
func (l *LegacyProtocol) NoStaticRemoteKey() bool {
        return l.CommitmentTweak
}

1	//go:build dev
2	// +build dev
3
4	package lncfg
5
6	// Legacy is a sub-config that houses all the legacy protocol options. These
7	// are mostly used for integration tests as most modern nodes should always run
8	// with them on by default.
9	//
10	//nolint:ll
11	type LegacyProtocol struct {
12	// LegacyOnionFormat if set to true, then we won't signal
13	// TLVOnionPayloadOptional. As a result, nodes that include us in the
14	// route won't use the new modern onion framing.
15	LegacyOnionFormat bool `long:"onion" description:"force node to not advertise the new modern TLV onion format"`
16
17	// CommitmentTweak guards if we should use the old legacy commitment
18	// protocol, or the newer variant that doesn't have a tweak for the
19	// remote party's output in the commitment. If set to true, then we
20	// won't signal StaticRemoteKeyOptional.
21	CommitmentTweak bool `long:"committweak" description:"force node to not advertise the new commitment format"`
22	}
23
24	// LegacyOnion returns true if the old legacy onion format should be used when
25	// we're an intermediate or final hop. This controls if we set the
26	// TLVOnionPayloadOptional bit or not.
UNCOV 27	func (l *LegacyProtocol) LegacyOnion() bool {	×
UNCOV 28	return l.LegacyOnionFormat	×
UNCOV 29	}	×
30
31	// NoStaticRemoteKey returns true if the old commitment format with a tweaked
32	// remote key should be used for new funded channels.
UNCOV 33	func (l *LegacyProtocol) NoStaticRemoteKey() bool {	×
UNCOV 34	return l.CommitmentTweak	×
UNCOV 35	}	×

lightningnetwork / lnd / 13157733617

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous