13157733617

Committed 05 Feb 2025 12:49PM UTC coverage: 57.712% (-1.1%) from 58.82%

Build # 13157733617

Build Type

Pull #9447

github

Committed by

yyforyongyu

Commit Message

sweep: rename methods for clarity

We now rename "third party" to "unknown" as the inputs can be spent via
an older sweeping tx, a third party (anchor), or a remote party (pin).
In fee bumper we don't have the info to distinguish the above cases, and
leave them to be further handled by the sweeper as it has more context.

Pull Request Pull Request #9447: sweep: start tracking input spending status in the fee bumper

Run Details

83 of 87 new or added lines in 2 files covered. (95.4%)

19472 existing lines in 252 files now uncovered.

103634 of 179570 relevant lines covered (57.71%)

24840.31 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

57.14

/lntypes/txsize.go

package lntypes

import (
        "fmt"
        "math"
)

// WeightUnit defines a unit to express the transaction size. One weight unit
// is 1/4_000_000 of the max block size. The tx weight is calculated using
// `Base tx size * 3 + Total tx size`.
//   - Base tx size is size of the transaction serialized without the witness
//     data.
//   - Total tx size is the transaction size in bytes serialized according
//     #BIP144.
type WeightUnit uint64

// ToVB converts a value expressed in weight units to virtual bytes.
func (wu WeightUnit) ToVB() VByte {
        // According to BIP141: Virtual transaction size is defined as
        // Transaction weight / 4 (rounded up to the next integer).
        return VByte(math.Ceil(float64(wu) / 4))
}

// String returns the string representation of the weight unit.
func (wu WeightUnit) String() string {
        return fmt.Sprintf("%d wu", wu)
}

// VByte defines a unit to express the transaction size. One virtual byte is
// 1/4th of a weight unit. The tx virtual bytes is calculated using `TxWeight /
// 4`.
type VByte uint64

// ToWU converts a value expressed in virtual bytes to weight units.
func (vb VByte) ToWU() WeightUnit {
        return WeightUnit(vb * 4)
}

// String returns the string representation of the virtual byte.
func (vb VByte) String() string {
        return fmt.Sprintf("%d vb", vb)
}

1	package lntypes
2
3	import (
4	"fmt"
5	"math"
6	)
7
8	// WeightUnit defines a unit to express the transaction size. One weight unit
9	// is 1/4_000_000 of the max block size. The tx weight is calculated using
10	// `Base tx size * 3 + Total tx size`.
11	// - Base tx size is size of the transaction serialized without the witness
12	// data.
13	// - Total tx size is the transaction size in bytes serialized according
14	// #BIP144.
15	type WeightUnit uint64
16
17	// ToVB converts a value expressed in weight units to virtual bytes.
18	func (wu WeightUnit) ToVB() VByte {	8✔
19	// According to BIP141: Virtual transaction size is defined as	8✔
20	// Transaction weight / 4 (rounded up to the next integer).	8✔
21	return VByte(math.Ceil(float64(wu) / 4))	8✔
22	}	8✔
23
24	// String returns the string representation of the weight unit.
UNCOV 25	func (wu WeightUnit) String() string {	×
UNCOV 26	return fmt.Sprintf("%d wu", wu)	×
UNCOV 27	}	×
28
29	// VByte defines a unit to express the transaction size. One virtual byte is
30	// 1/4th of a weight unit. The tx virtual bytes is calculated using `TxWeight /
31	// 4`.
32	type VByte uint64
33
34	// ToWU converts a value expressed in virtual bytes to weight units.
35	func (vb VByte) ToWU() WeightUnit {	20✔
36	return WeightUnit(vb * 4)	20✔
37	}	20✔
38
39	// String returns the string representation of the virtual byte.
UNCOV 40	func (vb VByte) String() string {	×
UNCOV 41	return fmt.Sprintf("%d vb", vb)	×
UNCOV 42	}	×

lightningnetwork / lnd / 13157733617

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous