• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

lightningnetwork / lnd / 13211764208

08 Feb 2025 03:08AM UTC coverage: 49.288% (-9.5%) from 58.815%
13211764208

Pull #9489

github

calvinrzachman
itest: verify switchrpc server enforces send then track

We prevent the rpc server from allowing onion dispatches for
attempt IDs which have already been tracked by rpc clients.

This helps protect the client from leaking a duplicate onion
attempt. NOTE: This is not the only method for solving this
issue! The issue could be addressed via careful client side
programming which accounts for the uncertainty and async
nature of dispatching onions to a remote process via RPC.
This would require some lnd ChannelRouter changes for how
we intend to use these RPCs though.
Pull Request #9489: multi: add BuildOnion, SendOnion, and TrackOnion RPCs

474 of 990 new or added lines in 11 files covered. (47.88%)

27321 existing lines in 435 files now uncovered.

101192 of 205306 relevant lines covered (49.29%)

1.54 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

75.0
/buffer/utils.go
1
package buffer
2

3
// RecycleSlice zeroes byte slice, making it fresh for another use.
4
// Zeroing the buffer using a logarithmic number of calls to the optimized copy
5
// method.  Benchmarking shows this to be ~30 times faster than a for loop that
6
// sets each index to 0 for ~65KB buffers use for wire messages. Inspired by:
7
// https://stackoverflow.com/questions/30614165/is-there-analog-of-memset-in-go
8
func RecycleSlice(b []byte) {
3✔
9
        if len(b) == 0 {
3✔
UNCOV
10
                return
×
UNCOV
11
        }
×
12

13
        b[0] = 0
3✔
14
        for i := 1; i < len(b); i *= 2 {
6✔
15
                copy(b[i:], b[:i])
3✔
16
        }
3✔
17
}
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2025 Coveralls, Inc