13211764208

Committed 08 Feb 2025 03:08AM UTC coverage: 49.288% (-9.5%) from 58.815%

Build # 13211764208

Build Type

Pull #9489

github

Committed by

calvinrzachman

Commit Message

itest: verify switchrpc server enforces send then track

We prevent the rpc server from allowing onion dispatches for
attempt IDs which have already been tracked by rpc clients.

This helps protect the client from leaking a duplicate onion
attempt. NOTE: This is not the only method for solving this
issue! The issue could be addressed via careful client side
programming which accounts for the uncertainty and async
nature of dispatching onions to a remote process via RPC.
This would require some lnd ChannelRouter changes for how
we intend to use these RPCs though.

Pull Request Pull Request #9489: multi: add BuildOnion, SendOnion, and TrackOnion RPCs

Run Details

474 of 990 new or added lines in 11 files covered. (47.88%)

27321 existing lines in 435 files now uncovered.

101192 of 205306 relevant lines covered (49.29%)

1.54 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

0.0

/channeldb/migration/lnwire21/true_boolean.go

package lnwire

import (
        "io"

        "github.com/lightningnetwork/lnd/tlv"
)

// TrueBoolean is a record that indicates true or false using the presence of
// the record. If the record is absent, it indicates false. If it is present,
// it indicates true.
type TrueBoolean struct{}

// Record returns the tlv record for the boolean entry.
func (b *TrueBoolean) Record() tlv.Record {
        return tlv.MakeStaticRecord(
                0, b, 0, booleanEncoder, booleanDecoder,
        )
}

func booleanEncoder(_ io.Writer, val interface{}, _ *[8]byte) error {
        if _, ok := val.(*TrueBoolean); ok {
                return nil
        }

        return tlv.NewTypeForEncodingErr(val, "TrueBoolean")
}

func booleanDecoder(_ io.Reader, val interface{}, _ *[8]byte,
        l uint64) error {

        if _, ok := val.(*TrueBoolean); ok && (l == 0 || l == 1) {
                return nil
        }

        return tlv.NewTypeForEncodingErr(val, "TrueBoolean")
}

1	package lnwire
2
3	import (
4	"io"
5
6	"github.com/lightningnetwork/lnd/tlv"
7	)
8
9	// TrueBoolean is a record that indicates true or false using the presence of
10	// the record. If the record is absent, it indicates false. If it is present,
11	// it indicates true.
12	type TrueBoolean struct{}
13
14	// Record returns the tlv record for the boolean entry.
UNCOV 15	func (b *TrueBoolean) Record() tlv.Record {	×
UNCOV 16	return tlv.MakeStaticRecord(	×
UNCOV 17	0, b, 0, booleanEncoder, booleanDecoder,	×
UNCOV 18	)	×
UNCOV 19	}	×
20
UNCOV 21	func booleanEncoder(_ io.Writer, val interface{}, _ *[8]byte) error {	×
UNCOV 22	if _, ok := val.(*TrueBoolean); ok {	×
UNCOV 23	return nil	×
UNCOV 24	}	×
25
26	return tlv.NewTypeForEncodingErr(val, "TrueBoolean")	×
27	}
28
29	func booleanDecoder(_ io.Reader, val interface{}, _ *[8]byte,
30	l uint64) error {	×
31		×
32	if _, ok := val.(*TrueBoolean); ok && (l == 0 \|\| l == 1) {	×
33	return nil	×
34	}	×
35
36	return tlv.NewTypeForEncodingErr(val, "TrueBoolean")	×
37	}

lightningnetwork / lnd / 13211764208

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous