13211764208

Committed 08 Feb 2025 03:08AM UTC coverage: 49.288% (-9.5%) from 58.815%

Build # 13211764208

Build Type

Pull #9489

github

Committed by

calvinrzachman

Commit Message

itest: verify switchrpc server enforces send then track

We prevent the rpc server from allowing onion dispatches for
attempt IDs which have already been tracked by rpc clients.

This helps protect the client from leaking a duplicate onion
attempt. NOTE: This is not the only method for solving this
issue! The issue could be addressed via careful client side
programming which accounts for the uncertainty and async
nature of dispatching onions to a remote process via RPC.
This would require some lnd ChannelRouter changes for how
we intend to use these RPCs though.

Pull Request Pull Request #9489: multi: add BuildOnion, SendOnion, and TrackOnion RPCs

Run Details

474 of 990 new or added lines in 11 files covered. (47.88%)

27321 existing lines in 435 files now uncovered.

101192 of 205306 relevant lines covered (49.29%)

1.54 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

0.0

/channeldb/migration_01_to_11/meta.go

package migration_01_to_11

import (
        "github.com/lightningnetwork/lnd/kvdb"
)

var (
        // metaBucket stores all the meta information concerning the state of
        // the database.
        metaBucket = []byte("metadata")

        // dbVersionKey is a boltdb key and it's used for storing/retrieving
        // current database version.
        dbVersionKey = []byte("dbp")
)

// Meta structure holds the database meta information.
type Meta struct {
        // DbVersionNumber is the current schema version of the database.
        DbVersionNumber uint32
}

// putMeta is an internal helper function used in order to allow callers to
// re-use a database transaction. See the publicly exported PutMeta method for
// more information.
func putMeta(meta *Meta, tx kvdb.RwTx) error {
        metaBucket, err := tx.CreateTopLevelBucket(metaBucket)
        if err != nil {
                return err
        }

        return putDbVersion(metaBucket, meta)
}

func putDbVersion(metaBucket kvdb.RwBucket, meta *Meta) error {
        scratch := make([]byte, 4)
        byteOrder.PutUint32(scratch, meta.DbVersionNumber)
        return metaBucket.Put(dbVersionKey, scratch)
}

1	package migration_01_to_11
2
3	import (
4	"github.com/lightningnetwork/lnd/kvdb"
5	)
6
7	var (
8	// metaBucket stores all the meta information concerning the state of
9	// the database.
10	metaBucket = []byte("metadata")
11
12	// dbVersionKey is a boltdb key and it's used for storing/retrieving
13	// current database version.
14	dbVersionKey = []byte("dbp")
15	)
16
17	// Meta structure holds the database meta information.
18	type Meta struct {
19	// DbVersionNumber is the current schema version of the database.
20	DbVersionNumber uint32
21	}
22
23	// putMeta is an internal helper function used in order to allow callers to
24	// re-use a database transaction. See the publicly exported PutMeta method for
25	// more information.
UNCOV 26	func putMeta(meta *Meta, tx kvdb.RwTx) error {	×
UNCOV 27	metaBucket, err := tx.CreateTopLevelBucket(metaBucket)	×
UNCOV 28	if err != nil {	×
29	return err	×
30	}	×
31
UNCOV 32	return putDbVersion(metaBucket, meta)	×
33	}
34
UNCOV 35	func putDbVersion(metaBucket kvdb.RwBucket, meta *Meta) error {	×
UNCOV 36	scratch := make([]byte, 4)	×
UNCOV 37	byteOrder.PutUint32(scratch, meta.DbVersionNumber)	×
UNCOV 38	return metaBucket.Put(dbVersionKey, scratch)	×
UNCOV 39	}	×

lightningnetwork / lnd / 13211764208

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous