13211764208

Committed 08 Feb 2025 03:08AM UTC coverage: 49.288% (-9.5%) from 58.815%

Build # 13211764208

Build Type

Pull #9489

github

Committed by

calvinrzachman

Commit Message

itest: verify switchrpc server enforces send then track

We prevent the rpc server from allowing onion dispatches for
attempt IDs which have already been tracked by rpc clients.

This helps protect the client from leaking a duplicate onion
attempt. NOTE: This is not the only method for solving this
issue! The issue could be addressed via careful client side
programming which accounts for the uncertainty and async
nature of dispatching onions to a remote process via RPC.
This would require some lnd ChannelRouter changes for how
we intend to use these RPCs though.

Pull Request Pull Request #9489: multi: add BuildOnion, SendOnion, and TrackOnion RPCs

Run Details

474 of 990 new or added lines in 11 files covered. (47.88%)

27321 existing lines in 435 files now uncovered.

101192 of 205306 relevant lines covered (49.29%)

1.54 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

35.71

/lncfg/workers.go

package lncfg

import "fmt"

const (
        // DefaultReadWorkers is the default maximum number of concurrent
        // workers used by the daemon's read pool.
        DefaultReadWorkers = 100

        // DefaultWriteWorkers is the default maximum number of concurrent
        // workers used by the daemon's write pool.
        DefaultWriteWorkers = 8

        // DefaultSigWorkers is the default maximum number of concurrent workers
        // used by the daemon's sig pool.
        DefaultSigWorkers = 8
)

// Workers exposes CLI configuration for turning resources consumed by worker
// pools.
//
//nolint:ll
type Workers struct {
        // Read is the maximum number of concurrent read pool workers.
        Read int `long:"read" description:"Maximum number of concurrent read pool workers. This number should be proportional to the number of peers."`

        // Write is the maximum number of concurrent write pool workers.
        Write int `long:"write" description:"Maximum number of concurrent write pool workers. This number should be proportional to the number of CPUs on the host. "`

        // Sig is the maximum number of concurrent sig pool workers.
        Sig int `long:"sig" description:"Maximum number of concurrent sig pool workers. This number should be proportional to the number of CPUs on the host."`
}

// Validate checks the Workers configuration to ensure that the input values are
// sane.
func (w *Workers) Validate() error {
        if w.Read <= 0 {
                return fmt.Errorf("number of read workers (%d) must be "+
                        "positive", w.Read)
        }
        if w.Write <= 0 {
                return fmt.Errorf("number of write workers (%d) must be "+
                        "positive", w.Write)
        }
        if w.Sig <= 0 {
                return fmt.Errorf("number of sig workers (%d) must be "+
                        "positive", w.Sig)
        }

        return nil
}

// Compile-time constraint to ensure Workers implements the Validator interface.
var _ Validator = (*Workers)(nil)

1	package lncfg
2
3	import "fmt"
4
5	const (
6	// DefaultReadWorkers is the default maximum number of concurrent
7	// workers used by the daemon's read pool.
8	DefaultReadWorkers = 100
9
10	// DefaultWriteWorkers is the default maximum number of concurrent
11	// workers used by the daemon's write pool.
12	DefaultWriteWorkers = 8
13
14	// DefaultSigWorkers is the default maximum number of concurrent workers
15	// used by the daemon's sig pool.
16	DefaultSigWorkers = 8
17	)
18
19	// Workers exposes CLI configuration for turning resources consumed by worker
20	// pools.
21	//
22	//nolint:ll
23	type Workers struct {
24	// Read is the maximum number of concurrent read pool workers.
25	Read int `long:"read" description:"Maximum number of concurrent read pool workers. This number should be proportional to the number of peers."`
26
27	// Write is the maximum number of concurrent write pool workers.
28	Write int `long:"write" description:"Maximum number of concurrent write pool workers. This number should be proportional to the number of CPUs on the host. "`
29
30	// Sig is the maximum number of concurrent sig pool workers.
31	Sig int `long:"sig" description:"Maximum number of concurrent sig pool workers. This number should be proportional to the number of CPUs on the host."`
32	}
33
34	// Validate checks the Workers configuration to ensure that the input values are
35	// sane.
36	func (w *Workers) Validate() error {	3✔
37	if w.Read <= 0 {	3✔
UNCOV 38	return fmt.Errorf("number of read workers (%d) must be "+	×
UNCOV 39	"positive", w.Read)	×
UNCOV 40	}	×
41	if w.Write <= 0 {	3✔
UNCOV 42	return fmt.Errorf("number of write workers (%d) must be "+	×
UNCOV 43	"positive", w.Write)	×
UNCOV 44	}	×
45	if w.Sig <= 0 {	3✔
UNCOV 46	return fmt.Errorf("number of sig workers (%d) must be "+	×
UNCOV 47	"positive", w.Sig)	×
UNCOV 48	}	×
49
50	return nil	3✔
51	}
52
53	// Compile-time constraint to ensure Workers implements the Validator interface.
54	var _ Validator = (*Workers)(nil)

lightningnetwork / lnd / 13211764208

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous