13211764208

Committed 08 Feb 2025 03:08AM UTC coverage: 49.288% (-9.5%) from 58.815%

Build # 13211764208

Build Type

Pull #9489

github

Committed by

calvinrzachman

Commit Message

itest: verify switchrpc server enforces send then track

We prevent the rpc server from allowing onion dispatches for
attempt IDs which have already been tracked by rpc clients.

This helps protect the client from leaking a duplicate onion
attempt. NOTE: This is not the only method for solving this
issue! The issue could be addressed via careful client side
programming which accounts for the uncertainty and async
nature of dispatching onions to a remote process via RPC.
This would require some lnd ChannelRouter changes for how
we intend to use these RPCs though.

Pull Request Pull Request #9489: multi: add BuildOnion, SendOnion, and TrackOnion RPCs

Run Details

474 of 990 new or added lines in 11 files covered. (47.88%)

27321 existing lines in 435 files now uncovered.

101192 of 205306 relevant lines covered (49.29%)

1.54 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

0.0

/netann/msg_hash.go

package netann

import (
        "github.com/btcsuite/btcd/chaincfg/chainhash"
)

// MsgHashTag will prefix the message name and the field name in order to
// construct the message tag.
const MsgHashTag = "lightning"

// MsgTag computes the full tag that will be used to prefix a message before
// calculating the tagged hash. The tag is constructed as follows:
//
//        tag = "lightning"||"msg_name"||"field_name"
func MsgTag(msgName, fieldName string) []byte {
        tag := []byte(MsgHashTag)
        tag = append(tag, []byte(msgName)...)

        return append(tag, []byte(fieldName)...)
}

// MsgHash computes the tagged hash of the given message as follows:
//
//        tag = "lightning"||"msg_name"||"field_name"
//        hash = sha256(sha246(tag) || sha256(tag) || msg)
func MsgHash(msgName, fieldName string, msg []byte) *chainhash.Hash {
        tag := MsgTag(msgName, fieldName)

        return chainhash.TaggedHash(tag, msg)
}

1	package netann
2
3	import (
4	"github.com/btcsuite/btcd/chaincfg/chainhash"
5	)
6
7	// MsgHashTag will prefix the message name and the field name in order to
8	// construct the message tag.
9	const MsgHashTag = "lightning"
10
11	// MsgTag computes the full tag that will be used to prefix a message before
12	// calculating the tagged hash. The tag is constructed as follows:
13	//
14	// tag = "lightning"\|\|"msg_name"\|\|"field_name"
UNCOV 15	func MsgTag(msgName, fieldName string) []byte {	×
UNCOV 16	tag := []byte(MsgHashTag)	×
UNCOV 17	tag = append(tag, []byte(msgName)...)	×
UNCOV 18		×
UNCOV 19	return append(tag, []byte(fieldName)...)	×
UNCOV 20	}	×
21
22	// MsgHash computes the tagged hash of the given message as follows:
23	//
24	// tag = "lightning"\|\|"msg_name"\|\|"field_name"
25	// hash = sha256(sha246(tag) \|\| sha256(tag) \|\| msg)
UNCOV 26	func MsgHash(msgName, fieldName string, msg []byte) *chainhash.Hash {	×
UNCOV 27	tag := MsgTag(msgName, fieldName)	×
UNCOV 28		×
UNCOV 29	return chainhash.TaggedHash(tag, msg)	×
UNCOV 30	}	×

lightningnetwork / lnd / 13211764208

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous