13211764208

Committed 08 Feb 2025 03:08AM UTC coverage: 49.288% (-9.5%) from 58.815%

Build # 13211764208

Build Type

Pull #9489

github

Committed by

calvinrzachman

Commit Message

itest: verify switchrpc server enforces send then track

We prevent the rpc server from allowing onion dispatches for
attempt IDs which have already been tracked by rpc clients.

This helps protect the client from leaking a duplicate onion
attempt. NOTE: This is not the only method for solving this
issue! The issue could be addressed via careful client side
programming which accounts for the uncertainty and async
nature of dispatching onions to a remote process via RPC.
This would require some lnd ChannelRouter changes for how
we intend to use these RPCs though.

Pull Request Pull Request #9489: multi: add BuildOnion, SendOnion, and TrackOnion RPCs

Run Details

474 of 990 new or added lines in 11 files covered. (47.88%)

27321 existing lines in 435 files now uncovered.

101192 of 205306 relevant lines covered (49.29%)

1.54 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

0.0

/watchtower/wtdb/migration7/codec.go

package migration7

import "encoding/hex"

// SessionIDSize is 33-bytes; it is a serialized, compressed public key.
const SessionIDSize = 33

// SessionID is created from the remote public key of a client, and serves as a
// unique identifier and authentication for sending state updates.
type SessionID [SessionIDSize]byte

// String returns a hex encoding of the session id.
func (s SessionID) String() string {
        return hex.EncodeToString(s[:])
}

// ChannelID is a series of 32-bytes that uniquely identifies all channels
// within the network. The ChannelID is computed using the outpoint of the
// funding transaction (the txid, and output index). Given a funding output the
// ChannelID can be calculated by XOR'ing the big-endian serialization of the
// txid and the big-endian serialization of the output index, truncated to
// 2 bytes.
type ChannelID [32]byte

// String returns the string representation of the ChannelID. This is just the
// hex string encoding of the ChannelID itself.
func (c ChannelID) String() string {
        return hex.EncodeToString(c[:])
}

1	package migration7
2
3	import "encoding/hex"
4
5	// SessionIDSize is 33-bytes; it is a serialized, compressed public key.
6	const SessionIDSize = 33
7
8	// SessionID is created from the remote public key of a client, and serves as a
9	// unique identifier and authentication for sending state updates.
10	type SessionID [SessionIDSize]byte
11
12	// String returns a hex encoding of the session id.
UNCOV 13	func (s SessionID) String() string {	×
UNCOV 14	return hex.EncodeToString(s[:])	×
UNCOV 15	}	×
16
17	// ChannelID is a series of 32-bytes that uniquely identifies all channels
18	// within the network. The ChannelID is computed using the outpoint of the
19	// funding transaction (the txid, and output index). Given a funding output the
20	// ChannelID can be calculated by XOR'ing the big-endian serialization of the
21	// txid and the big-endian serialization of the output index, truncated to
22	// 2 bytes.
23	type ChannelID [32]byte
24
25	// String returns the string representation of the ChannelID. This is just the
26	// hex string encoding of the ChannelID itself.
27	func (c ChannelID) String() string {	×
28	return hex.EncodeToString(c[:])	×
29	}	×

lightningnetwork / lnd / 13211764208

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous