13233514377

Committed 10 Feb 2025 04:24AM UTC coverage: 49.335% (-9.5%) from 58.815%

Build # 13233514377

Build Type

Pull #9492

github

Committed by

yyforyongyu

Commit Message

itest: fix flake in `testForwardInterceptorRestart`

We need to make sure the links are recreated before calling the
interceptor, otherwise we'd get the following error, causing the test to
fail.
```
2025-02-07 15:01:38.991 [ERR] RPCS interceptor.go:624: [/routerrpc.Router/HtlcInterceptor]: fwd (Chan ID=487:3:0, HTLC ID=0) not found
```

Pull Request Pull Request #9492: itest: fix flake in `testForwardInterceptorRestart`

Run Details

100803 of 204322 relevant lines covered (49.34%)

1.54 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

26.67

/feature/required.go

package feature

import (
        "fmt"

        "github.com/lightningnetwork/lnd/lnwire"
)

// ErrUnknownRequired signals that a feature vector requires certain features
// that our node is unaware of or does not implement.
type ErrUnknownRequired struct {
        unknown []lnwire.FeatureBit
}

// NewErrUnknownRequired initializes an ErrUnknownRequired with the unknown
// feature bits.
func NewErrUnknownRequired(unknown []lnwire.FeatureBit) ErrUnknownRequired {
        return ErrUnknownRequired{
                unknown: unknown,
        }
}

// Error returns a human-readable description of the error.
func (e ErrUnknownRequired) Error() string {
        return fmt.Sprintf("feature vector contains unknown required "+
                "features: %v", e.unknown)
}

// ValidateRequired returns an error if the feature vector contains a non-zero
// number of unknown, required feature bits.
func ValidateRequired(fv *lnwire.FeatureVector) error {
        unknown := fv.UnknownRequiredFeatures()
        if len(unknown) > 0 {
                return NewErrUnknownRequired(unknown)
        }
        return nil
}

1	package feature
2
3	import (
4	"fmt"
5
6	"github.com/lightningnetwork/lnd/lnwire"
7	)
8
9	// ErrUnknownRequired signals that a feature vector requires certain features
10	// that our node is unaware of or does not implement.
11	type ErrUnknownRequired struct {
12	unknown []lnwire.FeatureBit
13	}
14
15	// NewErrUnknownRequired initializes an ErrUnknownRequired with the unknown
16	// feature bits.
17	func NewErrUnknownRequired(unknown []lnwire.FeatureBit) ErrUnknownRequired {	×
18	return ErrUnknownRequired{	×
19	unknown: unknown,	×
20	}	×
21	}	×
22
23	// Error returns a human-readable description of the error.
24	func (e ErrUnknownRequired) Error() string {	×
25	return fmt.Sprintf("feature vector contains unknown required "+	×
26	"features: %v", e.unknown)	×
27	}	×
28
29	// ValidateRequired returns an error if the feature vector contains a non-zero
30	// number of unknown, required feature bits.
31	func ValidateRequired(fv *lnwire.FeatureVector) error {	3✔
32	unknown := fv.UnknownRequiredFeatures()	3✔
33	if len(unknown) > 0 {	3✔
34	return NewErrUnknownRequired(unknown)	×
35	}	×
36	return nil	3✔
37	}

lightningnetwork / lnd / 13233514377

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous