13233514377

Committed 10 Feb 2025 04:24AM UTC coverage: 49.335% (-9.5%) from 58.815%

Build # 13233514377

Build Type

Pull #9492

github

Committed by

yyforyongyu

Commit Message

itest: fix flake in `testForwardInterceptorRestart`

We need to make sure the links are recreated before calling the
interceptor, otherwise we'd get the following error, causing the test to
fail.
```
2025-02-07 15:01:38.991 [ERR] RPCS interceptor.go:624: [/routerrpc.Router/HtlcInterceptor]: fwd (Chan ID=487:3:0, HTLC ID=0) not found
```

Pull Request Pull Request #9492: itest: fix flake in `testForwardInterceptorRestart`

Run Details

100803 of 204322 relevant lines covered (49.34%)

1.54 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

68.75

/watchtower/wtserver/delete_session.go

package wtserver

import (
        "github.com/lightningnetwork/lnd/watchtower/wtdb"
        "github.com/lightningnetwork/lnd/watchtower/wtwire"
)

// handleDeleteSession processes a DeleteSession request for a client with given
// SessionID. The id is assumed to have been previously authenticated by the
// brontide connection.
func (s *Server) handleDeleteSession(peer Peer, id *wtdb.SessionID) error {
        var failCode wtwire.DeleteSessionCode

        // Delete all session data associated with id.
        err := s.cfg.DB.DeleteSession(*id)
        switch {
        case err == nil:
                failCode = wtwire.CodeOK

                log.Debugf("Session %s deleted", id)

        case err == wtdb.ErrSessionNotFound:
                failCode = wtwire.DeleteSessionCodeNotFound

        default:
                failCode = wtwire.CodeTemporaryFailure
        }

        return s.replyDeleteSession(peer, id, failCode)
}

// replyDeleteSession sends a DeleteSessionReply back to the peer containing the
// error code resulting from processes a DeleteSession request.
func (s *Server) replyDeleteSession(peer Peer, id *wtdb.SessionID,
        code wtwire.DeleteSessionCode) error {

        msg := &wtwire.DeleteSessionReply{
                Code: code,
        }

        err := s.sendMessage(peer, msg)
        if err != nil {
                log.Errorf("Unable to send DeleteSessionReply to %s", id)
        }

        // Return the write error if the request succeeded.
        if code == wtwire.CodeOK {
                return err
        }

        // Otherwise the request failed, return a connection failure to
        // disconnect the client.
        return &connFailure{
                ID:   *id,
                Code: code,
        }
}

1	package wtserver
2
3	import (
4	"github.com/lightningnetwork/lnd/watchtower/wtdb"
5	"github.com/lightningnetwork/lnd/watchtower/wtwire"
6	)
7
8	// handleDeleteSession processes a DeleteSession request for a client with given
9	// SessionID. The id is assumed to have been previously authenticated by the
10	// brontide connection.
11	func (s Server) handleDeleteSession(peer Peer, id wtdb.SessionID) error {	3✔
12	var failCode wtwire.DeleteSessionCode	3✔
13		3✔
14	// Delete all session data associated with id.	3✔
15	err := s.cfg.DB.DeleteSession(*id)	3✔
16	switch {	3✔
17	case err == nil:	3✔
18	failCode = wtwire.CodeOK	3✔
19		3✔
20	log.Debugf("Session %s deleted", id)	3✔
21
22	case err == wtdb.ErrSessionNotFound:	×
23	failCode = wtwire.DeleteSessionCodeNotFound	×
24
25	default:	×
26	failCode = wtwire.CodeTemporaryFailure	×
27	}
28
29	return s.replyDeleteSession(peer, id, failCode)	3✔
30	}
31
32	// replyDeleteSession sends a DeleteSessionReply back to the peer containing the
33	// error code resulting from processes a DeleteSession request.
34	func (s Server) replyDeleteSession(peer Peer, id wtdb.SessionID,
35	code wtwire.DeleteSessionCode) error {	3✔
36		3✔
37	msg := &wtwire.DeleteSessionReply{	3✔
38	Code: code,	3✔
39	}	3✔
40		3✔
41	err := s.sendMessage(peer, msg)	3✔
42	if err != nil {	3✔
43	log.Errorf("Unable to send DeleteSessionReply to %s", id)	×
44	}	×
45
46	// Return the write error if the request succeeded.
47	if code == wtwire.CodeOK {	6✔
48	return err	3✔
49	}	3✔
50
51	// Otherwise the request failed, return a connection failure to
52	// disconnect the client.
53	return &connFailure{	×
54	ID: *id,	×
55	Code: code,	×
56	}	×
57	}

lightningnetwork / lnd / 13233514377

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous