13236757158

Committed 10 Feb 2025 08:39AM UTC coverage: 57.649% (-1.2%) from 58.815%

Build # 13236757158

Build Type

Pull #9493

github

Committed by

ziggie1984

Commit Message

lncli: for some cmds we don't replace the data of the response.

For some cmds it is not very practical to replace the json output
because we might pipe it into other commands. For example when
creating the route we want to pipe it into sendtoRoute.

Pull Request Pull Request #9493: For some lncli cmds we should not replace the content with other data

Run Details

0 of 9 new or added lines in 2 files covered. (0.0%)

19535 existing lines in 252 files now uncovered.

103517 of 179563 relevant lines covered (57.65%)

24878.49 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

0.0

/lncfg/protocol_legacy_on.go

//go:build dev
// +build dev

package lncfg

// Legacy is a sub-config that houses all the legacy protocol options.  These
// are mostly used for integration tests as most modern nodes should always run
// with them on by default.
//
//nolint:ll
type LegacyProtocol struct {
        // LegacyOnionFormat if set to true, then we won't signal
        // TLVOnionPayloadOptional. As a result, nodes that include us in the
        // route won't use the new modern onion framing.
        LegacyOnionFormat bool `long:"onion" description:"force node to not advertise the new modern TLV onion format"`

        // CommitmentTweak guards if we should use the old legacy commitment
        // protocol, or the newer variant that doesn't have a tweak for the
        // remote party's output in the commitment. If set to true, then we
        // won't signal StaticRemoteKeyOptional.
        CommitmentTweak bool `long:"committweak" description:"force node to not advertise the new commitment format"`
}

// LegacyOnion returns true if the old legacy onion format should be used when
// we're an intermediate or final hop. This controls if we set the
// TLVOnionPayloadOptional bit or not.
func (l *LegacyProtocol) LegacyOnion() bool {
        return l.LegacyOnionFormat
}

// NoStaticRemoteKey returns true if the old commitment format with a tweaked
// remote key should be used for new funded channels.
func (l *LegacyProtocol) NoStaticRemoteKey() bool {
        return l.CommitmentTweak
}

1	//go:build dev
2	// +build dev
3
4	package lncfg
5
6	// Legacy is a sub-config that houses all the legacy protocol options. These
7	// are mostly used for integration tests as most modern nodes should always run
8	// with them on by default.
9	//
10	//nolint:ll
11	type LegacyProtocol struct {
12	// LegacyOnionFormat if set to true, then we won't signal
13	// TLVOnionPayloadOptional. As a result, nodes that include us in the
14	// route won't use the new modern onion framing.
15	LegacyOnionFormat bool `long:"onion" description:"force node to not advertise the new modern TLV onion format"`
16
17	// CommitmentTweak guards if we should use the old legacy commitment
18	// protocol, or the newer variant that doesn't have a tweak for the
19	// remote party's output in the commitment. If set to true, then we
20	// won't signal StaticRemoteKeyOptional.
21	CommitmentTweak bool `long:"committweak" description:"force node to not advertise the new commitment format"`
22	}
23
24	// LegacyOnion returns true if the old legacy onion format should be used when
25	// we're an intermediate or final hop. This controls if we set the
26	// TLVOnionPayloadOptional bit or not.
UNCOV 27	func (l *LegacyProtocol) LegacyOnion() bool {	×
UNCOV 28	return l.LegacyOnionFormat	×
UNCOV 29	}	×
30
31	// NoStaticRemoteKey returns true if the old commitment format with a tweaked
32	// remote key should be used for new funded channels.
UNCOV 33	func (l *LegacyProtocol) NoStaticRemoteKey() bool {	×
UNCOV 34	return l.CommitmentTweak	×
UNCOV 35	}	×

lightningnetwork / lnd / 13236757158

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous