13236757158

Committed 10 Feb 2025 08:39AM UTC coverage: 57.649% (-1.2%) from 58.815%

Build # 13236757158

Build Type

Pull #9493

github

Committed by

ziggie1984

Commit Message

lncli: for some cmds we don't replace the data of the response.

For some cmds it is not very practical to replace the json output
because we might pipe it into other commands. For example when
creating the route we want to pipe it into sendtoRoute.

Pull Request Pull Request #9493: For some lncli cmds we should not replace the content with other data

Run Details

0 of 9 new or added lines in 2 files covered. (0.0%)

19535 existing lines in 252 files now uncovered.

103517 of 179563 relevant lines covered (57.65%)

24878.49 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

61.9

/netann/node_signer.go

package netann

import (
        "fmt"

        "github.com/btcsuite/btcd/btcec/v2/ecdsa"
        "github.com/lightningnetwork/lnd/keychain"
        "github.com/lightningnetwork/lnd/lnwallet"
)

// NodeSigner is an implementation of the MessageSigner interface backed by the
// identity private key of running lnd node.
type NodeSigner struct {
        keySigner keychain.SingleKeyMessageSigner
}

// NewNodeSigner creates a new instance of the NodeSigner backed by the target
// private key.
func NewNodeSigner(keySigner keychain.SingleKeyMessageSigner) *NodeSigner {
        return &NodeSigner{
                keySigner: keySigner,
        }
}

// SignMessage signs a double-sha256 digest of the passed msg under the
// resident node's private key described in the key locator. If the target key
// locator is _not_ the node's private key, then an error will be returned.
func (n *NodeSigner) SignMessage(keyLoc keychain.KeyLocator,
        msg []byte, doubleHash bool) (*ecdsa.Signature, error) {

        // If this isn't our identity public key, then we'll exit early with an
        // error as we can't sign with this key.
        if keyLoc != n.keySigner.KeyLocator() {
                return nil, fmt.Errorf("unknown public key locator")
        }

        // Otherwise, we'll sign the double-sha256 of the target message.
        sig, err := n.keySigner.SignMessage(msg, doubleHash)
        if err != nil {
                return nil, fmt.Errorf("can't sign the message: %w", err)
        }

        return sig, nil
}

// SignMessageCompact signs a single or double sha256 digest of the msg
// parameter under the resident node's private key. The returned signature is a
// pubkey-recoverable signature.
func (n *NodeSigner) SignMessageCompact(msg []byte, doubleHash bool) ([]byte,
        error) {

        return n.keySigner.SignMessageCompact(msg, doubleHash)
}

// A compile time check to ensure that NodeSigner implements the MessageSigner
// interface.
var _ lnwallet.MessageSigner = (*NodeSigner)(nil)

1	package netann
2
3	import (
4	"fmt"
5
6	"github.com/btcsuite/btcd/btcec/v2/ecdsa"
7	"github.com/lightningnetwork/lnd/keychain"
8	"github.com/lightningnetwork/lnd/lnwallet"
9	)
10
11	// NodeSigner is an implementation of the MessageSigner interface backed by the
12	// identity private key of running lnd node.
13	type NodeSigner struct {
14	keySigner keychain.SingleKeyMessageSigner
15	}
16
17	// NewNodeSigner creates a new instance of the NodeSigner backed by the target
18	// private key.
19	func NewNodeSigner(keySigner keychain.SingleKeyMessageSigner) *NodeSigner {	42✔
20	return &NodeSigner{	42✔
21	keySigner: keySigner,	42✔
22	}	42✔
23	}	42✔
24
25	// SignMessage signs a double-sha256 digest of the passed msg under the
26	// resident node's private key described in the key locator. If the target key
27	// locator is _not_ the node's private key, then an error will be returned.
28	func (n *NodeSigner) SignMessage(keyLoc keychain.KeyLocator,
29	msg []byte, doubleHash bool) (*ecdsa.Signature, error) {	100✔
30		100✔
31	// If this isn't our identity public key, then we'll exit early with an	100✔
32	// error as we can't sign with this key.	100✔
33	if keyLoc != n.keySigner.KeyLocator() {	100✔
34	return nil, fmt.Errorf("unknown public key locator")	×
35	}	×
36
37	// Otherwise, we'll sign the double-sha256 of the target message.
38	sig, err := n.keySigner.SignMessage(msg, doubleHash)	100✔
39	if err != nil {	100✔
40	return nil, fmt.Errorf("can't sign the message: %w", err)	×
41	}	×
42
43	return sig, nil	100✔
44	}
45
46	// SignMessageCompact signs a single or double sha256 digest of the msg
47	// parameter under the resident node's private key. The returned signature is a
48	// pubkey-recoverable signature.
49	func (n *NodeSigner) SignMessageCompact(msg []byte, doubleHash bool) ([]byte,
UNCOV 50	error) {	×
UNCOV 51		×
UNCOV 52	return n.keySigner.SignMessageCompact(msg, doubleHash)	×
UNCOV 53	}	×
54
55	// A compile time check to ensure that NodeSigner implements the MessageSigner
56	// interface.
57	var _ lnwallet.MessageSigner = (*NodeSigner)(nil)

lightningnetwork / lnd / 13236757158

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous