13566028875

Committed 27 Feb 2025 12:09PM UTC coverage: 49.396% (-9.4%) from 58.748%

Build # 13566028875

Build Type

Pull #9555

github

Committed by

ellemouton

Commit Message

graph/db: populate the graph cache in Start instead of during construction

In this commit, we move the graph cache population logic out of the
ChannelGraph constructor and into its Start method instead.

Pull Request Pull Request #9555: graph: extract cache from CRUD [6]

Run Details

34 of 54 new or added lines in 4 files covered. (62.96%)

27464 existing lines in 436 files now uncovered.

101095 of 204664 relevant lines covered (49.4%)

1.54 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

0.0

/channeldb/migration_01_to_11/legacy_serialization.go

package migration_01_to_11

import (
        "io"
)

// deserializeCloseChannelSummaryV6 reads the v6 database format for
// ChannelCloseSummary.
//
// NOTE: deprecated, only for migration.
func deserializeCloseChannelSummaryV6(r io.Reader) (*ChannelCloseSummary, error) {
        c := &ChannelCloseSummary{}

        err := ReadElements(r,
                &c.ChanPoint, &c.ShortChanID, &c.ChainHash, &c.ClosingTXID,
                &c.CloseHeight, &c.RemotePub, &c.Capacity, &c.SettledBalance,
                &c.TimeLockedBalance, &c.CloseType, &c.IsPending,
        )
        if err != nil {
                return nil, err
        }

        // We'll now check to see if the channel close summary was encoded with
        // any of the additional optional fields.
        err = ReadElements(r, &c.RemoteCurrentRevocation)
        switch {
        case err == io.EOF:
                return c, nil

        // If we got a non-eof error, then we know there's an actually issue.
        // Otherwise, it may have been the case that this summary didn't have
        // the set of optional fields.
        case err != nil:
                return nil, err
        }

        if err := ReadChanConfig(r, &c.LocalChanConfig); err != nil {
                return nil, err
        }

        // Finally, we'll attempt to read the next unrevoked commitment point
        // for the remote party. If we closed the channel before receiving a
        // funding locked message, then this can be nil. As a result, we'll use
        // the same technique to read the field, only if there's still data
        // left in the buffer.
        err = ReadElements(r, &c.RemoteNextRevocation)
        if err != nil && err != io.EOF {
                // If we got a non-eof error, then we know there's an actually
                // issue. Otherwise, it may have been the case that this
                // summary didn't have the set of optional fields.
                return nil, err
        }

        return c, nil
}

1	package migration_01_to_11
2
3	import (
4	"io"
5	)
6
7	// deserializeCloseChannelSummaryV6 reads the v6 database format for
8	// ChannelCloseSummary.
9	//
10	// NOTE: deprecated, only for migration.
UNCOV 11	func deserializeCloseChannelSummaryV6(r io.Reader) (*ChannelCloseSummary, error) {	×
UNCOV 12	c := &ChannelCloseSummary{}	×
UNCOV 13		×
UNCOV 14	err := ReadElements(r,	×
UNCOV 15	&c.ChanPoint, &c.ShortChanID, &c.ChainHash, &c.ClosingTXID,	×
UNCOV 16	&c.CloseHeight, &c.RemotePub, &c.Capacity, &c.SettledBalance,	×
UNCOV 17	&c.TimeLockedBalance, &c.CloseType, &c.IsPending,	×
UNCOV 18	)	×
UNCOV 19	if err != nil {	×
20	return nil, err	×
21	}	×
22
23	// We'll now check to see if the channel close summary was encoded with
24	// any of the additional optional fields.
UNCOV 25	err = ReadElements(r, &c.RemoteCurrentRevocation)	×
UNCOV 26	switch {	×
UNCOV 27	case err == io.EOF:	×
UNCOV 28	return c, nil	×
29
30	// If we got a non-eof error, then we know there's an actually issue.
31	// Otherwise, it may have been the case that this summary didn't have
32	// the set of optional fields.
33	case err != nil:	×
34	return nil, err	×
35	}
36
UNCOV 37	if err := ReadChanConfig(r, &c.LocalChanConfig); err != nil {	×
38	return nil, err	×
39	}	×
40
41	// Finally, we'll attempt to read the next unrevoked commitment point
42	// for the remote party. If we closed the channel before receiving a
43	// funding locked message, then this can be nil. As a result, we'll use
44	// the same technique to read the field, only if there's still data
45	// left in the buffer.
UNCOV 46	err = ReadElements(r, &c.RemoteNextRevocation)	×
UNCOV 47	if err != nil && err != io.EOF {	×
48	// If we got a non-eof error, then we know there's an actually	×
49	// issue. Otherwise, it may have been the case that this	×
50	// summary didn't have the set of optional fields.	×
51	return nil, err	×
52	}	×
53
UNCOV 54	return c, nil	×
55	}

lightningnetwork / lnd / 13566028875

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous