13566028875

Committed 27 Feb 2025 12:09PM UTC coverage: 49.396% (-9.4%) from 58.748%

Build # 13566028875

Build Type

Pull #9555

github

Committed by

ellemouton

Commit Message

graph/db: populate the graph cache in Start instead of during construction

In this commit, we move the graph cache population logic out of the
ChannelGraph constructor and into its Start method instead.

Pull Request Pull Request #9555: graph: extract cache from CRUD [6]

Run Details

34 of 54 new or added lines in 4 files covered. (62.96%)

27464 existing lines in 436 files now uncovered.

101095 of 204664 relevant lines covered (49.4%)

1.54 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

87.5

/graph/db/channel_cache.go

package graphdb

// channelCache is an in-memory cache used to improve the performance of
// ChanUpdatesInHorizon. It caches the chan info and edge policies for a
// particular channel.
type channelCache struct {
        n        int
        channels map[uint64]ChannelEdge
}

// newChannelCache creates a new channelCache with maximum capacity of n
// channels.
func newChannelCache(n int) *channelCache {
        return &channelCache{
                n:        n,
                channels: make(map[uint64]ChannelEdge),
        }
}

// get returns the channel from the cache, if it exists.
func (c *channelCache) get(chanid uint64) (ChannelEdge, bool) {
        channel, ok := c.channels[chanid]
        return channel, ok
}

// insert adds the entry to the channel cache. If an entry for chanid already
// exists, it will be replaced with the new entry. If the entry doesn't exist,
// it will be inserted to the cache, performing a random eviction if the cache
// is at capacity.
func (c *channelCache) insert(chanid uint64, channel ChannelEdge) {
        // If entry exists, replace it.
        if _, ok := c.channels[chanid]; ok {
                c.channels[chanid] = channel
                return
        }

        // Otherwise, evict an entry at random and insert.
        if len(c.channels) == c.n {
                for id := range c.channels {
                        delete(c.channels, id)
                        break
                }
        }
        c.channels[chanid] = channel
}

// remove deletes an edge for chanid from the cache, if it exists.
func (c *channelCache) remove(chanid uint64) {
        delete(c.channels, chanid)
}

1	package graphdb
2
3	// channelCache is an in-memory cache used to improve the performance of
4	// ChanUpdatesInHorizon. It caches the chan info and edge policies for a
5	// particular channel.
6	type channelCache struct {
7	n int
8	channels map[uint64]ChannelEdge
9	}
10
11	// newChannelCache creates a new channelCache with maximum capacity of n
12	// channels.
13	func newChannelCache(n int) *channelCache {	3✔
14	return &channelCache{	3✔
15	n: n,	3✔
16	channels: make(map[uint64]ChannelEdge),	3✔
17	}	3✔
18	}	3✔
19
20	// get returns the channel from the cache, if it exists.
21	func (c *channelCache) get(chanid uint64) (ChannelEdge, bool) {	3✔
22	channel, ok := c.channels[chanid]	3✔
23	return channel, ok	3✔
24	}	3✔
25
26	// insert adds the entry to the channel cache. If an entry for chanid already
27	// exists, it will be replaced with the new entry. If the entry doesn't exist,
28	// it will be inserted to the cache, performing a random eviction if the cache
29	// is at capacity.
30	func (c *channelCache) insert(chanid uint64, channel ChannelEdge) {	3✔
31	// If entry exists, replace it.	3✔
32	if _, ok := c.channels[chanid]; ok {	6✔
33	c.channels[chanid] = channel	3✔
34	return	3✔
35	}	3✔
36
37	// Otherwise, evict an entry at random and insert.
38	if len(c.channels) == c.n {	3✔
UNCOV 39	for id := range c.channels {	×
UNCOV 40	delete(c.channels, id)	×
UNCOV 41	break	×
42	}
43	}
44	c.channels[chanid] = channel	3✔
45	}
46
47	// remove deletes an edge for chanid from the cache, if it exists.
48	func (c *channelCache) remove(chanid uint64) {	3✔
49	delete(c.channels, chanid)	3✔
50	}	3✔

lightningnetwork / lnd / 13566028875

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous