13566028875

Committed 27 Feb 2025 12:09PM UTC coverage: 49.396% (-9.4%) from 58.748%

Build # 13566028875

Build Type

Pull #9555

github

Committed by

ellemouton

Commit Message

graph/db: populate the graph cache in Start instead of during construction

In this commit, we move the graph cache population logic out of the
ChannelGraph constructor and into its Start method instead.

Pull Request Pull Request #9555: graph: extract cache from CRUD [6]

Run Details

34 of 54 new or added lines in 4 files covered. (62.96%)

27464 existing lines in 436 files now uncovered.

101095 of 204664 relevant lines covered (49.4%)

1.54 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

41.67

/lntypes/hash.go

package lntypes

import (
        "encoding/hex"
        "fmt"
)

// HashSize of array used to store hashes.
const HashSize = 32

// ZeroHash is a predefined hash containing all zeroes.
var ZeroHash Hash

// Hash is used in several of the lightning messages and common structures. It
// typically represents a payment hash.
type Hash [HashSize]byte

// String returns the Hash as a hexadecimal string.
func (hash Hash) String() string {
        return hex.EncodeToString(hash[:])
}

// MakeHash returns a new Hash from a byte slice.  An error is returned if
// the number of bytes passed in is not HashSize.
func MakeHash(newHash []byte) (Hash, error) {
        nhlen := len(newHash)
        if nhlen != HashSize {
                return Hash{}, fmt.Errorf("invalid hash length of %v, want %v",
                        nhlen, HashSize)
        }

        var hash Hash
        copy(hash[:], newHash)

        return hash, nil
}

// MakeHashFromStr creates a Hash from a hex hash string.
func MakeHashFromStr(newHash string) (Hash, error) {
        // Return error if hash string is of incorrect length.
        if len(newHash) != HashSize*2 {
                return Hash{}, fmt.Errorf("invalid hash string length of %v, "+
                        "want %v", len(newHash), HashSize*2)
        }

        hash, err := hex.DecodeString(newHash)
        if err != nil {
                return Hash{}, err
        }

        return MakeHash(hash)
}

1	package lntypes
2
3	import (
4	"encoding/hex"
5	"fmt"
6	)
7
8	// HashSize of array used to store hashes.
9	const HashSize = 32
10
11	// ZeroHash is a predefined hash containing all zeroes.
12	var ZeroHash Hash
13
14	// Hash is used in several of the lightning messages and common structures. It
15	// typically represents a payment hash.
16	type Hash [HashSize]byte
17
18	// String returns the Hash as a hexadecimal string.
19	func (hash Hash) String() string {	3✔
20	return hex.EncodeToString(hash[:])	3✔
21	}	3✔
22
23	// MakeHash returns a new Hash from a byte slice. An error is returned if
24	// the number of bytes passed in is not HashSize.
25	func MakeHash(newHash []byte) (Hash, error) {	3✔
26	nhlen := len(newHash)	3✔
27	if nhlen != HashSize {	3✔
28	return Hash{}, fmt.Errorf("invalid hash length of %v, want %v",	×
29	nhlen, HashSize)	×
30	}	×
31
32	var hash Hash	3✔
33	copy(hash[:], newHash)	3✔
34		3✔
35	return hash, nil	3✔
36	}
37
38	// MakeHashFromStr creates a Hash from a hex hash string.
UNCOV 39	func MakeHashFromStr(newHash string) (Hash, error) {	×
UNCOV 40	// Return error if hash string is of incorrect length.	×
UNCOV 41	if len(newHash) != HashSize*2 {	×
42	return Hash{}, fmt.Errorf("invalid hash string length of %v, "+	×
43	"want %v", len(newHash), HashSize*2)	×
44	}	×
45
UNCOV 46	hash, err := hex.DecodeString(newHash)	×
UNCOV 47	if err != nil {	×
48	return Hash{}, err	×
49	}	×
50
UNCOV 51	return MakeHash(hash)	×
52	}

lightningnetwork / lnd / 13566028875

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous