13566028875

Committed 27 Feb 2025 12:09PM UTC coverage: 49.396% (-9.4%) from 58.748%

Build # 13566028875

Build Type

Pull #9555

github

Committed by

ellemouton

Commit Message

graph/db: populate the graph cache in Start instead of during construction

In this commit, we move the graph cache population logic out of the
ChannelGraph constructor and into its Start method instead.

Pull Request Pull Request #9555: graph: extract cache from CRUD [6]

Run Details

34 of 54 new or added lines in 4 files covered. (62.96%)

27464 existing lines in 436 files now uncovered.

101095 of 204664 relevant lines covered (49.4%)

1.54 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

33.33

/lnwallet/btcwallet/driver.go

package btcwallet

import (
        "fmt"

        "github.com/btcsuite/btcwallet/chain"
        "github.com/lightningnetwork/lnd/blockcache"
        "github.com/lightningnetwork/lnd/lnwallet"
)

const (
        walletType = "btcwallet"
)

// createNewWallet creates a new instance of BtcWallet given the proper list of
// initialization parameters. This function is the factory function required to
// properly create an instance of the lnwallet.WalletDriver struct for
// BtcWallet.
func createNewWallet(args ...interface{}) (lnwallet.WalletController, error) {
        if len(args) != 2 {
                return nil, fmt.Errorf("incorrect number of arguments to .New(...), "+
                        "expected 2, instead passed %v", len(args))
        }

        config, ok := args[0].(*Config)
        if !ok {
                return nil, fmt.Errorf("first argument to btcdnotifier.New is " +
                        "incorrect, expected a *rpcclient.ConnConfig")
        }

        blockCache, ok := args[1].(*blockcache.BlockCache)
        if !ok {
                return nil, fmt.Errorf("second argument to btcdnotifier.New is " +
                        "incorrect, expected a *blockcache.BlockCache")
        }

        return New(*config, blockCache)
}

// init registers a driver for the BtcWallet concrete implementation of the
// lnwallet.WalletController interface.
func init() {
        // Register the driver.
        driver := &lnwallet.WalletDriver{
                WalletType: walletType,
                New:        createNewWallet,
                BackEnds:   chain.BackEnds,
        }

        if err := lnwallet.RegisterWallet(driver); err != nil {
                panic(fmt.Sprintf("failed to register wallet driver '%s': %v",
                        walletType, err))
        }
}

1	package btcwallet
2
3	import (
4	"fmt"
5
6	"github.com/btcsuite/btcwallet/chain"
7	"github.com/lightningnetwork/lnd/blockcache"
8	"github.com/lightningnetwork/lnd/lnwallet"
9	)
10
11	const (
12	walletType = "btcwallet"
13	)
14
15	// createNewWallet creates a new instance of BtcWallet given the proper list of
16	// initialization parameters. This function is the factory function required to
17	// properly create an instance of the lnwallet.WalletDriver struct for
18	// BtcWallet.
UNCOV 19	func createNewWallet(args ...interface{}) (lnwallet.WalletController, error) {	×
UNCOV 20	if len(args) != 2 {	×
21	return nil, fmt.Errorf("incorrect number of arguments to .New(...), "+	×
22	"expected 2, instead passed %v", len(args))	×
23	}	×
24
UNCOV 25	config, ok := args[0].(*Config)	×
UNCOV 26	if !ok {	×
27	return nil, fmt.Errorf("first argument to btcdnotifier.New is " +	×
28	"incorrect, expected a *rpcclient.ConnConfig")	×
29	}	×
30
UNCOV 31	blockCache, ok := args[1].(*blockcache.BlockCache)	×
UNCOV 32	if !ok {	×
33	return nil, fmt.Errorf("second argument to btcdnotifier.New is " +	×
34	"incorrect, expected a *blockcache.BlockCache")	×
35	}	×
36
UNCOV 37	return New(*config, blockCache)	×
38	}
39
40	// init registers a driver for the BtcWallet concrete implementation of the
41	// lnwallet.WalletController interface.
42	func init() {	3✔
43	// Register the driver.	3✔
44	driver := &lnwallet.WalletDriver{	3✔
45	WalletType: walletType,	3✔
46	New: createNewWallet,	3✔
47	BackEnds: chain.BackEnds,	3✔
48	}	3✔
49		3✔
50	if err := lnwallet.RegisterWallet(driver); err != nil {	3✔
51	panic(fmt.Sprintf("failed to register wallet driver '%s': %v",	×
52	walletType, err))	×
53	}
54	}

lightningnetwork / lnd / 13566028875

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous