13566028875

Committed 27 Feb 2025 12:09PM UTC coverage: 49.396% (-9.4%) from 58.748%

Build # 13566028875

Build Type

Pull #9555

github

Committed by

ellemouton

Commit Message

graph/db: populate the graph cache in Start instead of during construction

In this commit, we move the graph cache population logic out of the
ChannelGraph constructor and into its Start method instead.

Pull Request Pull Request #9555: graph: extract cache from CRUD [6]

Run Details

34 of 54 new or added lines in 4 files covered. (62.96%)

27464 existing lines in 436 files now uncovered.

101095 of 204664 relevant lines covered (49.4%)

1.54 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

70.0

/netann/sign.go

package netann

import (
        "fmt"

        "github.com/lightningnetwork/lnd/input"
        "github.com/lightningnetwork/lnd/keychain"
        "github.com/lightningnetwork/lnd/lnwallet"
        "github.com/lightningnetwork/lnd/lnwire"
)

// SignAnnouncement signs any type of gossip message that is announced on the
// network.
func SignAnnouncement(signer lnwallet.MessageSigner, keyLoc keychain.KeyLocator,
        msg lnwire.Message) (input.Signature, error) {

        var (
                data []byte
                err  error
        )

        switch m := msg.(type) {
        case *lnwire.ChannelAnnouncement1:
                data, err = m.DataToSign()
        case *lnwire.ChannelUpdate1:
                data, err = m.DataToSign()
        case *lnwire.NodeAnnouncement:
                data, err = m.DataToSign()
        default:
                return nil, fmt.Errorf("can't sign %T message", m)
        }
        if err != nil {
                return nil, fmt.Errorf("unable to get data to sign: %w", err)
        }

        return signer.SignMessage(keyLoc, data, true)
}

1	package netann
2
3	import (
4	"fmt"
5
6	"github.com/lightningnetwork/lnd/input"
7	"github.com/lightningnetwork/lnd/keychain"
8	"github.com/lightningnetwork/lnd/lnwallet"
9	"github.com/lightningnetwork/lnd/lnwire"
10	)
11
12	// SignAnnouncement signs any type of gossip message that is announced on the
13	// network.
14	func SignAnnouncement(signer lnwallet.MessageSigner, keyLoc keychain.KeyLocator,
15	msg lnwire.Message) (input.Signature, error) {	3✔
16		3✔
17	var (	3✔
18	data []byte	3✔
19	err error	3✔
20	)	3✔
21		3✔
22	switch m := msg.(type) {	3✔
UNCOV 23	case *lnwire.ChannelAnnouncement1:	×
UNCOV 24	data, err = m.DataToSign()	×
25	case *lnwire.ChannelUpdate1:	3✔
26	data, err = m.DataToSign()	3✔
27	case *lnwire.NodeAnnouncement:	3✔
28	data, err = m.DataToSign()	3✔
29	default:	×
30	return nil, fmt.Errorf("can't sign %T message", m)	×
31	}
32	if err != nil {	3✔
33	return nil, fmt.Errorf("unable to get data to sign: %w", err)	×
34	}	×
35
36	return signer.SignMessage(keyLoc, data, true)	3✔
37	}

lightningnetwork / lnd / 13566028875

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous