f04bc944-f9b4-4a42-8b26-dcacd0e3e688

Committed 11 Mar 2025 10:27PM UTC coverage: 34.017% (-58.1%) from 92.162%

Build # f04bc944-f9b4-4a42-8b26-dcacd0e3e688

Build Type

Pull #2653

circleci

Committed by

christinach

Commit Message

Add new lc_subject_facet field.
Helps with the vocabulary work https://github.com/pulibrary/orangelight/pull/3386
In this new field we index only the lc subject heading and the subdivisions
So that when the user searches using the Details section, they can query solr for
all the subject headings and their divisions.

This is needed for the Subject browse Vocabulary work.
example: "lc_subject_facet": [
             "Booksellers and bookselling—Italy—Directories",
             "Booksellers and bookselling-Italy",
             "Booksellers and bookselling"
              ]

Pull Request Pull Request #2653: Add new lc_subject_facet field.

Run Details

1 of 3 new or added lines in 1 file covered. (33.33%)

2215 existing lines in 93 files now uncovered.

1294 of 3804 relevant lines covered (34.02%)

0.99 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

25.0

/app/controllers/application_controller.rb

class ApplicationController < ActionController::Base
  # Prevent CSRF attacks by raising an exception.
  # For APIs, you may want to use :null_session instead.
  protect_from_forgery with: :exception
  include ApplicationHelper

  def after_sign_out_path_for(_resource_or_scope)
    request.referer
  end

  def handle_alma_exception(exception:, message:)
    if exception.is_a?(Alma::PerSecondThresholdError)
      Rails.logger.error "HTTP 429. #{message} #{exception}"
      head :too_many_requests
    elsif exception.is_a?(Alma::NotFoundError)
      Rails.logger.error "HTTP 404. #{message} #{exception}"
      head :not_found
    elsif exception.is_a?(Alma::StandardError)
      Rails.logger.error "HTTP 400. #{message} #{exception}"
      head :bad_request
    elsif exception.is_a?(Net::ReadTimeout)
      Rails.logger.error "HTTP 504. #{message} #{exception}"
      head :gateway_timeout
    else
      Rails.logger.error "HTTP 500. #{message} #{exception}"
      head :internal_server_error
    end
  end
end

1	class ApplicationController < ActionController::Base	1✔
2	# Prevent CSRF attacks by raising an exception.
3	# For APIs, you may want to use :null_session instead.
4	protect_from_forgery with: :exception	1✔
5	include ApplicationHelper	1✔
6
7	def after_sign_out_path_for(_resource_or_scope)	1✔
8	request.referer	×
9	end
10
11	def handle_alma_exception(exception:, message:)	1✔
UNCOV 12	if exception.is_a?(Alma::PerSecondThresholdError)	×
UNCOV 13	Rails.logger.error "HTTP 429. #{message} #{exception}"	×
UNCOV 14	head :too_many_requests	×
UNCOV 15	elsif exception.is_a?(Alma::NotFoundError)	×
UNCOV 16	Rails.logger.error "HTTP 404. #{message} #{exception}"	×
UNCOV 17	head :not_found	×
UNCOV 18	elsif exception.is_a?(Alma::StandardError)	×
UNCOV 19	Rails.logger.error "HTTP 400. #{message} #{exception}"	×
UNCOV 20	head :bad_request	×
UNCOV 21	elsif exception.is_a?(Net::ReadTimeout)	×
UNCOV 22	Rails.logger.error "HTTP 504. #{message} #{exception}"	×
UNCOV 23	head :gateway_timeout	×
24	else
UNCOV 25	Rails.logger.error "HTTP 500. #{message} #{exception}"	×
UNCOV 26	head :internal_server_error	×
27	end
28	end
29	end

pulibrary / bibdata / f04bc944-f9b4-4a42-8b26-dcacd0e3e688

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous