• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

pulibrary / bibdata / f04bc944-f9b4-4a42-8b26-dcacd0e3e688

11 Mar 2025 10:27PM UTC coverage: 34.017% (-58.1%) from 92.162%
f04bc944-f9b4-4a42-8b26-dcacd0e3e688

Pull #2653

circleci

christinach
Add new lc_subject_facet field.
Helps with the vocabulary work https://github.com/pulibrary/orangelight/pull/3386
In this new field we index only the lc subject heading and the subdivisions
So that when the user searches using the Details section, they can query solr for
all the subject headings and their divisions.

This is needed for the Subject browse Vocabulary work.
example: "lc_subject_facet": [
             "Booksellers and bookselling—Italy—Directories",
             "Booksellers and bookselling-Italy",
             "Booksellers and bookselling"
              ]
Pull Request #2653: Add new lc_subject_facet field.

1 of 3 new or added lines in 1 file covered. (33.33%)

2215 existing lines in 93 files now uncovered.

1294 of 3804 relevant lines covered (34.02%)

0.99 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

33.33
/app/models/scsb_lookup.rb
1
class ScsbLookup
1✔
2
  include Scsb
1✔
3

4
  def find_by_id(id)
1✔
UNCOV
5
    response = items_by_id(id)
×
UNCOV
6
    response.index_by { |r| r['itemBarcode'] }
×
7
  rescue Faraday::ConnectionFailed
UNCOV
8
    Rails.logger.warn("No barcodes could be retrieved for the item: #{id}")
×
UNCOV
9
    {}
×
10
  end
11

12
  def find_by_barcodes(barcodes)
1✔
UNCOV
13
    response = items_by_barcode(barcodes)
×
UNCOV
14
    response.index_by { |r| r['itemBarcode'] }
×
15
  rescue Faraday::ConnectionFailed
UNCOV
16
    Rails.logger.warn("No items could be retrieved for the barcodes: #{barcodes.join(',')}")
×
UNCOV
17
    {}
×
18
  end
19
end
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2025 Coveralls, Inc