• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

pulibrary / bibdata / f04bc944-f9b4-4a42-8b26-dcacd0e3e688

11 Mar 2025 10:27PM UTC coverage: 34.017% (-58.1%) from 92.162%
f04bc944-f9b4-4a42-8b26-dcacd0e3e688

Pull #2653

circleci

christinach
Add new lc_subject_facet field.
Helps with the vocabulary work https://github.com/pulibrary/orangelight/pull/3386
In this new field we index only the lc subject heading and the subdivisions
So that when the user searches using the Details section, they can query solr for
all the subject headings and their divisions.

This is needed for the Subject browse Vocabulary work.
example: "lc_subject_facet": [
             "Booksellers and bookselling—Italy—Directories",
             "Booksellers and bookselling-Italy",
             "Booksellers and bookselling"
              ]
Pull Request #2653: Add new lc_subject_facet field.

1 of 3 new or added lines in 1 file covered. (33.33%)

2215 existing lines in 93 files now uncovered.

1294 of 3804 relevant lines covered (34.02%)

0.99 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

22.22
/marc_to_solr/lib/alma_reader.rb
1
# Alma MARC-XML files have no namespace defined, so we have to bypass that
2
# requirement in Nokogiri.
3
class AlmaReader < Traject::MarcReader
1✔
4
  def internal_reader
1✔
UNCOV
5
    @modified_internal_reader ||=
×
6
      begin
UNCOV
7
        result = super
×
UNCOV
8
        result.singleton_class.alias_method :old_start_element_namespace, :start_element_namespace
×
9
        # Redefine start_element_namespace to set the @ns to just be whatever
10
        # the URI is. For MARC records it's always the same anyways.
UNCOV
11
        result.singleton_class.define_method(:start_element_namespace) do |name, attributes = [], prefix = nil, uri = nil, ns = {}|
×
UNCOV
12
          @ns = uri
×
UNCOV
13
          old_start_element_namespace(name, attributes, prefix, uri, ns)
×
14
        end
UNCOV
15
        result
×
16
      end
17
  end
18
end
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2025 Coveralls, Inc