f04bc944-f9b4-4a42-8b26-dcacd0e3e688

Committed 11 Mar 2025 10:27PM UTC coverage: 34.017% (-58.1%) from 92.162%

Build # f04bc944-f9b4-4a42-8b26-dcacd0e3e688

Build Type

Pull #2653

circleci

Committed by

christinach

Commit Message

Add new lc_subject_facet field.
Helps with the vocabulary work https://github.com/pulibrary/orangelight/pull/3386
In this new field we index only the lc subject heading and the subdivisions
So that when the user searches using the Details section, they can query solr for
all the subject headings and their divisions.

This is needed for the Subject browse Vocabulary work.
example: "lc_subject_facet": [
             "Booksellers and bookselling—Italy—Directories",
             "Booksellers and bookselling-Italy",
             "Booksellers and bookselling"
              ]

Pull Request Pull Request #2653: Add new lc_subject_facet field.

Run Details

1 of 3 new or added lines in 1 file covered. (33.33%)

2215 existing lines in 93 files now uncovered.

1294 of 3804 relevant lines covered (34.02%)

0.99 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

38.81

/marc_to_solr/lib/format/bib_format.rb

# given a record, find the bib_format code
require_relative '../format'

# This class is responsible for assigning one or more 2-letter
# codes that represent the format of a title.  The 2-letter
# codes can be found in the Format translation map.
class BibFormat
  attr_reader :code

  # Determine the bib format code
  #
  # @param [MARC::Record] record The record to test

  def initialize(record)
    @record = record
    @code = []
    @code << self.determine_bib_code
    @code << 'WM' if microform?
    @code = @code.flatten
  end

  def determine_bib_code
    format = []
    format << 'AJ' if bibformat_jn # journal
    format << 'CF' if bibformat_cf # data file
    format << 'VM' if bibformat_vm # visual material
    format << 'VP' if bibformat_vp # video
    format << 'MS' if bibformat_mu # musical score
    format << 'AU' if bibformat_au # audio
    format << 'MP' if bibformat_mp # map
    format << 'MW' if bibformat_mw # manuscript
    format << 'BK' if bibformat_bk # book
    format << 'DB' if bibformat_db # databases
    format << 'XA' if bibformat_xa # archival item
    format
  end

  def bibformat_bk
    ((type == 't') && !check_pulfa) || ((type == 'a') && %w[a b c d m].include?(lev))
  end

  def bibformat_db
    (type == 'a') && (lev == 'i')
  end

  def bibformat_jn
    (type == 'a') && (lev == 's')
  end

  def bibformat_cf
    (type == 'm')
  end

  def bibformat_au
    %w[i j].include?(type)
  end

  def bibformat_vm
    %w[k o r].include?(type)
  end

  def bibformat_vp
    (type == 'g')
  end

  def bibformat_mu
    %w[c d].include?(type)
  end

  def bibformat_mp
    %w[e f].include?(type)
  end

  def bibformat_mw
    %w[d f p t].include?(type)
  end

  def bibformat_xa
    (type == 't') && (lev == 'm') && check_pulfa && archival?
  end

  private

    attr_reader :record

    def microform?
      record.fields('007').any? { |field| field.value&.start_with? 'h' }
    end

    def ldr
      @ldr ||= record.leader
    end

    def type
      @type ||= ldr[6]
    end

    def lev
      @lev ||= ldr[7]
    end

    def check_pulfa
      @check_pulfa ||= record['035'] && record['035']['a'] && record['035']['a'].start_with?('(PULFA)')
    end

    def archival?
      @archival ||= begin
        cataloging_sources = record.fields('040')
        return true if cataloging_sources.empty?

        cataloging_sources.any? { |field| field_uses_archival_standard?(field) }
      end
    end

    def field_uses_archival_standard?(field)
      field.subfields.any? { |subfield| subfield.code == 'e' && archival_standard?(subfield.value) } ||
        field.subfields.none? { |subfield| subfield.code == 'e' && !archival_standard?(subfield.value) }
    end

    def archival_standard?(code)
      %w[dacs appm].include? code
    end
end

1	# given a record, find the bib_format code
2	require_relative '../format'	1✔
3
4	# This class is responsible for assigning one or more 2-letter
5	# codes that represent the format of a title. The 2-letter
6	# codes can be found in the Format translation map.
7	class BibFormat	1✔
8	attr_reader :code	1✔
9
10	# Determine the bib format code
11	#
12	# @param [MARC::Record] record The record to test
13
14	def initialize(record)	1✔
UNCOV 15	@record = record	×
UNCOV 16	@code = []	×
UNCOV 17	@code << self.determine_bib_code	×
UNCOV 18	@code << 'WM' if microform?	×
UNCOV 19	@code = @code.flatten	×
20	end
21
22	def determine_bib_code	1✔
UNCOV 23	format = []	×
UNCOV 24	format << 'AJ' if bibformat_jn # journal	×
UNCOV 25	format << 'CF' if bibformat_cf # data file	×
UNCOV 26	format << 'VM' if bibformat_vm # visual material	×
UNCOV 27	format << 'VP' if bibformat_vp # video	×
UNCOV 28	format << 'MS' if bibformat_mu # musical score	×
UNCOV 29	format << 'AU' if bibformat_au # audio	×
UNCOV 30	format << 'MP' if bibformat_mp # map	×
UNCOV 31	format << 'MW' if bibformat_mw # manuscript	×
UNCOV 32	format << 'BK' if bibformat_bk # book	×
UNCOV 33	format << 'DB' if bibformat_db # databases	×
UNCOV 34	format << 'XA' if bibformat_xa # archival item	×
UNCOV 35	format	×
36	end
37
38	def bibformat_bk	1✔
UNCOV 39	((type == 't') && !check_pulfa) \|\| ((type == 'a') && %w[a b c d m].include?(lev))	×
40	end
41
42	def bibformat_db	1✔
UNCOV 43	(type == 'a') && (lev == 'i')	×
44	end
45
46	def bibformat_jn	1✔
UNCOV 47	(type == 'a') && (lev == 's')	×
48	end
49
50	def bibformat_cf	1✔
UNCOV 51	(type == 'm')	×
52	end
53
54	def bibformat_au	1✔
UNCOV 55	%w[i j].include?(type)	×
56	end
57
58	def bibformat_vm	1✔
UNCOV 59	%w[k o r].include?(type)	×
60	end
61
62	def bibformat_vp	1✔
UNCOV 63	(type == 'g')	×
64	end
65
66	def bibformat_mu	1✔
UNCOV 67	%w[c d].include?(type)	×
68	end
69
70	def bibformat_mp	1✔
UNCOV 71	%w[e f].include?(type)	×
72	end
73
74	def bibformat_mw	1✔
UNCOV 75	%w[d f p t].include?(type)	×
76	end
77
78	def bibformat_xa	1✔
UNCOV 79	(type == 't') && (lev == 'm') && check_pulfa && archival?	×
80	end
81
82	private	1✔
83
84	attr_reader :record	1✔
85
86	def microform?	1✔
UNCOV 87	record.fields('007').any? { \|field\| field.value&.start_with? 'h' }	×
88	end
89
90	def ldr	1✔
UNCOV 91	@ldr \|\|= record.leader	×
92	end
93
94	def type	1✔
UNCOV 95	@type \|\|= ldr[6]	×
96	end
97
98	def lev	1✔
UNCOV 99	@lev \|\|= ldr[7]	×
100	end
101
102	def check_pulfa	1✔
UNCOV 103	@check_pulfa \|\|= record['035'] && record['035']['a'] && record['035']['a'].start_with?('(PULFA)')	×
104	end
105
106	def archival?	1✔
UNCOV 107	@archival \|\|= begin	×
UNCOV 108	cataloging_sources = record.fields('040')	×
UNCOV 109	return true if cataloging_sources.empty?	×
110
UNCOV 111	cataloging_sources.any? { \|field\| field_uses_archival_standard?(field) }	×
112	end
113	end
114
115	def field_uses_archival_standard?(field)	1✔
UNCOV 116	field.subfields.any? { \|subfield\| subfield.code == 'e' && archival_standard?(subfield.value) } \|\|	×
UNCOV 117	field.subfields.none? { \|subfield\| subfield.code == 'e' && !archival_standard?(subfield.value) }	×
118	end
119
120	def archival_standard?(code)	1✔
UNCOV 121	%w[dacs appm].include? code	×
122	end
123	end

pulibrary / bibdata / f04bc944-f9b4-4a42-8b26-dcacd0e3e688

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous