13974489001

Committed 20 Mar 2025 04:32PM UTC coverage: 56.292% (-2.9%) from 59.168%

Build # 13974489001

Build Type

Pull #8754

github

Committed by

web-flow

Commit Message

Merge aed149e6b into ea050d06f

Pull Request Pull Request #8754: Add `Outbound` Remote Signer implementation

Run Details

594 of 1713 new or added lines in 26 files covered. (34.68%)

23052 existing lines in 272 files now uncovered.

105921 of 188165 relevant lines covered (56.29%)

23796.34 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

0.0

/lnwallet/rpcwallet/remote_signer_client_builder.go

package rpcwallet

import (
        "github.com/lightningnetwork/lnd/lncfg"
        "github.com/lightningnetwork/lnd/lnrpc"
        "github.com/lightningnetwork/lnd/lnrpc/signrpc"
        "github.com/lightningnetwork/lnd/lnrpc/walletrpc"
)

type rscBuilder = RemoteSignerClientBuilder

// RemoteSignerClientBuilder creates instances of the RemoteSignerClient
// interface, based on the provided configuration.
type RemoteSignerClientBuilder struct {
        cfg *lncfg.WatchOnlyNode
}

// NewRemoteSignerClientBuilder creates a new instance of the
// RemoteSignerClientBuilder.
func NewRemoteSignerClientBuilder(cfg *lncfg.WatchOnlyNode) *rscBuilder {
        return &rscBuilder{cfg}
}

// Build creates a new RemoteSignerClient instance. If the configuration enables
// an outbound remote signer, a new OutboundRemoteSignerClient will be returned.
// Else, a NoOpClient will be returned.
func (b *rscBuilder) Build(subServers []lnrpc.SubServer) (
        RemoteSignerClient, error) {

        var (
                walletServer walletrpc.WalletKitServer
                signerServer signrpc.SignerServer
        )

        for _, subServer := range subServers {
                if server, ok := subServer.(walletrpc.WalletKitServer); ok {
                        walletServer = server
                }

                if server, ok := subServer.(signrpc.SignerServer); ok {
                        signerServer = server
                }
        }

        // Check if we have all servers and if the configuration enables an
        // outbound remote signer. If not, return a NoOpClient.
        if walletServer == nil || signerServer == nil {
                log.Debugf("Using a No Op remote signer client due to " +
                        "current sub-server support")

                return &NoOpClient{}, nil
        }

        if !b.cfg.Enable {
                log.Debugf("Using a No Op remote signer client due to the " +
                        "current watchonly config")

                return &NoOpClient{}, nil
        }

        // An outbound remote signer client is enabled, therefore we create one.
        log.Debugf("Using an outbound remote signer client")

        streamFeeder := NewStreamFeeder(b.cfg.ConnectionCfg)

        return NewOutboundClient(
                walletServer, signerServer, streamFeeder, b.cfg.RequestTimeout,
        )
}

1	package rpcwallet
2
3	import (
4	"github.com/lightningnetwork/lnd/lncfg"
5	"github.com/lightningnetwork/lnd/lnrpc"
6	"github.com/lightningnetwork/lnd/lnrpc/signrpc"
7	"github.com/lightningnetwork/lnd/lnrpc/walletrpc"
8	)
9
10	type rscBuilder = RemoteSignerClientBuilder
11
12	// RemoteSignerClientBuilder creates instances of the RemoteSignerClient
13	// interface, based on the provided configuration.
14	type RemoteSignerClientBuilder struct {
15	cfg *lncfg.WatchOnlyNode
16	}
17
18	// NewRemoteSignerClientBuilder creates a new instance of the
19	// RemoteSignerClientBuilder.
NEW 20	func NewRemoteSignerClientBuilder(cfg lncfg.WatchOnlyNode) rscBuilder {	×
NEW 21	return &rscBuilder{cfg}	×
NEW 22	}	×
23
24	// Build creates a new RemoteSignerClient instance. If the configuration enables
25	// an outbound remote signer, a new OutboundRemoteSignerClient will be returned.
26	// Else, a NoOpClient will be returned.
27	func (b *rscBuilder) Build(subServers []lnrpc.SubServer) (
NEW 28	RemoteSignerClient, error) {	×
NEW 29		×
NEW 30	var (	×
NEW 31	walletServer walletrpc.WalletKitServer	×
NEW 32	signerServer signrpc.SignerServer	×
NEW 33	)	×
NEW 34		×
NEW 35	for _, subServer := range subServers {	×
NEW 36	if server, ok := subServer.(walletrpc.WalletKitServer); ok {	×
NEW 37	walletServer = server	×
NEW 38	}	×
39
NEW 40	if server, ok := subServer.(signrpc.SignerServer); ok {	×
NEW 41	signerServer = server	×
NEW 42	}	×
43	}
44
45	// Check if we have all servers and if the configuration enables an
46	// outbound remote signer. If not, return a NoOpClient.
NEW 47	if walletServer == nil \|\| signerServer == nil {	×
NEW 48	log.Debugf("Using a No Op remote signer client due to " +	×
NEW 49	"current sub-server support")	×
NEW 50		×
NEW 51	return &NoOpClient{}, nil	×
NEW 52	}	×
53
NEW 54	if !b.cfg.Enable {	×
NEW 55	log.Debugf("Using a No Op remote signer client due to the " +	×
NEW 56	"current watchonly config")	×
NEW 57		×
NEW 58	return &NoOpClient{}, nil	×
NEW 59	}	×
60
61	// An outbound remote signer client is enabled, therefore we create one.
NEW 62	log.Debugf("Using an outbound remote signer client")	×
NEW 63		×
NEW 64	streamFeeder := NewStreamFeeder(b.cfg.ConnectionCfg)	×
NEW 65		×
NEW 66	return NewOutboundClient(	×
NEW 67	walletServer, signerServer, streamFeeder, b.cfg.RequestTimeout,	×
NEW 68	)	×
69	}

lightningnetwork / lnd / 13974489001

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous