b3c4a532-5da0-46f8-9c20-20018605a028

Committed 21 Mar 2025 08:11PM UTC coverage: 42.257% (-49.9%) from 92.185%

Build # b3c4a532-5da0-46f8-9c20-20018605a028

Build Type

push

circleci

Committed by

sandbergja

Commit Message

Move various gems from the default Gemfile group to a more appropriate group

Run Details

1599 of 3784 relevant lines covered (42.26%)

2.56 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

12.5

/marc_to_solr/lib/geo.rb

# geo.rb
# extract geo-related data from MARC

def decimal_coordinate record
  coverage = []
  Traject::MarcExtractor.cached('034defg').collect_matching_lines(record) do |field, _spec, _extractor|
    c = {}
    field.subfields.each do |s_field|
      c['w'] = s_field.value if (s_field.code == 'd') && valid_coordinate_format?(s_field.value, record)
      c['e'] = s_field.value if (s_field.code == 'e') && valid_coordinate_format?(s_field.value, record)
      c['n'] = s_field.value if (s_field.code == 'f') && valid_coordinate_format?(s_field.value, record)
      c['s'] = s_field.value if (s_field.code == 'g') && valid_coordinate_format?(s_field.value, record)
    end
    if c.length != 4
      # turning of geo coordinate logging for now
      # logger.error "#{record['001']} - missing coordinate"
      break
    end

    coverage << "northlimit=#{c['n']}; eastlimit=#{c['e']}; southlimit=#{c['s']}; westlimit=#{c['w']}; units=degrees; projection=EPSG:4326"
  end
  # turning of geo coordinate logging for now
  # logger.error "#{record['001']} - multiple 034s" if coverage.length > 1
  coverage.first
end

def valid_coordinate_format? c, _record
  return false unless /^[-+]?[0-9]*\.?[0-9]+$/.match?(c)

  true
end

1	# geo.rb
2	# extract geo-related data from MARC
3
4	def decimal_coordinate record	1✔
5	coverage = []	×
6	Traject::MarcExtractor.cached('034defg').collect_matching_lines(record) do \|field, _spec, _extractor\|	×
7	c = {}	×
8	field.subfields.each do \|s_field\|	×
9	c['w'] = s_field.value if (s_field.code == 'd') && valid_coordinate_format?(s_field.value, record)	×
10	c['e'] = s_field.value if (s_field.code == 'e') && valid_coordinate_format?(s_field.value, record)	×
11	c['n'] = s_field.value if (s_field.code == 'f') && valid_coordinate_format?(s_field.value, record)	×
12	c['s'] = s_field.value if (s_field.code == 'g') && valid_coordinate_format?(s_field.value, record)	×
13	end
14	if c.length != 4	×
15	# turning of geo coordinate logging for now
16	# logger.error "#{record['001']} - missing coordinate"
17	break	×
18	end
19
20	coverage << "northlimit=#{c['n']}; eastlimit=#{c['e']}; southlimit=#{c['s']}; westlimit=#{c['w']}; units=degrees; projection=EPSG:4326"	×
21	end
22	# turning of geo coordinate logging for now
23	# logger.error "#{record['001']} - multiple 034s" if coverage.length > 1
24	coverage.first	×
25	end
26
27	def valid_coordinate_format? c, _record	1✔
28	return false unless /^[-+]?[0-9]*\.?[0-9]+$/.match?(c)	×
29
30	true	×
31	end

pulibrary / bibdata / b3c4a532-5da0-46f8-9c20-20018605a028

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous