• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

mozilla / fx-private-relay / 5a74df92-c598-4a13-b723-2e7458805f16

24 Mar 2025 03:23PM CUT coverage: 85.203% (+0.04%) from 85.167%
5a74df92-c598-4a13-b723-2e7458805f16

Pull #5468

circleci

groovecoder
for MPP-4020: fix(settings): correct env var names for SP3 product keys

The `SUBPLAT3_PHONES_PRODUCT_KEY` and `SUBPLAT3_BUNDLE_PRODUCT_KEY` variables in settings.py were incorrectly assigned from `SUBPLAT3_PREMIUM_PRODUCT_KEY`. This patch fixes the typo so each config line uses the correct environment variable name.

Also adds parametrized tests in `sp3_plans_tests.py` to verify correct behavior of product key usage, including distinctness of keys and proper URL/price generation per plan.

These changes ensure correct config values are loaded and improve test coverage around SP3 plan behavior.
Pull Request #5468: for MPP-4020: fix(settings): correct env var names for SP3 product keys

2452 of 3584 branches covered (68.42%)

Branch coverage included in aggregate %.

42 of 42 new or added lines in 1 file covered. (100.0%)

17217 of 19501 relevant lines covered (88.29%)

9.82 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

0.0
/emails/admin.py
1
from django.contrib import admin
×
2

3
from .models import DeletedAddress, DomainAddress, RelayAddress, Reply
×
4

5

6
@admin.register(Reply)
×
7
class ReplyAdmin(admin.ModelAdmin):
×
8
    readonly_fields = ("created_at",)
×
9
    list_display = ("relay_address", "domain_address", "created_at")
×
10

11

12
admin.site.register(DeletedAddress)
×
13
admin.site.register(RelayAddress)
×
14
admin.site.register(DomainAddress)
×
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2025 Coveralls, Inc