5a74df92-c598-4a13-b723-2e7458805f16

Committed 24 Mar 2025 03:23PM CUT coverage: 85.203% (+0.04%) from 85.167%

Build # 5a74df92-c598-4a13-b723-2e7458805f16

Build Type

Pull #5468

circleci

Committed by

groovecoder

Commit Message

for MPP-4020: fix(settings): correct env var names for SP3 product keys

The `SUBPLAT3_PHONES_PRODUCT_KEY` and `SUBPLAT3_BUNDLE_PRODUCT_KEY` variables in settings.py were incorrectly assigned from `SUBPLAT3_PREMIUM_PRODUCT_KEY`. This patch fixes the typo so each config line uses the correct environment variable name.

Also adds parametrized tests in `sp3_plans_tests.py` to verify correct behavior of product key usage, including distinctness of keys and proper URL/price generation per plan.

These changes ensure correct config values are loaded and improve test coverage around SP3 plan behavior.

Pull Request Pull Request #5468: for MPP-4020: fix(settings): correct env var names for SP3 product keys

Run Details

2452 of 3584 branches covered (68.42%)

Branch coverage included in aggregate %.

42 of 42 new or added lines in 1 file covered. (100.0%)

17217 of 19501 relevant lines covered (88.29%)

9.82 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

0.0

/emails/management/commands/delete_old_reply_records.py

from datetime import UTC, datetime, timedelta

from django.core.management.base import BaseCommand
from django.db import transaction

from ...models import Reply


class Command(BaseCommand):
    help = "Deletes all Reply objects older than 3 months."

    def add_arguments(self, parser):
        parser.add_argument("days_old", nargs=1, type=int)

    def handle(self, *args, **options):
        delete_date = datetime.now(UTC) - timedelta(options["days_old"][0])
        replies_to_delete = Reply.objects.filter(created_at__lt=delete_date).only("id")
        print(
            f"Deleting {len(replies_to_delete)} reply records "
            f"older than {delete_date}"
        )
        with transaction.atomic():
            replies_to_delete.delete()

1	from datetime import UTC, datetime, timedelta	×
2
3	from django.core.management.base import BaseCommand	×
4	from django.db import transaction	×
5
6	from ...models import Reply	×
7
8
9	class Command(BaseCommand):	×
10	help = "Deletes all Reply objects older than 3 months."	×
11
12	def add_arguments(self, parser):	×
13	parser.add_argument("days_old", nargs=1, type=int)	×
14
15	def handle(self, args, *options):	×
16	delete_date = datetime.now(UTC) - timedelta(options["days_old"][0])	×
17	replies_to_delete = Reply.objects.filter(created_at__lt=delete_date).only("id")	×
18	print(	×
19	f"Deleting {len(replies_to_delete)} reply records "
20	f"older than {delete_date}"
21	)
22	with transaction.atomic():	×
23	replies_to_delete.delete()	×

mozilla / fx-private-relay / 5a74df92-c598-4a13-b723-2e7458805f16

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous