2e8abe27-f09a-4a85-94ed-3a143217d06e

Committed 25 Mar 2025 08:20PM UTC coverage: 95.346% (-0.09%) from 95.437%

Build # 2e8abe27-f09a-4a85-94ed-3a143217d06e

Build Type

Pull #3386

circleci

Committed by

christinach

Commit Message

Refactor method browse_subject
set broeslists csv_length:230

Pull Request Pull Request #3386: Adds vocabulary column to subject table

Run Details

33 of 40 new or added lines in 4 files covered. (82.5%)

9 existing lines in 3 files now uncovered.

6023 of 6317 relevant lines covered (95.35%)

1517.13 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

68.18

/app/helpers/orangelight/browsables_helper.rb

# frozen_string_literal: true

module Orangelight
  module BrowsablesHelper
    def scsb_id?(bib_id)
      /^SCSB-\d+/ =~ bib_id
    end

    def bib_for_availability(bib_id)
      bib_id.to_i.to_s
    end

    def valid_bib_id?(bib_id)
      bib_for_availability(bib_id) == bib_id
    end

    def should_check_availability?(bib_id)
      !scsb_id?(bib_id) && valid_bib_id?(bib_id) && render_availability?
    end

    def current_browse_per_page
      params[:rpp].present? ? params[:rpp].to_i : 10
    end

    def vocab_type(vocab)
      case vocab
      when 'Art & architecture thesaurus'
        'aat_genre_facet'
      when 'Homosaurus genres'
        'homoit_genre_facet'
      when 'Homosaurus terms'
        'homoit_subject_facet'
      when 'Library of Congress genre/form terms for library and archival materials'
        'lcgft_genre_facet'
      when 'Locally assigned term'
        'local_subject_facet'
      when 'Rare books genre term'
        'rbgenr_genre_facet'
      when 'Chinese traditional subjects'
        'siku_subject_facet'
      else
        'lc_subject_facet'
      end
    end
  end
end

1	# frozen_string_literal: true
2
3	module Orangelight	3✔
4	module BrowsablesHelper	3✔
5	def scsb_id?(bib_id)	3✔
6	/^SCSB-\d+/ =~ bib_id	463✔
7	end
8
9	def bib_for_availability(bib_id)	3✔
10	bib_id.to_i.to_s	455✔
11	end
12
13	def valid_bib_id?(bib_id)	3✔
14	bib_for_availability(bib_id) == bib_id	223✔
15	end
16
17	def should_check_availability?(bib_id)	3✔
18	!scsb_id?(bib_id) && valid_bib_id?(bib_id) && render_availability?	233✔
19	end
20
21	def current_browse_per_page	3✔
22	params[:rpp].present? ? params[:rpp].to_i : 10	10✔
23	end
24
25	def vocab_type(vocab)	3✔
26	case vocab	50✔
27	when 'Art & architecture thesaurus'
NEW 28	'aat_genre_facet'	×
29	when 'Homosaurus genres'
NEW 30	'homoit_genre_facet'	×
31	when 'Homosaurus terms'
NEW 32	'homoit_subject_facet'	×
33	when 'Library of Congress genre/form terms for library and archival materials'
NEW 34	'lcgft_genre_facet'	×
35	when 'Locally assigned term'
NEW 36	'local_subject_facet'	×
37	when 'Rare books genre term'
NEW UNCOV 38	'rbgenr_genre_facet'	×
39	when 'Chinese traditional subjects'
NEW UNCOV 40	'siku_subject_facet'	×
41	else
42	'lc_subject_facet'	50✔
43	end
44	end
45	end
46	end

pulibrary / orangelight / 2e8abe27-f09a-4a85-94ed-3a143217d06e

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous