14880923441

Committed 07 May 2025 10:17AM UTC coverage: 58.583% (-10.4%) from 68.992%

Build # 14880923441

Build Type

Pull #9787

github

Committed by

web-flow

Commit Message

Merge dd5bddc57 into 67a40c90a

Pull Request Pull Request #9787: graph+lnwire: start validating that extra lnwire msg bytes are valid TLV

Run Details

25 of 40 new or added lines in 8 files covered. (62.5%)

28239 existing lines in 449 files now uncovered.

97412 of 166280 relevant lines covered (58.58%)

1.82 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

26.67

/feature/required.go

package feature

import (
        "fmt"

        "github.com/lightningnetwork/lnd/lnwire"
)

// ErrUnknownRequired signals that a feature vector requires certain features
// that our node is unaware of or does not implement.
type ErrUnknownRequired struct {
        unknown []lnwire.FeatureBit
}

// NewErrUnknownRequired initializes an ErrUnknownRequired with the unknown
// feature bits.
func NewErrUnknownRequired(unknown []lnwire.FeatureBit) ErrUnknownRequired {
        return ErrUnknownRequired{
                unknown: unknown,
        }
}

// Error returns a human-readable description of the error.
func (e ErrUnknownRequired) Error() string {
        return fmt.Sprintf("feature vector contains unknown required "+
                "features: %v", e.unknown)
}

// ValidateRequired returns an error if the feature vector contains a non-zero
// number of unknown, required feature bits.
func ValidateRequired(fv *lnwire.FeatureVector) error {
        unknown := fv.UnknownRequiredFeatures()
        if len(unknown) > 0 {
                return NewErrUnknownRequired(unknown)
        }
        return nil
}

1	package feature
2
3	import (
4	"fmt"
5
6	"github.com/lightningnetwork/lnd/lnwire"
7	)
8
9	// ErrUnknownRequired signals that a feature vector requires certain features
10	// that our node is unaware of or does not implement.
11	type ErrUnknownRequired struct {
12	unknown []lnwire.FeatureBit
13	}
14
15	// NewErrUnknownRequired initializes an ErrUnknownRequired with the unknown
16	// feature bits.
UNCOV 17	func NewErrUnknownRequired(unknown []lnwire.FeatureBit) ErrUnknownRequired {	×
UNCOV 18	return ErrUnknownRequired{	×
UNCOV 19	unknown: unknown,	×
UNCOV 20	}	×
UNCOV 21	}	×
22
23	// Error returns a human-readable description of the error.
UNCOV 24	func (e ErrUnknownRequired) Error() string {	×
UNCOV 25	return fmt.Sprintf("feature vector contains unknown required "+	×
UNCOV 26	"features: %v", e.unknown)	×
UNCOV 27	}	×
28
29	// ValidateRequired returns an error if the feature vector contains a non-zero
30	// number of unknown, required feature bits.
31	func ValidateRequired(fv *lnwire.FeatureVector) error {	3✔
32	unknown := fv.UnknownRequiredFeatures()	3✔
33	if len(unknown) > 0 {	3✔
UNCOV 34	return NewErrUnknownRequired(unknown)	×
UNCOV 35	}	×
36	return nil	3✔
37	}

lightningnetwork / lnd / 14880923441

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous