1833359013

Committed 23 May 2025 01:25PM UTC coverage: 66.318% (+0.5%) from 65.861%

Build # 1833359013

Build Type

Pull #674

gitlab-ci

Committed by

mzedel

Commit Message

fix(gui): prevented device tag editor to be shown when no tags exist

- this is to reduce confusion about tags defined async to the current session not being visible

Ticket: ME-528
Signed-off-by: Manuel Zedel <manuel.zedel@northern.tech>

Pull Request Pull Request #674: ME-529, ME-528 - adjustments to device tag editing

Run Details

29554 of 44564 relevant lines covered (66.32%)

1.45 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

80.0

/backend/pkg/context/httpheader/header.go

// Copyright 2024 Northern.tech AS
//
//        Licensed under the Apache License, Version 2.0 (the "License");
//        you may not use this file except in compliance with the License.
//        You may obtain a copy of the License at
//
//            http://www.apache.org/licenses/LICENSE-2.0
//
//        Unless required by applicable law or agreed to in writing, software
//        distributed under the License is distributed on an "AS IS" BASIS,
//        WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
//        See the License for the specific language governing permissions and
//        limitations under the License.
package httpheader

import (
        "context"
        "net/http"
        "net/textproto"
)

type headerKeyType string

func makeKeyName(hdr string) headerKeyType {
        key := textproto.CanonicalMIMEHeaderKey(hdr)
        return headerKeyType(key)
}

// WithContext stores HTTP headers from `hdrs` which listed in `which` in a
// context and returns the new context (ctx becomes the parent of newly created
// context). Headers care provided as http.Header. Headers that are unset in
// `hdrs` are skipped. Empty header names are skipped as well. Headers are
// stored using httpheader package specific key namespace.
func WithContext(ctx context.Context, hdrs http.Header, which ...string) context.Context {
        if len(hdrs) == 0 {
                return ctx
        }
        if len(which) == 0 {
                return ctx
        }

        for _, h := range which {
                if h == "" {
                        continue
                }
                hv := hdrs.Get(h)
                if hv == "" {
                        continue
                }
                ctx = context.WithValue(ctx, makeKeyName(h), hdrs.Get(h))
        }
        return ctx
}

// FromContext extracts httpheader header and returns a string. If header was
// not set in the context, an empty string is returned.
func FromContext(ctx context.Context, hdr string) string {
        v, ok := ctx.Value(makeKeyName(hdr)).(string)
        if !ok {
                return ""
        }
        return v
}

1	// Copyright 2024 Northern.tech AS
2	//
3	// Licensed under the Apache License, Version 2.0 (the "License");
4	// you may not use this file except in compliance with the License.
5	// You may obtain a copy of the License at
6	//
7	// http://www.apache.org/licenses/LICENSE-2.0
8	//
9	// Unless required by applicable law or agreed to in writing, software
10	// distributed under the License is distributed on an "AS IS" BASIS,
11	// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12	// See the License for the specific language governing permissions and
13	// limitations under the License.
14	package httpheader
15
16	import (
17	"context"
18	"net/http"
19	"net/textproto"
20	)
21
22	type headerKeyType string
23
24	func makeKeyName(hdr string) headerKeyType {	2✔
25	key := textproto.CanonicalMIMEHeaderKey(hdr)	2✔
26	return headerKeyType(key)	2✔
27	}	2✔
28
29	// WithContext stores HTTP headers from `hdrs` which listed in `which` in a
30	// context and returns the new context (ctx becomes the parent of newly created
31	// context). Headers care provided as http.Header. Headers that are unset in
32	// `hdrs` are skipped. Empty header names are skipped as well. Headers are
33	// stored using httpheader package specific key namespace.
34	func WithContext(ctx context.Context, hdrs http.Header, which ...string) context.Context {	2✔
35	if len(hdrs) == 0 {	2✔
36	return ctx	×
37	}	×
38	if len(which) == 0 {	2✔
39	return ctx	×
40	}	×
41
42	for _, h := range which {	4✔
43	if h == "" {	2✔
44	continue	×
45	}
46	hv := hdrs.Get(h)	2✔
47	if hv == "" {	3✔
48	continue	1✔
49	}
50	ctx = context.WithValue(ctx, makeKeyName(h), hdrs.Get(h))	1✔
51	}
52	return ctx	2✔
53	}
54
55	// FromContext extracts httpheader header and returns a string. If header was
56	// not set in the context, an empty string is returned.
57	func FromContext(ctx context.Context, hdr string) string {	2✔
58	v, ok := ctx.Value(makeKeyName(hdr)).(string)	2✔
59	if !ok {	3✔
60	return ""	1✔
61	}	1✔
62	return v	1✔
63	}

mendersoftware / mender-server / 1833359013

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous