1833359013

Committed 23 May 2025 01:25PM UTC coverage: 66.318% (+0.5%) from 65.861%

Build # 1833359013

Build Type

Pull #674

gitlab-ci

Committed by

mzedel

Commit Message

fix(gui): prevented device tag editor to be shown when no tags exist

- this is to reduce confusion about tags defined async to the current session not being visible

Ticket: ME-528
Signed-off-by: Manuel Zedel <manuel.zedel@northern.tech>

Pull Request Pull Request #674: ME-529, ME-528 - adjustments to device tag editing

Run Details

29554 of 44564 relevant lines covered (66.32%)

1.45 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

89.29

/backend/pkg/mongo/migrate/version.go

// Copyright 2023 Northern.tech AS
//
//        Licensed under the Apache License, Version 2.0 (the "License");
//        you may not use this file except in compliance with the License.
//        You may obtain a copy of the License at
//
//            http://www.apache.org/licenses/LICENSE-2.0
//
//        Unless required by applicable law or agreed to in writing, software
//        distributed under the License is distributed on an "AS IS" BASIS,
//        WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
//        See the License for the specific language governing permissions and
//        limitations under the License.
package migrate

import (
        "fmt"

        "github.com/pkg/errors"
)

type Version struct {
        Major uint `bson:"major"`
        Minor uint `bson:"minor"`
        Patch uint `bson:"patch"`
}

func NewVersion(s string) (*Version, error) {
        var maj, min, patch uint

        n, err := fmt.Sscanf(s, "%d.%d.%d", &maj, &min, &patch)

        if err != nil {
                return nil, errors.Wrap(err, "failed to parse Version")
        } else if n != 3 {
                return nil, errors.New("invalid semver format")
        }

        return &Version{Major: maj, Minor: min, Patch: patch}, nil
}

func MakeVersion(maj uint, min uint, patch uint) Version {
        return Version{Major: maj, Minor: min, Patch: patch}
}

func (v Version) String() string {
        return fmt.Sprintf("%d.%d.%d", v.Major, v.Minor, v.Patch)
}

func VersionIsLess(left Version, right Version) bool {
        if left.Major < right.Major {
                return true
        } else if left.Major == right.Major {
                if left.Minor < right.Minor {
                        return true
                } else if left.Minor == right.Minor {
                        if left.Patch < right.Patch {
                                return true
                        }
                }
        }
        return false
}

1	// Copyright 2023 Northern.tech AS
2	//
3	// Licensed under the Apache License, Version 2.0 (the "License");
4	// you may not use this file except in compliance with the License.
5	// You may obtain a copy of the License at
6	//
7	// http://www.apache.org/licenses/LICENSE-2.0
8	//
9	// Unless required by applicable law or agreed to in writing, software
10	// distributed under the License is distributed on an "AS IS" BASIS,
11	// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12	// See the License for the specific language governing permissions and
13	// limitations under the License.
14	package migrate
15
16	import (
17	"fmt"
18
19	"github.com/pkg/errors"
20	)
21
22	type Version struct {
23	Major uint `bson:"major"`
24	Minor uint `bson:"minor"`
25	Patch uint `bson:"patch"`
26	}
27
28	func NewVersion(s string) (*Version, error) {	9✔
29	var maj, min, patch uint	9✔
30		9✔
31	n, err := fmt.Sscanf(s, "%d.%d.%d", &maj, &min, &patch)	9✔
32		9✔
33	if err != nil {	9✔
34	return nil, errors.Wrap(err, "failed to parse Version")	×
35	} else if n != 3 {	9✔
36	return nil, errors.New("invalid semver format")	×
37	}	×
38
39	return &Version{Major: maj, Minor: min, Patch: patch}, nil	9✔
40	}
41
42	func MakeVersion(maj uint, min uint, patch uint) Version {	9✔
43	return Version{Major: maj, Minor: min, Patch: patch}	9✔
44	}	9✔
45
46	func (v Version) String() string {	9✔
47	return fmt.Sprintf("%d.%d.%d", v.Major, v.Minor, v.Patch)	9✔
48	}	9✔
49
50	func VersionIsLess(left Version, right Version) bool {	9✔
51	if left.Major < right.Major {	18✔
52	return true	9✔
53	} else if left.Major == right.Major {	27✔
54	if left.Minor < right.Minor {	15✔
55	return true	6✔
56	} else if left.Minor == right.Minor {	24✔
57	if left.Patch < right.Patch {	14✔
58	return true	5✔
59	}	5✔
60	}
61	}
62	return false	9✔
63	}

mendersoftware / mender-server / 1833359013

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous