1833359013

Committed 23 May 2025 01:25PM UTC coverage: 66.318% (+0.5%) from 65.861%

Build # 1833359013

Build Type

Pull #674

gitlab-ci

Committed by

mzedel

Commit Message

fix(gui): prevented device tag editor to be shown when no tags exist

- this is to reduce confusion about tags defined async to the current session not being visible

Ticket: ME-528
Signed-off-by: Manuel Zedel <manuel.zedel@northern.tech>

Pull Request Pull Request #674: ME-529, ME-528 - adjustments to device tag editing

Run Details

29554 of 44564 relevant lines covered (66.32%)

1.45 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

0.0

/backend/pkg/netutils/ip.go

// Copyright 2024 Northern.tech AS
//
//        Licensed under the Apache License, Version 2.0 (the "License");
//        you may not use this file except in compliance with the License.
//        You may obtain a copy of the License at
//
//            http://www.apache.org/licenses/LICENSE-2.0
//
//        Unless required by applicable law or agreed to in writing, software
//        distributed under the License is distributed on an "AS IS" BASIS,
//        WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
//        See the License for the specific language governing permissions and
//        limitations under the License.

package netutils

import (
        "net"
        "net/http"
        "strings"
)

const (
        headerXForwardedFor = "X-Forwarded-For"
)

// GetIPFromXFFDepth gets the IP address at index proxyDepth from the end of the
// list of X-Forwarded-For values. If proxyDepth is 0, the remote address from
// the connection (IP packet) is used.
func GetIPFromXFFDepth(r *http.Request, proxyDepth int) net.IP {
        if proxyDepth == 0 {
                return net.ParseIP(strings.SplitN(r.RemoteAddr, ":", 2)[0])
        }

        xff := r.Header.Values(headerXForwardedFor)
        l := len(xff) - 1
        if l < 0 {
                return nil
        }
        var clientIP net.IP
        for i := len(xff) - 1; i >= 0; i-- {
                ipList := strings.Split(xff[i], ",")
                if numIPs := len(ipList); numIPs >= proxyDepth {
                        ipStr := strings.TrimSpace(ipList[numIPs-proxyDepth])
                        clientIP = net.ParseIP(ipStr)
                        break
                } else {
                        proxyDepth -= numIPs
                }
        }
        return clientIP
}

1	// Copyright 2024 Northern.tech AS
2	//
3	// Licensed under the Apache License, Version 2.0 (the "License");
4	// you may not use this file except in compliance with the License.
5	// You may obtain a copy of the License at
6	//
7	// http://www.apache.org/licenses/LICENSE-2.0
8	//
9	// Unless required by applicable law or agreed to in writing, software
10	// distributed under the License is distributed on an "AS IS" BASIS,
11	// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12	// See the License for the specific language governing permissions and
13	// limitations under the License.
14
15	package netutils
16
17	import (
18	"net"
19	"net/http"
20	"strings"
21	)
22
23	const (
24	headerXForwardedFor = "X-Forwarded-For"
25	)
26
27	// GetIPFromXFFDepth gets the IP address at index proxyDepth from the end of the
28	// list of X-Forwarded-For values. If proxyDepth is 0, the remote address from
29	// the connection (IP packet) is used.
30	func GetIPFromXFFDepth(r *http.Request, proxyDepth int) net.IP {	×
31	if proxyDepth == 0 {	×
32	return net.ParseIP(strings.SplitN(r.RemoteAddr, ":", 2)[0])	×
33	}	×
34
35	xff := r.Header.Values(headerXForwardedFor)	×
36	l := len(xff) - 1	×
37	if l < 0 {	×
38	return nil	×
39	}	×
40	var clientIP net.IP	×
41	for i := len(xff) - 1; i >= 0; i-- {	×
42	ipList := strings.Split(xff[i], ",")	×
43	if numIPs := len(ipList); numIPs >= proxyDepth {	×
44	ipStr := strings.TrimSpace(ipList[numIPs-proxyDepth])	×
45	clientIP = net.ParseIP(ipStr)	×
46	break	×
47	} else {	×
48	proxyDepth -= numIPs	×
49	}	×
50	}
51	return clientIP	×
52	}

mendersoftware / mender-server / 1833359013

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous