mybatis / ibatis-2 / 582

Committed 26 May 2025 08:10PM UTC coverage: 65.509% (-0.009%) from 65.518%

Build # 582

Build Type

Pull #289

github

Committed by

web-flow

Commit Message

Merge b3e816f00 into 6594639fe

Pull Request Pull Request #289: Small code cleanups

Run Details

1608 of 2812 branches covered (57.18%)

12 of 20 new or added lines in 6 files covered. (60.0%)

1 existing line in 1 file now uncovered.

5073 of 7744 relevant lines covered (65.51%)

0.66 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

0.0

/src/main/java/com/ibatis/sqlmap/engine/transaction/jta/JtaTransaction.java

/*
 * Copyright 2004-2025 the original author or authors.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 *    https://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */
package com.ibatis.sqlmap.engine.transaction.jta;

import com.ibatis.common.jdbc.logging.ConnectionLogProxy;
import com.ibatis.common.logging.Log;
import com.ibatis.common.logging.LogFactory;
import com.ibatis.sqlmap.engine.transaction.IsolationLevel;
import com.ibatis.sqlmap.engine.transaction.Transaction;
import com.ibatis.sqlmap.engine.transaction.TransactionException;

import jakarta.transaction.Status;
import jakarta.transaction.UserTransaction;

import java.sql.Connection;
import java.sql.SQLException;

import javax.sql.DataSource;

/**
 * The Class JtaTransaction.
 */
public class JtaTransaction implements Transaction {

  /** The Constant connectionLog. */
  private static final Log connectionLog = LogFactory.getLog(Connection.class);

  /** The user transaction. */
  private UserTransaction userTransaction;

  /** The data source. */
  private DataSource dataSource;

  /** The connection. */
  private Connection connection;

  /** The isolation level. */
  private IsolationLevel isolationLevel = new IsolationLevel();

  /** The commmitted. */
  private boolean commmitted = false;

  /** The new transaction. */
  private boolean newTransaction = false;

  /**
   * Instantiates a new jta transaction.
   *
   * @param utx
   *          the utx
   * @param ds
   *          the ds
   * @param isolationLevel
   *          the isolation level
   *
   * @throws TransactionException
   *           the transaction exception
   */
  public JtaTransaction(UserTransaction utx, DataSource ds, int isolationLevel) throws TransactionException {
    // Check parameters
    userTransaction = utx;
    dataSource = ds;
    if (userTransaction == null) {
      throw new TransactionException("JtaTransaction initialization failed.  UserTransaction was null.");
    }
    if (dataSource == null) {
      throw new TransactionException("JtaTransaction initialization failed.  DataSource was null.");
    }
    this.isolationLevel.setIsolationLevel(isolationLevel);
  }

  /**
   * Inits the.
   *
   * @throws TransactionException
   *           the transaction exception
   * @throws SQLException
   *           the SQL exception
   */
  private void init() throws TransactionException, SQLException {
    // Start JTA Transaction
    try {
      newTransaction = userTransaction.getStatus() == Status.STATUS_NO_TRANSACTION;
      if (newTransaction) {
        userTransaction.begin();
      }
    } catch (Exception e) {
      throw new TransactionException("JtaTransaction could not start transaction.  Cause: ", e);
    }

    // Open JDBC Connection
    connection = dataSource.getConnection();
    if (connection == null) {
      throw new TransactionException(
          "JtaTransaction could not start transaction.  Cause: The DataSource returned a null connection.");
    }
    // Isolation Level
    isolationLevel.applyIsolationLevel(connection);
    // AutoCommit
    if (connection.getAutoCommit()) {
      connection.setAutoCommit(false);
    }
    // Debug
    if (connectionLog.isDebugEnabled()) {
      connection = ConnectionLogProxy.newInstance(connection);
    }
  }

  public void commit() throws SQLException, TransactionException {
    if (connection != null) {
      if (commmitted) {
        throw new TransactionException(
            "JtaTransaction could not commit because this transaction has already been committed.");
      }
      try {
        if (newTransaction) {
          userTransaction.commit();
        }
      } catch (Exception e) {
        throw new TransactionException("JtaTransaction could not commit.  Cause: ", e);
      }
      commmitted = true;
    }
  }

  public void rollback() throws SQLException, TransactionException {
    if (connection != null && !commmitted) {
      try {
        if (userTransaction != null) {
          if (newTransaction) {
            userTransaction.rollback();
          } else {
            userTransaction.setRollbackOnly();
          }
        }
      } catch (Exception e) {
        throw new TransactionException("JtaTransaction could not rollback.  Cause: ", e);
      }
    }
  }

  public void close() throws SQLException, TransactionException {
    if (connection != null) {
      try {
        isolationLevel.restoreIsolationLevel(connection);
      } finally {
        connection.close();
        connection = null;
      }
    }
  }

  public Connection getConnection() throws SQLException, TransactionException {
    if (connection == null) {
      init();
    }
    return connection;
  }

}

1	/*
2	* Copyright 2004-2025 the original author or authors.
3	*
4	* Licensed under the Apache License, Version 2.0 (the "License");
5	* you may not use this file except in compliance with the License.
6	* You may obtain a copy of the License at
7	*
8	* https://www.apache.org/licenses/LICENSE-2.0
9	*
10	* Unless required by applicable law or agreed to in writing, software
11	* distributed under the License is distributed on an "AS IS" BASIS,
12	* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13	* See the License for the specific language governing permissions and
14	* limitations under the License.
15	*/
16	package com.ibatis.sqlmap.engine.transaction.jta;
17
18	import com.ibatis.common.jdbc.logging.ConnectionLogProxy;
19	import com.ibatis.common.logging.Log;
20	import com.ibatis.common.logging.LogFactory;
21	import com.ibatis.sqlmap.engine.transaction.IsolationLevel;
22	import com.ibatis.sqlmap.engine.transaction.Transaction;
23	import com.ibatis.sqlmap.engine.transaction.TransactionException;
24
25	import jakarta.transaction.Status;
26	import jakarta.transaction.UserTransaction;
27
28	import java.sql.Connection;
29	import java.sql.SQLException;
30
31	import javax.sql.DataSource;
32
33	/**
34	* The Class JtaTransaction.
35	*/
36	public class JtaTransaction implements Transaction {
37
38	/** The Constant connectionLog. */
39	private static final Log connectionLog = LogFactory.getLog(Connection.class);	×
40
41	/** The user transaction. */
42	private UserTransaction userTransaction;
43
44	/** The data source. */
45	private DataSource dataSource;
46
47	/** The connection. */
48	private Connection connection;
49
50	/** The isolation level. */
51	private IsolationLevel isolationLevel = new IsolationLevel();	×
52
53	/** The commmitted. */
54	private boolean commmitted = false;	×
55
56	/** The new transaction. */
57	private boolean newTransaction = false;	×
58
59	/**
60	* Instantiates a new jta transaction.
61	*
62	* @param utx
63	* the utx
64	* @param ds
65	* the ds
66	* @param isolationLevel
67	* the isolation level
68	*
69	* @throws TransactionException
70	* the transaction exception
71	*/
72	public JtaTransaction(UserTransaction utx, DataSource ds, int isolationLevel) throws TransactionException {	×
73	// Check parameters
74	userTransaction = utx;	×
75	dataSource = ds;	×
76	if (userTransaction == null) {	×
77	throw new TransactionException("JtaTransaction initialization failed. UserTransaction was null.");	×
78	}
79	if (dataSource == null) {	×
80	throw new TransactionException("JtaTransaction initialization failed. DataSource was null.");	×
81	}
82	this.isolationLevel.setIsolationLevel(isolationLevel);	×
83	}	×
84
85	/**
86	* Inits the.
87	*
88	* @throws TransactionException
89	* the transaction exception
90	* @throws SQLException
91	* the SQL exception
92	*/
93	private void init() throws TransactionException, SQLException {
94	// Start JTA Transaction
95	try {
96	newTransaction = userTransaction.getStatus() == Status.STATUS_NO_TRANSACTION;	×
97	if (newTransaction) {	×
98	userTransaction.begin();	×
99	}
100	} catch (Exception e) {	×
101	throw new TransactionException("JtaTransaction could not start transaction. Cause: ", e);	×
102	}	×
103
104	// Open JDBC Connection
105	connection = dataSource.getConnection();	×
106	if (connection == null) {	×
107	throw new TransactionException(	×
108	"JtaTransaction could not start transaction. Cause: The DataSource returned a null connection.");
109	}
110	// Isolation Level
111	isolationLevel.applyIsolationLevel(connection);	×
112	// AutoCommit
113	if (connection.getAutoCommit()) {	×
114	connection.setAutoCommit(false);	×
115	}
116	// Debug
117	if (connectionLog.isDebugEnabled()) {	×
118	connection = ConnectionLogProxy.newInstance(connection);	×
119	}
120	}	×
121
122	public void commit() throws SQLException, TransactionException {
123	if (connection != null) {	×
124	if (commmitted) {	×
125	throw new TransactionException(	×
126	"JtaTransaction could not commit because this transaction has already been committed.");
127	}
128	try {
129	if (newTransaction) {	×
130	userTransaction.commit();	×
131	}
132	} catch (Exception e) {	×
133	throw new TransactionException("JtaTransaction could not commit. Cause: ", e);	×
134	}	×
135	commmitted = true;	×
136	}
137	}	×
138
139	public void rollback() throws SQLException, TransactionException {
NEW 140	if (connection != null && !commmitted) {	×
141	try {
NEW 142	if (userTransaction != null) {	×
NEW 143	if (newTransaction) {	×
NEW 144	userTransaction.rollback();	×
145	} else {
NEW 146	userTransaction.setRollbackOnly();	×
147	}
148	}
NEW 149	} catch (Exception e) {	×
NEW 150	throw new TransactionException("JtaTransaction could not rollback. Cause: ", e);	×
UNCOV 151	}	×
152	}
153	}	×
154
155	public void close() throws SQLException, TransactionException {
156	if (connection != null) {	×
157	try {
158	isolationLevel.restoreIsolationLevel(connection);	×
159	} finally {
160	connection.close();	×
161	connection = null;	×
162	}
163	}
164	}	×
165
166	public Connection getConnection() throws SQLException, TransactionException {
167	if (connection == null) {	×
168	init();	×
169	}
170	return connection;	×
171	}
172
173	}

mybatis / ibatis-2 / 582

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous