1f6c1201-c246-43ba-a363-8eb9ae11ba8d

Committed 04 Jun 2025 01:10PM UTC coverage: 85.735% (-0.1%) from 85.834%

Build # 1f6c1201-c246-43ba-a363-8eb9ae11ba8d

Build Type

Pull #1527

circleci

Committed by

carolyncole

Commit Message

Extract the request to project mapping into a class
Also fix bug in size parsing

Pull Request Pull Request #1527: Extract the request to project mapping into a class

Run Details

4 of 4 branches covered (100.0%)

19 of 21 new or added lines in 3 files covered. (90.48%)

4 existing lines in 1 file now uncovered.

2891 of 3372 relevant lines covered (85.74%)

496.62 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

88.24

/app/services/request_project_metadata.rb

# frozen_string_literal: true
class RequestProjectMetadata
  class << self
    def convert(request)
      {
        title: request[:project_title],
        description: request[:description],
        status: Project::APPROVED_STATUS,
        data_sponsor: request[:data_sponsor],
        data_manager: request[:data_manager],
        departments: departments(request),
        data_user_read_only: data_users(request),
        project_directory: project_directory(request),
        storage_capacity: storage_capacity(request),
        storage_performance_expectations: { requested: "Standard", approved: "Standard" },
        created_by: nil,
        created_on: request[:created_at]
      }
    end

     private

       def project_directory(request)
         "/tigerdata/#{request[:parent_folder]}/#{request[:project_folder]}"
       end

       def data_users(request)
         request[:user_roles].map { |u| u["uid"] }
       end

       def departments(request)
         request[:departments].map { |d| d["name"] }
       end

       def storage_capacity(request)
         size, unit = request.quota.split(" ")
         if request.custom_quota?
           size = request.storage_size
           unit = request.storage_unit
         end
         {
           size: {
             approved: size,
             requested: size
           },
           unit: {
             approved: unit,
             requested: unit
           }
         }
       end
  end
end

1	# frozen_string_literal: true
2	class RequestProjectMetadata	1✔
3	class << self	1✔
4	def convert(request)	1✔
5	{
6	title: request[:project_title],	3✔
7	description: request[:description],
8	status: Project::APPROVED_STATUS,
9	data_sponsor: request[:data_sponsor],
10	data_manager: request[:data_manager],
11	departments: departments(request),
12	data_user_read_only: data_users(request),
13	project_directory: project_directory(request),
14	storage_capacity: storage_capacity(request),
15	storage_performance_expectations: { requested: "Standard", approved: "Standard" },
16	created_by: nil,
17	created_on: request[:created_at]
18	}
19	end
20
21	private	1✔
22
23	def project_directory(request)	1✔
24	"/tigerdata/#{request[:parent_folder]}/#{request[:project_folder]}"	3✔
25	end
26
27	def data_users(request)	1✔
28	request[:user_roles].map { \|u\| u["uid"] }	6✔
29	end
30
31	def departments(request)	1✔
32	request[:departments].map { \|d\| d["name"] }	7✔
33	end
34
35	def storage_capacity(request)	1✔
36	size, unit = request.quota.split(" ")	3✔
37	if request.custom_quota?	3✔
NEW 38	size = request.storage_size	×
NEW 39	unit = request.storage_unit	×
40	end
41	{
42	size: {	3✔
43	approved: size,
44	requested: size
45	},
46	unit: {
47	approved: unit,
48	requested: unit
49	}
50	}
51	end
52	end
53	end

pulibrary / tigerdata-app / 1f6c1201-c246-43ba-a363-8eb9ae11ba8d

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous