• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

lightningnetwork / lnd / 15736109134

18 Jun 2025 02:46PM UTC coverage: 58.197% (-10.1%) from 68.248%
15736109134

Pull #9752

github

web-flow
Merge d2634a68c into 31c74f20f
Pull Request #9752: routerrpc: reject payment to invoice that don't have payment secret or blinded paths

6 of 13 new or added lines in 2 files covered. (46.15%)

28331 existing lines in 455 files now uncovered.

97860 of 168153 relevant lines covered (58.2%)

1.81 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

86.61
/graph/db/graph_cache.go
1
package graphdb
2

3
import (
4
        "fmt"
5
        "sync"
6

7
        "github.com/btcsuite/btcd/btcutil"
8
        "github.com/lightningnetwork/lnd/graph/db/models"
9
        "github.com/lightningnetwork/lnd/lnwire"
10
        "github.com/lightningnetwork/lnd/routing/route"
11
)
12

13
// DirectedChannel is a type that stores the channel information as seen from
14
// one side of the channel.
15
type DirectedChannel struct {
16
        // ChannelID is the unique identifier of this channel.
17
        ChannelID uint64
18

19
        // IsNode1 indicates if this is the node with the smaller public key.
20
        IsNode1 bool
21

22
        // OtherNode is the public key of the node on the other end of this
23
        // channel.
24
        OtherNode route.Vertex
25

26
        // Capacity is the announced capacity of this channel in satoshis.
27
        Capacity btcutil.Amount
28

29
        // OutPolicySet is a boolean that indicates whether the node has an
30
        // outgoing policy set. For pathfinding only the existence of the policy
31
        // is important to know, not the actual content.
32
        OutPolicySet bool
33

34
        // InPolicy is the incoming policy *from* the other node to this node.
35
        // In path finding, we're walking backward from the destination to the
36
        // source, so we're always interested in the edge that arrives to us
37
        // from the other node.
38
        InPolicy *models.CachedEdgePolicy
39

40
        // Inbound fees of this node.
41
        InboundFee lnwire.Fee
42
}
43

44
// DeepCopy creates a deep copy of the channel, including the incoming policy.
45
func (c *DirectedChannel) DeepCopy() *DirectedChannel {
3✔
46
        channelCopy := *c
3✔
47

3✔
48
        if channelCopy.InPolicy != nil {
6✔
49
                inPolicyCopy := *channelCopy.InPolicy
3✔
50
                channelCopy.InPolicy = &inPolicyCopy
3✔
51

3✔
52
                // The fields for the ToNode can be overwritten by the path
3✔
53
                // finding algorithm, which is why we need a deep copy in the
3✔
54
                // first place. So we always start out with nil values, just to
3✔
55
                // be sure they don't contain any old data.
3✔
56
                channelCopy.InPolicy.ToNodePubKey = nil
3✔
57
                channelCopy.InPolicy.ToNodeFeatures = nil
3✔
58
        }
3✔
59

60
        return &channelCopy
3✔
61
}
62

63
// GraphCache is a type that holds a minimal set of information of the public
64
// channel graph that can be used for pathfinding.
65
type GraphCache struct {
66
        nodeChannels map[route.Vertex]map[uint64]*DirectedChannel
67
        nodeFeatures map[route.Vertex]*lnwire.FeatureVector
68

69
        mtx sync.RWMutex
70
}
71

72
// NewGraphCache creates a new graphCache.
73
func NewGraphCache(preAllocNumNodes int) *GraphCache {
3✔
74
        return &GraphCache{
3✔
75
                nodeChannels: make(
3✔
76
                        map[route.Vertex]map[uint64]*DirectedChannel,
3✔
77
                        // A channel connects two nodes, so we can look it up
3✔
78
                        // from both sides, meaning we get double the number of
3✔
79
                        // entries.
3✔
80
                        preAllocNumNodes*2,
3✔
81
                ),
3✔
82
                nodeFeatures: make(
3✔
83
                        map[route.Vertex]*lnwire.FeatureVector,
3✔
84
                        preAllocNumNodes,
3✔
85
                ),
3✔
86
        }
3✔
87
}
3✔
88

89
// Stats returns statistics about the current cache size.
90
func (c *GraphCache) Stats() string {
3✔
91
        c.mtx.RLock()
3✔
92
        defer c.mtx.RUnlock()
3✔
93

3✔
94
        numChannels := 0
3✔
95
        for node := range c.nodeChannels {
6✔
96
                numChannels += len(c.nodeChannels[node])
3✔
97
        }
3✔
98
        return fmt.Sprintf("num_node_features=%d, num_nodes=%d, "+
3✔
99
                "num_channels=%d", len(c.nodeFeatures), len(c.nodeChannels),
3✔
100
                numChannels)
3✔
101
}
102

103
// AddNodeFeatures adds a graph node and its features to the cache.
104
func (c *GraphCache) AddNodeFeatures(node route.Vertex,
105
        features *lnwire.FeatureVector) {
3✔
106

3✔
107
        c.mtx.Lock()
3✔
108
        defer c.mtx.Unlock()
3✔
109

3✔
110
        c.nodeFeatures[node] = features
3✔
111
}
3✔
112

113
// AddChannel adds a non-directed channel, meaning that the order of policy 1
114
// and policy 2 does not matter, the directionality is extracted from the info
115
// and policy flags automatically. The policy will be set as the outgoing policy
116
// on one node and the incoming policy on the peer's side.
117
func (c *GraphCache) AddChannel(info *models.CachedEdgeInfo,
118
        policy1, policy2 *models.CachedEdgePolicy) {
3✔
119

3✔
120
        if info == nil {
3✔
121
                return
×
122
        }
×
123

124
        if policy1 != nil && policy1.IsDisabled() &&
3✔
125
                policy2 != nil && policy2.IsDisabled() {
6✔
126

3✔
127
                return
3✔
128
        }
3✔
129

130
        // Create the edge entry for both nodes.
131
        c.mtx.Lock()
3✔
132
        c.updateOrAddEdge(info.NodeKey1Bytes, &DirectedChannel{
3✔
133
                ChannelID: info.ChannelID,
3✔
134
                IsNode1:   true,
3✔
135
                OtherNode: info.NodeKey2Bytes,
3✔
136
                Capacity:  info.Capacity,
3✔
137
        })
3✔
138
        c.updateOrAddEdge(info.NodeKey2Bytes, &DirectedChannel{
3✔
139
                ChannelID: info.ChannelID,
3✔
140
                IsNode1:   false,
3✔
141
                OtherNode: info.NodeKey1Bytes,
3✔
142
                Capacity:  info.Capacity,
3✔
143
        })
3✔
144
        c.mtx.Unlock()
3✔
145

3✔
146
        // The policy's node is always the to_node. So if policy 1 has to_node
3✔
147
        // of node 2 then we have the policy 1 as seen from node 1.
3✔
148
        if policy1 != nil {
6✔
149
                fromNode, toNode := info.NodeKey1Bytes, info.NodeKey2Bytes
3✔
150
                if !policy1.IsNode1() {
3✔
UNCOV
151
                        fromNode, toNode = toNode, fromNode
×
UNCOV
152
                }
×
153
                c.UpdatePolicy(policy1, fromNode, toNode)
3✔
154
        }
155
        if policy2 != nil {
6✔
156
                fromNode, toNode := info.NodeKey2Bytes, info.NodeKey1Bytes
3✔
157
                if policy2.IsNode1() {
3✔
UNCOV
158
                        fromNode, toNode = toNode, fromNode
×
UNCOV
159
                }
×
160
                c.UpdatePolicy(policy2, fromNode, toNode)
3✔
161
        }
162
}
163

164
// updateOrAddEdge makes sure the edge information for a node is either updated
165
// if it already exists or is added to that node's list of channels.
166
func (c *GraphCache) updateOrAddEdge(node route.Vertex, edge *DirectedChannel) {
3✔
167
        if len(c.nodeChannels[node]) == 0 {
6✔
168
                c.nodeChannels[node] = make(map[uint64]*DirectedChannel)
3✔
169
        }
3✔
170

171
        c.nodeChannels[node][edge.ChannelID] = edge
3✔
172
}
173

174
// UpdatePolicy updates a single policy on both the from and to node. The order
175
// of the from and to node is not strictly important. But we assume that a
176
// channel edge was added beforehand so that the directed channel struct already
177
// exists in the cache.
178
func (c *GraphCache) UpdatePolicy(policy *models.CachedEdgePolicy, fromNode,
179
        toNode route.Vertex) {
3✔
180

3✔
181
        c.mtx.Lock()
3✔
182
        defer c.mtx.Unlock()
3✔
183

3✔
184
        updatePolicy := func(nodeKey route.Vertex) {
6✔
185
                if len(c.nodeChannels[nodeKey]) == 0 {
3✔
186
                        log.Warnf("Node=%v not found in graph cache", nodeKey)
×
187

×
188
                        return
×
189
                }
×
190

191
                channel, ok := c.nodeChannels[nodeKey][policy.ChannelID]
3✔
192
                if !ok {
3✔
193
                        log.Warnf("Channel=%v not found in graph cache",
×
194
                                policy.ChannelID)
×
195

×
196
                        return
×
197
                }
×
198

199
                // Edge 1 is defined as the policy for the direction of node1 to
200
                // node2.
201
                switch {
3✔
202
                // This is node 1, and it is edge 1, so this is the outgoing
203
                // policy for node 1.
204
                case channel.IsNode1 && policy.IsNode1():
3✔
205
                        channel.OutPolicySet = true
3✔
206
                        policy.InboundFee.WhenSome(func(fee lnwire.Fee) {
6✔
207
                                channel.InboundFee = fee
3✔
208
                        })
3✔
209

210
                // This is node 2, and it is edge 2, so this is the outgoing
211
                // policy for node 2.
212
                case !channel.IsNode1 && !policy.IsNode1():
3✔
213
                        channel.OutPolicySet = true
3✔
214
                        policy.InboundFee.WhenSome(func(fee lnwire.Fee) {
6✔
215
                                channel.InboundFee = fee
3✔
216
                        })
3✔
217

218
                // The other two cases left mean it's the inbound policy for the
219
                // node.
220
                default:
3✔
221
                        channel.InPolicy = policy
3✔
222
                }
223
        }
224

225
        updatePolicy(fromNode)
3✔
226
        updatePolicy(toNode)
3✔
227
}
228

229
// RemoveNode completely removes a node and all its channels (including the
230
// peer's side).
231
func (c *GraphCache) RemoveNode(node route.Vertex) {
3✔
232
        c.mtx.Lock()
3✔
233
        defer c.mtx.Unlock()
3✔
234

3✔
235
        delete(c.nodeFeatures, node)
3✔
236

3✔
237
        // First remove all channels from the other nodes' lists.
3✔
238
        for _, channel := range c.nodeChannels[node] {
3✔
UNCOV
239
                c.removeChannelIfFound(channel.OtherNode, channel.ChannelID)
×
UNCOV
240
        }
×
241

242
        // Then remove our whole node completely.
243
        delete(c.nodeChannels, node)
3✔
244
}
245

246
// RemoveChannel removes a single channel between two nodes.
247
func (c *GraphCache) RemoveChannel(node1, node2 route.Vertex, chanID uint64) {
3✔
248
        c.mtx.Lock()
3✔
249
        defer c.mtx.Unlock()
3✔
250

3✔
251
        // Remove that one channel from both sides.
3✔
252
        c.removeChannelIfFound(node1, chanID)
3✔
253
        c.removeChannelIfFound(node2, chanID)
3✔
254
}
3✔
255

256
// removeChannelIfFound removes a single channel from one side.
257
func (c *GraphCache) removeChannelIfFound(node route.Vertex, chanID uint64) {
3✔
258
        if len(c.nodeChannels[node]) == 0 {
6✔
259
                return
3✔
260
        }
3✔
261

262
        delete(c.nodeChannels[node], chanID)
3✔
263
}
264

265
// getChannels returns a copy of the passed node's channels or nil if there
266
// isn't any.
267
func (c *GraphCache) getChannels(node route.Vertex) []*DirectedChannel {
3✔
268
        c.mtx.RLock()
3✔
269
        defer c.mtx.RUnlock()
3✔
270

3✔
271
        channels, ok := c.nodeChannels[node]
3✔
272
        if !ok {
6✔
273
                return nil
3✔
274
        }
3✔
275

276
        features, ok := c.nodeFeatures[node]
3✔
277
        if !ok {
6✔
278
                // If the features were set to nil explicitly, that's fine here.
3✔
279
                // The router will overwrite the features of the destination
3✔
280
                // node with those found in the invoice if necessary. But if we
3✔
281
                // didn't yet get a node announcement we want to mimic the
3✔
282
                // behavior of the old DB based code that would always set an
3✔
283
                // empty feature vector instead of leaving it nil.
3✔
284
                features = lnwire.EmptyFeatureVector()
3✔
285
        }
3✔
286

287
        toNodeCallback := func() route.Vertex {
6✔
288
                return node
3✔
289
        }
3✔
290

291
        i := 0
3✔
292
        channelsCopy := make([]*DirectedChannel, len(channels))
3✔
293
        for _, channel := range channels {
6✔
294
                // We need to copy the channel and policy to avoid it being
3✔
295
                // updated in the cache if the path finding algorithm sets
3✔
296
                // fields on it (currently only the ToNodeFeatures of the
3✔
297
                // policy).
3✔
298
                channelCopy := channel.DeepCopy()
3✔
299
                if channelCopy.InPolicy != nil {
6✔
300
                        channelCopy.InPolicy.ToNodePubKey = toNodeCallback
3✔
301
                        channelCopy.InPolicy.ToNodeFeatures = features
3✔
302
                }
3✔
303

304
                channelsCopy[i] = channelCopy
3✔
305
                i++
3✔
306
        }
307

308
        return channelsCopy
3✔
309
}
310

311
// ForEachChannel invokes the given callback for each channel of the given node.
312
func (c *GraphCache) ForEachChannel(node route.Vertex,
313
        cb func(channel *DirectedChannel) error) error {
3✔
314

3✔
315
        // Obtain a copy of the node's channels. We need do this in order to
3✔
316
        // avoid deadlocks caused by interaction with the graph cache, channel
3✔
317
        // state and the graph database from multiple goroutines. This snapshot
3✔
318
        // is only used for path finding where being stale is acceptable since
3✔
319
        // the real world graph and our representation may always become
3✔
320
        // slightly out of sync for a short time and the actual channel state
3✔
321
        // is stored separately.
3✔
322
        channels := c.getChannels(node)
3✔
323
        for _, channel := range channels {
6✔
324
                if err := cb(channel); err != nil {
6✔
325
                        return err
3✔
326
                }
3✔
327
        }
328

329
        return nil
3✔
330
}
331

332
// ForEachNode iterates over the adjacency list of the graph, executing the
333
// call back for each node and the set of channels that emanate from the given
334
// node.
335
//
336
// NOTE: This method should be considered _read only_, the channels or nodes
337
// passed in MUST NOT be modified.
338
func (c *GraphCache) ForEachNode(cb func(node route.Vertex,
UNCOV
339
        channels map[uint64]*DirectedChannel) error) error {
×
UNCOV
340

×
UNCOV
341
        c.mtx.RLock()
×
UNCOV
342
        defer c.mtx.RUnlock()
×
UNCOV
343

×
UNCOV
344
        for node, channels := range c.nodeChannels {
×
UNCOV
345
                // We don't make a copy here since this is a read-only RPC
×
UNCOV
346
                // call. We also don't need the node features either for this
×
UNCOV
347
                // call.
×
UNCOV
348
                if err := cb(node, channels); err != nil {
×
349
                        return err
×
350
                }
×
351
        }
352

UNCOV
353
        return nil
×
354
}
355

356
// GetFeatures returns the features of the node with the given ID. If no
357
// features are known for the node, an empty feature vector is returned.
358
func (c *GraphCache) GetFeatures(node route.Vertex) *lnwire.FeatureVector {
3✔
359
        c.mtx.RLock()
3✔
360
        defer c.mtx.RUnlock()
3✔
361

3✔
362
        features, ok := c.nodeFeatures[node]
3✔
363
        if !ok || features == nil {
6✔
364
                // The router expects the features to never be nil, so we return
3✔
365
                // an empty feature set instead.
3✔
366
                return lnwire.EmptyFeatureVector()
3✔
367
        }
3✔
368

369
        return features
3✔
370
}
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2025 Coveralls, Inc