5c5fd8cc-c42a-44cb-88c5-ff68a1eb5f3a

Committed 16 Jul 2025 10:42PM UTC coverage: 95.366% (-0.001%) from 95.367%

Build # 5c5fd8cc-c42a-44cb-88c5-ff68a1eb5f3a

Build Type

Pull #4962

circleci

Committed by

web-flow

Commit Message

Merge pull request #4992 from pulibrary/library_display-search-results

Display only the library name in search results

Pull Request Pull Request #4962: Orangelight pos workcycle 07-07-2025

Run Details

88 of 92 new or added lines in 15 files covered. (95.65%)

1 existing line in 1 file now uncovered.

6051 of 6345 relevant lines covered (95.37%)

1513.59 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

95.65

/app/helpers/application_helper.rb

# frozen_string_literal: false

module ApplicationHelper
  require './lib/orangelight/string_functions'

  # Check the Rails Environment. Currently used for Matomo to support production.
  def rails_env?
    Rails.env.production?
  end

  def show_regular_search?
    !((%w[generate numismatics advanced_search].include? params[:action]) || (%w[advanced].include? params[:controller]))
  end

  # Generate the markup for the block containing links for requests to item holdings
  # holding record fields: 'location', 'library', 'location_code', 'call_number', 'call_number_browse',
  # 'shelving_title', 'location_note', 'electronic_access_1display', 'location_has', 'location_has_current',
  # 'indexes', 'supplements'
  # process online and physical holding information at the same time
  # @param [SolrDocument] document - record display fields
  # @return [String] online - online holding info html
  # @return [String] physical - physical holding info html
  def holding_request_block(document)
    adapter = HoldingRequestsAdapter.new(document, Bibdata)
    markup_builder = HoldingRequestsBuilder.new(adapter:,
                                                online_markup_builder: OnlineHoldingsMarkupBuilder,
                                                physical_markup_builder: PhysicalHoldingsMarkupBuilder)
    online_markup, physical_markup = markup_builder.build
    [online_markup, physical_markup]
  end

  # Determine whether or not a ReCAP holding has items restricted to supervised use
  # @param holding [Hash] holding values
  # @return [TrueClass, FalseClass]
  def scsb_supervised_items?(holding)
    if holding.key? 'items'
      restricted_items = holding['items'].select { |item| item['use_statement'] == 'Supervised Use' }
      restricted_items.count == holding['items'].count
    else
      false
    end
  end

  # Blacklight index field helper for the facet "series_display"
  # @param args [Hash]
  def series_results(args)
    series_display =
      if params[:f1] == 'in_series'
        same_series_result(params[:q1], args[:document][args[:field]])
      else
        args[:document][args[:field]]
      end
    series_display.join(', ')
  end

  # Retrieve the same series for that one being displayed
  # @param series [String] series name
  # @param series_display [Array<String>] series being displayed
  # @param [Array<String>] similarly named series
  def same_series_result(series, series_display)
    series_display.select { |t| t.start_with?(series) }
  end

  # Determines whether or not this is an aeon location (for an item holding)
  # @param location [Hash] location values
  # @return [TrueClass, FalseClass]
  def aeon_location?(location)
    location.nil? ? false : location[:aeon_location]
  end

  # Retrieve the location information for a given item holding
  # @param [Hash] holding values
  def holding_location(holding)
    location_code = holding.fetch('location_code', '').to_sym
    resolved_location = Bibdata.holding_locations[location_code]
    resolved_location ? resolved_location : {}
  end

  # Location display in the search results page
  def search_location_display(holding)
    location = holding_library_label(holding)

    location_display = content_tag(:div, location, class: 'results_location') + " " +
                       content_tag(:div, holding['call_number'], class: 'call-number')
    location_display.html_safe
  end

  def title_hierarchy(args)
    titles = JSON.parse(args[:document][args[:field]])
    all_links = []
    dirtags = []

    titles.each do |title|
      title_links = []
      title.each_with_index do |part, index|
        link_accum = StringFunctions.trim_punctuation(title[0..index].join(' '))
        title_links << link_to(part, "/?search_field=left_anchor&q=#{CGI.escape link_accum}", class: 'search-title', 'data-original-title' => "Search: #{link_accum}", title: "Search: #{link_accum}")
      end
      full_title = title.join(' ')
      dirtags << StringFunctions.trim_punctuation(full_title.dir.to_s)
      all_links << title_links.join('<span> </span>').html_safe
    end

    if all_links.length == 1
      all_links = content_tag(:div, all_links[0], dir: dirtags[0])
    else
      all_links = all_links.map.with_index { |l, i| content_tag(:li, l, dir: dirtags[i]) }
      all_links = content_tag(:ul, all_links.join.html_safe)
    end
    all_links
  end

  def action_notes_display(args)
    action_notes = JSON.parse(args[:document][args[:field]])
    lines = action_notes.map do |note|
      if note["uri"].present?
        link_to(note["description"], note["uri"])
      else
        note["description"]
      end
    end

    if lines.length == 1
      lines = content_tag(:div, lines[0])
    else
      lines = lines.map.with_index { |l| content_tag(:li, l) }
      lines = content_tag(:ul, lines.join.html_safe)
    end
    lines
  end

  def name_title_hierarchy(args)
    name_titles = JSON.parse(args[:document][args[:field]])
    all_links = []
    dirtags = []
    name_titles.each do |name_t|
      name_title_links = []
      name_t.each_with_index do |part, i|
        link_accum = StringFunctions.trim_punctuation(name_t[0..i].join(' '))
        if i.zero?
          next if args[:field] == 'name_uniform_title_1display'
          name_title_links << link_to(part, "/?f[author_s][]=#{CGI.escape link_accum}", class: 'search-name-title', 'data-original-title' => "Search: #{link_accum}")
        else
          name_title_links << link_to(part, "/?f[name_title_browse_s][]=#{CGI.escape link_accum}", class: 'search-name-title', 'data-original-title' => "Search: #{link_accum}")
        end
      end
      full_name_title = name_t.join(' ')
      dirtags << StringFunctions.trim_punctuation(full_name_title.dir.to_s)
      name_title_links << link_to('[Browse]', "/browse/name_titles?q=#{CGI.escape full_name_title}", class: 'browse-name-title', 'data-original-title' => "Browse: #{full_name_title}", dir: full_name_title.dir.to_s)
      all_links << name_title_links.join('<span> </span>').html_safe
    end

    if all_links.length == 1
      all_links = content_tag(:div, all_links[0], dir: dirtags[0])
    else
      all_links = all_links.map.with_index { |l, i| content_tag(:li, l, dir: dirtags[i]) }
      all_links = content_tag(:ul, all_links.join.html_safe)
    end
    all_links
  end

  def format_render(args)
    args[:document][args[:field]].join(', ')
  end

  def location_has(args)
    location_notes = JSON.parse(args[:document][:holdings_1display]).collect { |_k, v| v['location_has'] }.flatten
    if location_notes.length > 1
      content_tag(:ul) do
        location_notes.map { |note| content_tag(:li, note) }.join.html_safe
      end
    else
      location_notes
    end
  end

  def bibdata_location_code_to_sym(value)
    Bibdata.holding_locations[value.to_sym]
  end

  def render_location_code(value)
    values = normalize_location_code(value).map do |loc|
      location = Bibdata.holding_locations[loc.to_sym]
      location.nil? ? loc : "#{loc}: #{location_full_display(location)}"
    end
    values.one? ? values.first : values
  end

  # Depending on the url, we sometimes get strings, arrays, or hashes
  # Returns Array of locations
  def normalize_location_code(value)
    case value
    when String
      Array(value)
    when Array
      value
    when Hash, ActiveSupport::HashWithIndifferentAccess
      value.values
    else
      value
    end
  end

  def holding_location_label(holding)
    location_code = holding['location_code']
    bibdata_location = bibdata_location_code_to_sym(location_code) unless location_code.nil?
    # If the Bibdata location is nil, use the location value from the solr document.
    alma_location_display(holding, bibdata_location) unless bibdata_location.blank? && holding.blank?
  end

  def holding_library_label(holding)
    location_code = holding['location_code']

    bibdata_location = bibdata_location_code_to_sym(location_code) unless location_code.nil?
    return holding['library'] if bibdata_location.nil?

    alma_library_display(holding, bibdata_location) unless bibdata_location.blank? && holding.blank?
  end

  # Alma location display on search results
  def alma_location_display(holding, location)
    if location.nil?
      [holding['library'], holding['location']].select(&:present?).join(' - ')
    else
      [location['library']['label'], location['label']].select(&:present?).join(' - ')
    end
  end

  def alma_library_display(holding, bibdata_location)
    return holding['library'] if bibdata_location.nil?
    bibdata_location['library']['label']
  end

  # location = Bibdata.holding_locations[value.to_sym]
  def location_full_display(loc)
    loc['label'] == '' ? loc['library']['label'] : loc['library']['label'] + ' - ' + loc['label']
  end

  def html_safe(args)
    args[:document][args[:field]].each_with_index { |v, i| args[:document][args[:field]][i] = v.html_safe }
  end

  def current_year
    DateTime.now.year
  end

  # Construct an adapter for Solr Documents and the bib. data service
  # @return [HoldingRequestsAdapter]
  def holding_requests_adapter
    HoldingRequestsAdapter.new(@document, Bibdata)
  end

  # Returns true for locations with remote storage.
  # Remote storage locations have a value of 'recap_rmt' in Alma.
  def remote_storage?(location_code)
    Bibdata.holding_locations[location_code]["remote_storage"] == 'recap_rmt'
  end

  # Returns true for locations where the user can walk and fetch an item.
  # Currently this logic is duplicated in Javascript code in availability.es6
  def find_it_location?(location_code)
    return false if remote_storage?(location_code)
    return false if (location_code || "").start_with?("plasma$", "marquand$")

    return false if StackmapService::Url.missing_stackmap_reserves.include?(location_code)

    true
  end

  # Testing this feature with Voice Over - reading the Web content
  # If language defaults to english 'en' when no language_iana_primary_s exists then:
  # for cyrilic: for example russian, voice over will read each character as: cyrilic <character1>, cyrilic <character2>
  # for japanese it announces <character> ideograph
  # If there is no lang attribute it announces the same as having lang='en'
  def language_iana
    @document[:language_iana_s].present? ? @document[:language_iana_s].first : 'en'
  end

  def should_show_viewer?
    request.human? && controller.action_name != "librarian_view"
  end
end

1	# frozen_string_literal: false
2
3	module ApplicationHelper	3✔
4	require './lib/orangelight/string_functions'	3✔
5
6	# Check the Rails Environment. Currently used for Matomo to support production.
7	def rails_env?	3✔
8	Rails.env.production?	484✔
9	end
10
11	def show_regular_search?	3✔
12	!((%w[generate numismatics advanced_search].include? params[:action]) \|\| (%w[advanced].include? params[:controller]))	968✔
13	end
14
15	# Generate the markup for the block containing links for requests to item holdings
16	# holding record fields: 'location', 'library', 'location_code', 'call_number', 'call_number_browse',
17	# 'shelving_title', 'location_note', 'electronic_access_1display', 'location_has', 'location_has_current',
18	# 'indexes', 'supplements'
19	# process online and physical holding information at the same time
20	# @param [SolrDocument] document - record display fields
21	# @return [String] online - online holding info html
22	# @return [String] physical - physical holding info html
23	def holding_request_block(document)	3✔
24	adapter = HoldingRequestsAdapter.new(document, Bibdata)	108✔
25	markup_builder = HoldingRequestsBuilder.new(adapter:,	108✔
26	online_markup_builder: OnlineHoldingsMarkupBuilder,
27	physical_markup_builder: PhysicalHoldingsMarkupBuilder)
28	online_markup, physical_markup = markup_builder.build	108✔
29	[online_markup, physical_markup]	108✔
30	end
31
32	# Determine whether or not a ReCAP holding has items restricted to supervised use
33	# @param holding [Hash] holding values
34	# @return [TrueClass, FalseClass]
35	def scsb_supervised_items?(holding)	3✔
36	if holding.key? 'items'	12✔
37	restricted_items = holding['items'].select { \|item\| item['use_statement'] == 'Supervised Use' }	63✔
38	restricted_items.count == holding['items'].count	12✔
39	else
40	false	×
41	end
42	end
43
44	# Blacklight index field helper for the facet "series_display"
45	# @param args [Hash]
46	def series_results(args)	3✔
47	series_display =
48	if params[:f1] == 'in_series'	3✔
49	same_series_result(params[:q1], args[:document][args[:field]])	×
50	else
51	args[:document][args[:field]]	3✔
52	end
53	series_display.join(', ')	3✔
54	end
55
56	# Retrieve the same series for that one being displayed
57	# @param series [String] series name
58	# @param series_display [Array<String>] series being displayed
59	# @param [Array<String>] similarly named series
60	def same_series_result(series, series_display)	3✔
61	series_display.select { \|t\| t.start_with?(series) }	8✔
62	end
63
64	# Determines whether or not this is an aeon location (for an item holding)
65	# @param location [Hash] location values
66	# @return [TrueClass, FalseClass]
67	def aeon_location?(location)	3✔
68	location.nil? ? false : location[:aeon_location]	755✔
69	end
70
71	# Retrieve the location information for a given item holding
72	# @param [Hash] holding values
73	def holding_location(holding)	3✔
74	location_code = holding.fetch('location_code', '').to_sym	1,502✔
75	resolved_location = Bibdata.holding_locations[location_code]	1,502✔
76	resolved_location ? resolved_location : {}	1,502✔
77	end
78
79	# Location display in the search results page
80	def search_location_display(holding)	3✔
81	location = holding_library_label(holding)	751✔
82
83	location_display = content_tag(:div, location, class: 'results_location') + " " +	751✔
84	content_tag(:div, holding['call_number'], class: 'call-number')
85	location_display.html_safe	751✔
86	end
87
88	def title_hierarchy(args)	3✔
89	titles = JSON.parse(args[:document][args[:field]])	6✔
90	all_links = []	6✔
91	dirtags = []	6✔
92
93	titles.each do \|title\|	6✔
94	title_links = []	6✔
95	title.each_with_index do \|part, index\|	6✔
96	link_accum = StringFunctions.trim_punctuation(title[0..index].join(' '))	21✔
97	title_links << link_to(part, "/?search_field=left_anchor&q=#{CGI.escape link_accum}", class: 'search-title', 'data-original-title' => "Search: #{link_accum}", title: "Search: #{link_accum}")	21✔
98	end
99	full_title = title.join(' ')	6✔
100	dirtags << StringFunctions.trim_punctuation(full_title.dir.to_s)	6✔
101	all_links << title_links.join('<span> </span>').html_safe	6✔
102	end
103
104	if all_links.length == 1	6✔
105	all_links = content_tag(:div, all_links[0], dir: dirtags[0])	6✔
106	else
107	all_links = all_links.map.with_index { \|l, i\| content_tag(:li, l, dir: dirtags[i]) }	×
108	all_links = content_tag(:ul, all_links.join.html_safe)	×
109	end
110	all_links	6✔
111	end
112
113	def action_notes_display(args)	3✔
114	action_notes = JSON.parse(args[:document][args[:field]])	3✔
115	lines = action_notes.map do \|note\|	3✔
116	if note["uri"].present?	4✔
117	link_to(note["description"], note["uri"])	1✔
118	else
119	note["description"]	3✔
120	end
121	end
122
123	if lines.length == 1	3✔
124	lines = content_tag(:div, lines[0])	2✔
125	else
126	lines = lines.map.with_index { \|l\| content_tag(:li, l) }	3✔
127	lines = content_tag(:ul, lines.join.html_safe)	1✔
128	end
129	lines	3✔
130	end
131
132	def name_title_hierarchy(args)	3✔
133	name_titles = JSON.parse(args[:document][args[:field]])	23✔
134	all_links = []	23✔
135	dirtags = []	23✔
136	name_titles.each do \|name_t\|	23✔
137	name_title_links = []	116✔
138	name_t.each_with_index do \|part, i\|	116✔
139	link_accum = StringFunctions.trim_punctuation(name_t[0..i].join(' '))	344✔
140	if i.zero?	344✔
141	next if args[:field] == 'name_uniform_title_1display'	116✔
142	name_title_links << link_to(part, "/?f[author_s][]=#{CGI.escape link_accum}", class: 'search-name-title', 'data-original-title' => "Search: #{link_accum}")	103✔
143	else
144	name_title_links << link_to(part, "/?f[name_title_browse_s][]=#{CGI.escape link_accum}", class: 'search-name-title', 'data-original-title' => "Search: #{link_accum}")	228✔
145	end
146	end
147	full_name_title = name_t.join(' ')	116✔
148	dirtags << StringFunctions.trim_punctuation(full_name_title.dir.to_s)	116✔
149	name_title_links << link_to('[Browse]', "/browse/name_titles?q=#{CGI.escape full_name_title}", class: 'browse-name-title', 'data-original-title' => "Browse: #{full_name_title}", dir: full_name_title.dir.to_s)	116✔
150	all_links << name_title_links.join('<span> </span>').html_safe	116✔
151	end
152
153	if all_links.length == 1	23✔
154	all_links = content_tag(:div, all_links[0], dir: dirtags[0])	8✔
155	else
156	all_links = all_links.map.with_index { \|l, i\| content_tag(:li, l, dir: dirtags[i]) }	123✔
157	all_links = content_tag(:ul, all_links.join.html_safe)	15✔
158	end
159	all_links	23✔
160	end
161
162	def format_render(args)	3✔
163	args[:document][args[:field]].join(', ')	107✔
164	end
165
166	def location_has(args)	3✔
167	location_notes = JSON.parse(args[:document][:holdings_1display]).collect { \|_k, v\| v['location_has'] }.flatten	4✔
168	if location_notes.length > 1	2✔
169	content_tag(:ul) do	1✔
170	location_notes.map { \|note\| content_tag(:li, note) }.join.html_safe	3✔
171	end
172	else
173	location_notes	1✔
174	end
175	end
176
177	def bibdata_location_code_to_sym(value)	3✔
178	Bibdata.holding_locations[value.to_sym]	776✔
179	end
180
181	def render_location_code(value)	3✔
182	values = normalize_location_code(value).map do \|loc\|	4,662✔
183	location = Bibdata.holding_locations[loc.to_sym]	4,665✔
184	location.nil? ? loc : "#{loc}: #{location_full_display(location)}"	4,665✔
185	end
186	values.one? ? values.first : values	4,662✔
187	end
188
189	# Depending on the url, we sometimes get strings, arrays, or hashes
190	# Returns Array of locations
191	def normalize_location_code(value)	3✔
192	case value	4,662✔
193	when String
194	Array(value)	4,658✔
195	when Array
196	value	2✔
197	when Hash, ActiveSupport::HashWithIndifferentAccess
198	value.values	2✔
199	else
NEW 200	value	×
201	end
202	end
203
204	def holding_location_label(holding)	3✔
205	location_code = holding['location_code']	24✔
206	bibdata_location = bibdata_location_code_to_sym(location_code) unless location_code.nil?	24✔
207	# If the Bibdata location is nil, use the location value from the solr document.
208	alma_location_display(holding, bibdata_location) unless bibdata_location.blank? && holding.blank?	24✔
209	end
210
211	def holding_library_label(holding)	3✔
212	location_code = holding['location_code']	753✔
213
214	bibdata_location = bibdata_location_code_to_sym(location_code) unless location_code.nil?	753✔
215	return holding['library'] if bibdata_location.nil?	753✔
216
217	alma_library_display(holding, bibdata_location) unless bibdata_location.blank? && holding.blank?	748✔
218	end
219
220	# Alma location display on search results
221	def alma_location_display(holding, location)	3✔
222	if location.nil?	23✔
223	[holding['library'], holding['location']].select(&:present?).join(' - ')	3✔
224	else
225	[location['library']['label'], location['label']].select(&:present?).join(' - ')	20✔
226	end
227	end
228
229	def alma_library_display(holding, bibdata_location)	3✔
230	return holding['library'] if bibdata_location.nil?	748✔
231	bibdata_location['library']['label']	748✔
232	end
233
234	# location = Bibdata.holding_locations[value.to_sym]
235	def location_full_display(loc)	3✔
236	loc['label'] == '' ? loc['library']['label'] : loc['library']['label'] + ' - ' + loc['label']	3,837✔
237	end
238
239	def html_safe(args)	3✔
240	args[:document][args[:field]].each_with_index { \|v, i\| args[:document][args[:field]][i] = v.html_safe }	×
241	end
242
243	def current_year	3✔
244	DateTime.now.year	1✔
245	end
246
247	# Construct an adapter for Solr Documents and the bib. data service
248	# @return [HoldingRequestsAdapter]
249	def holding_requests_adapter	3✔
250	HoldingRequestsAdapter.new(@document, Bibdata)	121✔
251	end
252
253	# Returns true for locations with remote storage.
254	# Remote storage locations have a value of 'recap_rmt' in Alma.
255	def remote_storage?(location_code)	3✔
256	Bibdata.holding_locations[location_code]["remote_storage"] == 'recap_rmt'	133✔
257	end
258
259	# Returns true for locations where the user can walk and fetch an item.
260	# Currently this logic is duplicated in Javascript code in availability.es6
261	def find_it_location?(location_code)	3✔
262	return false if remote_storage?(location_code)	133✔
263	return false if (location_code \|\| "").start_with?("plasma$", "marquand$")	107✔
264
265	return false if StackmapService::Url.missing_stackmap_reserves.include?(location_code)	103✔
266
267	true	103✔
268	end
269
270	# Testing this feature with Voice Over - reading the Web content
271	# If language defaults to english 'en' when no language_iana_primary_s exists then:
272	# for cyrilic: for example russian, voice over will read each character as: cyrilic <character1>, cyrilic <character2>
273	# for japanese it announces <character> ideograph
274	# If there is no lang attribute it announces the same as having lang='en'
275	def language_iana	3✔
276	@document[:language_iana_s].present? ? @document[:language_iana_s].first : 'en'	129✔
277	end
278
279	def should_show_viewer?	3✔
280	request.human? && controller.action_name != "librarian_view"	110✔
281	end
282	end

pulibrary / orangelight / 5c5fd8cc-c42a-44cb-88c5-ff68a1eb5f3a

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous