c1334afc-8192-4921-bc83-781c5a9481a2

Committed 24 Jul 2025 06:56PM UTC coverage: 95.167% (-0.2%) from 95.407%

Build # c1334afc-8192-4921-bc83-781c5a9481a2

Build Type

Pull #4962

circleci

Committed by

web-flow

Commit Message

Bookmark all button: address a small layout shift (#5055)

Before vue has rendered the bookmark all button, let's reserve some
space for the button.

Also, remove some now unused CSS.

Pull Request Pull Request #4962: Orangelight pos workcycle 07-07-2025

Run Details

140 of 143 new or added lines in 16 files covered. (97.9%)

16 existing lines in 5 files now uncovered.

6085 of 6394 relevant lines covered (95.17%)

1512.86 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

60.0

/app/services/stackmap_location_factory.rb

# frozen_string_literal: true

class StackmapLocationFactory
  # Constructor
  # @param resolver_service [Class] API for the resolution service
  def initialize(resolver_service:)
    @resolver_service = resolver_service
  end

  # Checks to see if provided holding info should resolve to a stackmap url
  # @param call_number [String] the call number for the holding
  # @param library [String] the library in which the holding is located
  # @return [Boolean] Exclude stackmap url if return value is true
  def exclude?(call_number:, library:)
    excluded?(library) || call_number?(call_number, library)
  end

  private

    # Whether or not a library should exclude a holding from having its location resolved
    # @param library [String] the library in which the holding resides
    # @return [TrueClass, FalseClass]
    def excluded?(library)
      [
        'Fine Annex',
        'Forrestal Annex',
        'Mudd Manuscript Library',
        'Online',
        'Rare Books and Special Collections',
        'ReCAP',
        'Marquand Library'
      ].include?(library)
    end

    # Exclude the stackmap link for records without call numbers,
    # unless they are in Firestone (other locator works without a call number)
    def call_number?(call_number, library)
      call_number.nil? && library != 'Firestone Library'
    end
end

1	# frozen_string_literal: true
2
3	class StackmapLocationFactory	3✔
4	# Constructor
5	# @param resolver_service [Class] API for the resolution service
6	def initialize(resolver_service:)	3✔
UNCOV 7	@resolver_service = resolver_service	×
8	end
9
10	# Checks to see if provided holding info should resolve to a stackmap url
11	# @param call_number [String] the call number for the holding
12	# @param library [String] the library in which the holding is located
13	# @return [Boolean] Exclude stackmap url if return value is true
14	def exclude?(call_number:, library:)	3✔
UNCOV 15	excluded?(library) \|\| call_number?(call_number, library)	×
16	end
17
18	private	3✔
19
20	# Whether or not a library should exclude a holding from having its location resolved
21	# @param library [String] the library in which the holding resides
22	# @return [TrueClass, FalseClass]
23	def excluded?(library)	3✔
24	[
25	'Fine Annex',
26	'Forrestal Annex',
27	'Mudd Manuscript Library',
28	'Online',
29	'Rare Books and Special Collections',
30	'ReCAP',
31	'Marquand Library'
UNCOV 32	].include?(library)	×
33	end
34
35	# Exclude the stackmap link for records without call numbers,
36	# unless they are in Firestone (other locator works without a call number)
37	def call_number?(call_number, library)	3✔
UNCOV 38	call_number.nil? && library != 'Firestone Library'	×
39	end
40	end

pulibrary / orangelight / c1334afc-8192-4921-bc83-781c5a9481a2

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous