454bc7c2-3cd4-490f-b9b3-912d91b545c9

Committed 11 Aug 2025 05:37PM UTC coverage: 76.482% (-0.05%) from 76.534%

Build # 454bc7c2-3cd4-490f-b9b3-912d91b545c9

Build Type

push

circleci

Committed by

web-flow

Commit Message

Minor tweaks to the exception handling (#1716)

Run Details

0 of 2 new or added lines in 1 file covered. (0.0%)

2270 of 2968 relevant lines covered (76.48%)

176.51 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

54.55

/app/operations/project_create.rb

# frozen_string_literal: true
class ProjectCreate < Dry::Operation
  class ProjectCreateError < StandardError; end

  # TODO: Remove the optional project parameter once https://github.com/pulibrary/tigerdata-app/issues/1707
  # has been completed. In practice the project is always created from the request.
  def call(request:, approver:, project: nil)
    if project.nil?
      project = step create_project_from_request(request)
    end
    mediaflux_id = step persist_in_mediaflux(project, approver)
    step update_project_with_mediaflux_info(mediaflux_id:, project:)
    step persist_users_in_mediaflux(project, approver)
  end

  private

    def create_project_from_request(request)
      # Create the project in the Rails database
      project_metadata_json = RequestProjectMetadata.convert(request)
      project = Project.create!({ metadata_json: project_metadata_json })
      project.draft_doi
      project.save!

      # Return Success(attrs) or Failure(error)
      Success project
    rescue => ex
      Failure("Error creating the project: #{ex}")
    end

    def persist_in_mediaflux(project, current_user)
      # Create the project in Mediaflux
      mediaflux_request = Mediaflux::ProjectCreateServiceRequest.new(session_token: current_user.mediaflux_session, project: project)
      mediaflux_request.resolve

      mediaflux_id = mediaflux_request.mediaflux_id

      if mediaflux_id.to_i == 0
        debug_output = "Error saving project #{project.id} to Mediaflux: #{mediaflux_request.response_error}. Debug output: #{mediaflux_request.debug_output}"
        Rails.logger.error debug_output

        # we do not want unsaved projects just hanging around
        project.destroy!
        Failure debug_output
      else
        ProvenanceEvent.generate_approval_events(project: project, user: current_user, debug_output: mediaflux_request.debug_output.to_s)
        Success(mediaflux_id)
      end
    rescue => ex
      Failure("Error saving project #{project.id} to Mediaflux: #{ex}")
    end

    def update_project_with_mediaflux_info(mediaflux_id:, project:)
      project.mediaflux_id = mediaflux_id
      project.metadata_model.status = Project::APPROVED_STATUS
      project.save!
      Success(project)
    rescue => ex
      # TODO: It was saved in mediaflux, so maybe a retry here?  I don't want to destroy the project
      Failure("Setting the mediaflux id the project(#{project.id}) : #{ex}")
    end

    def persist_users_in_mediaflux(project, current_user)
      # Do nothing if there are no users to persist
      return Success(project) if (project.metadata_model.ro_users + project.metadata_model.rw_users).empty?

      # Add the data users to the project in Mediaflux
      add_users_request = Mediaflux::ProjectUserAddRequest.new(session_token: current_user.mediaflux_session, project: project)
      add_users_request.resolve

      if add_users_request.error?
        # TODO: what should we do with the project in this case?  It got all the way to mediaflux, but the users were not added
        Failure("Error adding users to mediaflux project #{project.mediaflux_id} #{add_users_request.response_error}")
      else
        user_debug = add_users_request.debug_output.to_s
        Rails.logger.debug { "Project #{project.id} users have been added to MediaFlux: #{user_debug}" }
        Success project
      end
    rescue => ex
      Failure("Exception adding users to mediaflux project #{project.mediaflux_id}: #{ex}")
    end
end

1	# frozen_string_literal: true
2	class ProjectCreate < Dry::Operation	1✔
3	class ProjectCreateError < StandardError; end	1✔
4
5	# TODO: Remove the optional project parameter once https://github.com/pulibrary/tigerdata-app/issues/1707
6	# has been completed. In practice the project is always created from the request.
7	def call(request:, approver:, project: nil)	1✔
8	if project.nil?	1✔
9	project = step create_project_from_request(request)	1✔
10	end
11	mediaflux_id = step persist_in_mediaflux(project, approver)	1✔
12	step update_project_with_mediaflux_info(mediaflux_id:, project:)	×
13	step persist_users_in_mediaflux(project, approver)	×
14	end
15
16	private	1✔
17
18	def create_project_from_request(request)	1✔
19	# Create the project in the Rails database
20	project_metadata_json = RequestProjectMetadata.convert(request)	1✔
21	project = Project.create!({ metadata_json: project_metadata_json })	1✔
22	project.draft_doi	1✔
23	project.save!	1✔
24
25	# Return Success(attrs) or Failure(error)
26	Success project	1✔
27	rescue => ex
28	Failure("Error creating the project: #{ex}")	×
29	end
30
31	def persist_in_mediaflux(project, current_user)	1✔
32	# Create the project in Mediaflux
33	mediaflux_request = Mediaflux::ProjectCreateServiceRequest.new(session_token: current_user.mediaflux_session, project: project)	1✔
34	mediaflux_request.resolve	1✔
35
36	mediaflux_id = mediaflux_request.mediaflux_id	1✔
37
38	if mediaflux_id.to_i == 0	1✔
39	debug_output = "Error saving project #{project.id} to Mediaflux: #{mediaflux_request.response_error}. Debug output: #{mediaflux_request.debug_output}"	1✔
40	Rails.logger.error debug_output	1✔
41
42	# we do not want unsaved projects just hanging around
43	project.destroy!	1✔
44	Failure debug_output	1✔
45	else
46	ProvenanceEvent.generate_approval_events(project: project, user: current_user, debug_output: mediaflux_request.debug_output.to_s)	×
47	Success(mediaflux_id)	×
48	end
49	rescue => ex
NEW 50	Failure("Error saving project #{project.id} to Mediaflux: #{ex}")	×
51	end
52
53	def update_project_with_mediaflux_info(mediaflux_id:, project:)	1✔
54	project.mediaflux_id = mediaflux_id	×
55	project.metadata_model.status = Project::APPROVED_STATUS	×
56	project.save!	×
57	Success(project)	×
58	rescue => ex
59	# TODO: It was saved in mediaflux, so maybe a retry here? I don't want to destroy the project
60	Failure("Setting the mediaflux id the project(#{project.id}) : #{ex}")	×
61	end
62
63	def persist_users_in_mediaflux(project, current_user)	1✔
64	# Do nothing if there are no users to persist
65	return Success(project) if (project.metadata_model.ro_users + project.metadata_model.rw_users).empty?	×
66
67	# Add the data users to the project in Mediaflux
68	add_users_request = Mediaflux::ProjectUserAddRequest.new(session_token: current_user.mediaflux_session, project: project)	×
69	add_users_request.resolve	×
70
71	if add_users_request.error?	×
72	# TODO: what should we do with the project in this case? It got all the way to mediaflux, but the users were not added
73	Failure("Error adding users to mediaflux project #{project.mediaflux_id} #{add_users_request.response_error}")	×
74	else
75	user_debug = add_users_request.debug_output.to_s	×
76	Rails.logger.debug { "Project #{project.id} users have been added to MediaFlux: #{user_debug}" }	×
77	Success project	×
78	end
79	rescue => ex
NEW 80	Failure("Exception adding users to mediaflux project #{project.mediaflux_id}: #{ex}")	×
81	end
82	end

pulibrary / tigerdata-app / 454bc7c2-3cd4-490f-b9b3-912d91b545c9

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous