4c391e0e-519a-40cb-8ad3-354445f4ce03

Committed 12 Aug 2025 08:47PM UTC coverage: 85.348% (-10.0%) from 95.335%

Build # 4c391e0e-519a-40cb-8ad3-354445f4ce03

Build Type

push

circleci

Committed by

web-flow

Commit Message

[#5143] Use access restriction note as Aeon ItemInfo1 if available (#5173)

With this commit, if a user visits a record with an access
restrictions note and presses the Reading Room Request
button, they will get to an Aeon form with the 'Restrictions'
field pre-filled with the restriction note.

If the record does not have an access restrictions note,
the field will be pre-filled with 'Reading Room Access Only',
as it has been previously.

Closes #5143

Run Details

5493 of 6436 relevant lines covered (85.35%)

251.82 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

85.0

/app/models/requests/holding_group.rb

# frozen_string_literal: true

# This class represents a group of physical holdings that
# are grouped together for display
class Requests::HoldingGroup
  include Comparable

  def initialize(group_name:, holdings:)
    @group_name = group_name
    @holdings = holdings
  end

  # rubocop:disable Lint/DuplicateBranch
  # :reek:DuplicateMethodCall
  def <=>(other)
    if firestone? && !other.firestone?
      -1 # Firestone should go first
    elsif !firestone? && other.firestone?
      1
    elsif off_site? && !other.off_site?
      1 # Off site locations should go last
    elsif !off_site? && other.off_site?
      -1
    else
      group_name <=> other.group_name
    end
  end
  # rubocop:enable Lint/DuplicateBranch

  def firestone?
    group_name.start_with? 'Firestone'
  end

  def off_site?
    group_name.start_with?('Annex', 'Forrestal') || group_name.include?('Remote Storage') || group_name.downcase.include?('(off-site)')
  end

  attr_reader :group_name, :holdings
end

1	# frozen_string_literal: true
2
3	# This class represents a group of physical holdings that
4	# are grouped together for display
5	class Requests::HoldingGroup	1✔
6	include Comparable	1✔
7
8	def initialize(group_name:, holdings:)	1✔
9	@group_name = group_name	40✔
10	@holdings = holdings	40✔
11	end
12
13	# rubocop:disable Lint/DuplicateBranch
14	# :reek:DuplicateMethodCall
15	def <=>(other)	1✔
16	if firestone? && !other.firestone?	9✔
17	-1 # Firestone should go first	×
18	elsif !firestone? && other.firestone?	9✔
19	1	×
20	elsif off_site? && !other.off_site?	9✔
21	1 # Off site locations should go last	×
22	elsif !off_site? && other.off_site?	9✔
23	-1	2✔
24	else
25	group_name <=> other.group_name	7✔
26	end
27	end
28	# rubocop:enable Lint/DuplicateBranch
29
30	def firestone?	1✔
31	group_name.start_with? 'Firestone'	27✔
32	end
33
34	def off_site?	1✔
35	group_name.start_with?('Annex', 'Forrestal') \|\| group_name.include?('Remote Storage') \|\| group_name.downcase.include?('(off-site)')	27✔
36	end
37
38	attr_reader :group_name, :holdings	1✔
39	end

pulibrary / orangelight / 4c391e0e-519a-40cb-8ad3-354445f4ce03

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous