4174731a-1fbc-41e9-98e7-dcf30b6a3cd3

Committed 03 Sep 2025 05:55PM UTC coverage: 87.885% (-1.2%) from 89.044%

Build # 4174731a-1fbc-41e9-98e7-dcf30b6a3cd3

Build Type

Pull #1810

circleci

Committed by

leefaisonr

Commit Message

adjust user views

Pull Request Pull Request #1810: allow users to see sponsored and managed projects

Run Details

2 of 2 new or added lines in 1 file covered. (100.0%)

19 existing lines in 5 files now uncovered.

2452 of 2790 relevant lines covered (87.89%)

328.97 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

98.77

/app/models/request.rb

# frozen_string_literal: true
class Request < ApplicationRecord
  DRAFT = "draft" # default state set by database
  SUBMITTED = "submitted" # Ready to be approved

  def valid_to_submit?
    errors.clear
    # run all validations and then check for errors otherwise ruby stops at the first error
    valid_title?
    valid_data_sponsor?
    valid_data_manager?
    valid_departments?
    valid_quota?
    valid_description?
    # Is parent folder really required?  For Skeletor let's skip it.
    # valid_parent_folder?
    valid_project_folder?
    # For Skeletor we are setting the requestor to the data sponsor
    # valid_requested_by?
    errors.count == 0
  end

  def valid_title?
    field_present?(project_title, :project_title)
  end

  def valid_data_sponsor?
    valid_uid?(data_sponsor, :data_sponsor)
  end

  def valid_data_manager?
    valid_uid?(data_manager, :data_manager)
  end

  def valid_departments?
    field_present?(departments, :departments)
  end

  def valid_description?
    field_present?(description, :description)
  end

  def valid_parent_folder?
    field_present?(parent_folder, :parent_folder)
  end

  def valid_project_folder?
    field_present?(project_folder, :project_folder)
  end

  def valid_quota?
    if ((quota == "500 GB") || (quota == "2 TB") || (quota == "10 TB") || (quota == "25 TB")) ||
       (custom_quota? && (storage_size.present? && (storage_size > 0)) && ((storage_unit == "GB") || (storage_unit == "TB")))
      true
    else
      errors.add(:quota, :invalid, message: "must be one of '500 GB', '2 TB', '10 TB', '25 TB', or 'custom'")
      false
    end
  end

  def custom_quota?
    quota == "custom"
  end

  def valid_requested_by?
    field_present?(requested_by, :requested_by)
  end

  def approve(approver)
    create_project_operation = ProjectCreate.new
    result = create_project_operation.call(request: self, approver: approver)
    if result.success?
      result.value!
    else
      self.error_message = { message: result.failure }
      save!
      raise ProjectCreate::ProjectCreateError, result.failure
    end
  end

  def approved_quota_size
    if approved_quota.present?
      if approved_quota == "custom"
        approved_storage_size.to_f
      else
        approved_quota.split.first.to_f
      end
    else
      requested_quota_size
    end
  end

  def requested_quota_size
    if custom_quota?
      storage_size.to_f
    else
      quota.split.first.to_f
    end
  end

  def approved_quota_unit
    if approved_quota.present?
      if approved_quota == "custom"
        approved_storage_unit
      else
        approved_quota.split.last
      end
    else
      requested_quota_unit
    end
  end

  def requested_quota_unit
    if custom_quota?
      storage_unit
    else
      quota.split.last
    end
  end

  def submitted?
    state == Request::SUBMITTED
  end

  private

    def field_present?(value, name)
      if value.present?
        true
      else
        errors.add(name, :invalid, message: "cannot be empty")
        false
      end
    end

    def valid_uid?(uid, field)
      if uid.blank?
        errors.add(field, :blank, message: "cannot be empty")
        false
      elsif User.where(uid: uid).count == 0
        errors.add(field, :invalid, message: "must be a valid user")
        false
      else
        true
      end
    end
end

1	# frozen_string_literal: true
2	class Request < ApplicationRecord	1✔
3	DRAFT = "draft" # default state set by database	1✔
4	SUBMITTED = "submitted" # Ready to be approved	1✔
5
6	def valid_to_submit?	1✔
7	errors.clear	38✔
8	# run all validations and then check for errors otherwise ruby stops at the first error
9	valid_title?	38✔
10	valid_data_sponsor?	38✔
11	valid_data_manager?	38✔
12	valid_departments?	38✔
13	valid_quota?	38✔
14	valid_description?	38✔
15	# Is parent folder really required? For Skeletor let's skip it.
16	# valid_parent_folder?
17	valid_project_folder?	38✔
18	# For Skeletor we are setting the requestor to the data sponsor
19	# valid_requested_by?
20	errors.count == 0	38✔
21	end
22
23	def valid_title?	1✔
24	field_present?(project_title, :project_title)	44✔
25	end
26
27	def valid_data_sponsor?	1✔
28	valid_uid?(data_sponsor, :data_sponsor)	41✔
29	end
30
31	def valid_data_manager?	1✔
32	valid_uid?(data_manager, :data_manager)	41✔
33	end
34
35	def valid_departments?	1✔
36	field_present?(departments, :departments)	40✔
37	end
38
39	def valid_description?	1✔
40	field_present?(description, :description)	40✔
41	end
42
43	def valid_parent_folder?	1✔
44	field_present?(parent_folder, :parent_folder)	2✔
45	end
46
47	def valid_project_folder?	1✔
48	field_present?(project_folder, :project_folder)	40✔
49	end
50
51	def valid_quota?	1✔
52	if ((quota == "500 GB") \|\| (quota == "2 TB") \|\| (quota == "10 TB") \|\| (quota == "25 TB")) \|\|	46✔
53	(custom_quota? && (storage_size.present? && (storage_size > 0)) && ((storage_unit == "GB") \|\| (storage_unit == "TB")))	4✔
54	true	43✔
55	else
56	errors.add(:quota, :invalid, message: "must be one of '500 GB', '2 TB', '10 TB', '25 TB', or 'custom'")	3✔
57	false	3✔
58	end
59	end
60
61	def custom_quota?	1✔
62	quota == "custom"	86✔
63	end
64
65	def valid_requested_by?	1✔
66	field_present?(requested_by, :requested_by)	2✔
67	end
68
69	def approve(approver)	1✔
70	create_project_operation = ProjectCreate.new	6✔
71	result = create_project_operation.call(request: self, approver: approver)	6✔
72	if result.success?	6✔
73	result.value!	5✔
74	else
75	self.error_message = { message: result.failure }	1✔
76	save!	1✔
77	raise ProjectCreate::ProjectCreateError, result.failure	1✔
78	end
79	end
80
81	def approved_quota_size	1✔
82	if approved_quota.present?	15✔
83	if approved_quota == "custom"	1✔
UNCOV 84	approved_storage_size.to_f	×
85	else
86	approved_quota.split.first.to_f	1✔
87	end
88	else
89	requested_quota_size	14✔
90	end
91	end
92
93	def requested_quota_size	1✔
94	if custom_quota?	41✔
95	storage_size.to_f	5✔
96	else
97	quota.split.first.to_f	36✔
98	end
99	end
100
101	def approved_quota_unit	1✔
102	if approved_quota.present?	18✔
103	if approved_quota == "custom"	3✔
104	approved_storage_unit	2✔
105	else
106	approved_quota.split.last	1✔
107	end
108	else
109	requested_quota_unit	15✔
110	end
111	end
112
113	def requested_quota_unit	1✔
114	if custom_quota?	41✔
115	storage_unit	5✔
116	else
117	quota.split.last	36✔
118	end
119	end
120
121	def submitted?	1✔
122	state == Request::SUBMITTED	22✔
123	end
124
125	private	1✔
126
127	def field_present?(value, name)	1✔
128	if value.present?	168✔
129	true	90✔
130	else
131	errors.add(name, :invalid, message: "cannot be empty")	78✔
132	false	78✔
133	end
134	end
135
136	def valid_uid?(uid, field)	1✔
137	if uid.blank?	82✔
138	errors.add(field, :blank, message: "cannot be empty")	33✔
139	false	33✔
140	elsif User.where(uid: uid).count == 0	49✔
141	errors.add(field, :invalid, message: "must be a valid user")	2✔
142	false	2✔
143	else
144	true	47✔
145	end
146	end
147	end

pulibrary / tigerdata-app / 4174731a-1fbc-41e9-98e7-dcf30b6a3cd3

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous