bb6442c4-eb43-430c-9683-6ffb5848882a

Committed 21 Oct 2025 08:43PM UTC coverage: 87.325% (+0.4%) from 86.877%

Build # bb6442c4-eb43-430c-9683-6ffb5848882a

Build Type

Pull #2066

circleci

Committed by

bess

Commit Message

Stop mediaflux when we stop everything else

Pull Request Pull Request #2066: Stop mediaflux when we stop everything else

Run Details

2625 of 3006 relevant lines covered (87.33%)

307.22 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

93.75

/app/operations/project_create.rb

# frozen_string_literal: true
class ProjectCreate < Dry::Operation
  class ProjectCreateError < StandardError; end

  def call(request:, approver:)
    project = step create_project_from_request(request)
    mediaflux_id = step persist_in_mediaflux(project, approver)
    step update_project_with_mediaflux_info(mediaflux_id:, project:)
    step persist_users_in_mediaflux(project, approver)
    step activate_project(project, approver)
  end

  private
    def create_project_from_request(request)
      # Create the project in the Rails database
      project_metadata_json = RequestProjectMetadata.convert(request)
      # Link the request to the project
      project = Project.create!({ metadata_json: project_metadata_json })
      request.project_id = project.id
      project.draft_doi
      project.save!

      # Return Success(attrs) or Failure(error)
      Success project
    rescue => ex
      Failure("Error creating the project: #{ex}")
    end

    def persist_in_mediaflux(project, current_user)
      # Create the project in Mediaflux
      mediaflux_request = Mediaflux::ProjectCreateServiceRequest.new(session_token: current_user.mediaflux_session, project: project)
      mediaflux_request.resolve

      mediaflux_id = mediaflux_request.mediaflux_id

      if mediaflux_id.to_i == 0
        debug_output = "Error saving project #{project.id} to Mediaflux: #{mediaflux_request.response_error}. Debug output: #{mediaflux_request.debug_output}"
        Rails.logger.error debug_output
        Failure debug_output
      else
        ProvenanceEvent.generate_approval_events(project: project, user: current_user, debug_output: mediaflux_request.debug_output.to_s)
        Success(mediaflux_id)
      end
    # TODO:  What kind of error are we expecting here?  This will capture the session errors, but maybe we should not be doing this.
    #        I could not figure out a way in tests to hit this error...
    rescue => ex
      Failure("Error saving project #{project.id} to Mediaflux: #{ex}")
    end

    def update_project_with_mediaflux_info(mediaflux_id:, project:)
      project.mediaflux_id = mediaflux_id
      project.metadata_model.status = Project::APPROVED_STATUS
      project.save!
      Success(project)
    rescue => ex
      # TODO: It was saved in mediaflux, so maybe a retry here?  I don't want to destroy the project
      Failure("Setting the mediaflux id the project(#{project.id}) : #{ex}")
    end

    def persist_users_in_mediaflux(project, current_user)
      # Do nothing if there are no users to persist
      return Success(project) if (project.metadata_model.ro_users + project.metadata_model.rw_users).empty?

      # Add the data users to the project in Mediaflux
      add_users_request = Mediaflux::ProjectUserAddRequest.new(session_token: current_user.mediaflux_session, project: project)
      add_users_request.resolve

      if add_users_request.error?
        # TODO: what should we do with the project in this case?  It got all the way to mediaflux, but the users were not added
        Failure("Error adding users to mediaflux project #{project.mediaflux_id} #{add_users_request.response_error}")
      else
        user_debug = add_users_request.debug_output.to_s
        Rails.logger.debug { "Project #{project.id} users have been added to MediaFlux: #{user_debug}" }
        Success project
      end
    # TODO:  What kind of error are we expecting here?  This will capture the session errors, but maybe we should not be doing this.
    #        I could not figure out a way in tests to hit this error...
    rescue => ex
      Failure("Exception adding users to mediaflux project #{project.mediaflux_id}: #{ex}")
    end

    def activate_project(project, approver)
      project.activate(current_user: approver)
      Success(project)
    rescue => ex
      Failure("Error activate project #{project.id}: #{ex}")
    end
end

1	# frozen_string_literal: true
2	class ProjectCreate < Dry::Operation	4✔
3	class ProjectCreateError < StandardError; end	4✔
4
5	def call(request:, approver:)	4✔
6	project = step create_project_from_request(request)	102✔
7	mediaflux_id = step persist_in_mediaflux(project, approver)	100✔
8	step update_project_with_mediaflux_info(mediaflux_id:, project:)	97✔
9	step persist_users_in_mediaflux(project, approver)	96✔
10	step activate_project(project, approver)	96✔
11	end
12
13	private	4✔
14	def create_project_from_request(request)	4✔
15	# Create the project in the Rails database
16	project_metadata_json = RequestProjectMetadata.convert(request)	102✔
17	# Link the request to the project
18	project = Project.create!({ metadata_json: project_metadata_json })	102✔
19	request.project_id = project.id	101✔
20	project.draft_doi	101✔
21	project.save!	100✔
22
23	# Return Success(attrs) or Failure(error)
24	Success project	100✔
25	rescue => ex
26	Failure("Error creating the project: #{ex}")	2✔
27	end
28
29	def persist_in_mediaflux(project, current_user)	4✔
30	# Create the project in Mediaflux
31	mediaflux_request = Mediaflux::ProjectCreateServiceRequest.new(session_token: current_user.mediaflux_session, project: project)	100✔
32	mediaflux_request.resolve	100✔
33
34	mediaflux_id = mediaflux_request.mediaflux_id	100✔
35
36	if mediaflux_id.to_i == 0	100✔
37	debug_output = "Error saving project #{project.id} to Mediaflux: #{mediaflux_request.response_error}. Debug output: #{mediaflux_request.debug_output}"	3✔
38	Rails.logger.error debug_output	3✔
39	Failure debug_output	3✔
40	else
41	ProvenanceEvent.generate_approval_events(project: project, user: current_user, debug_output: mediaflux_request.debug_output.to_s)	97✔
42	Success(mediaflux_id)	97✔
43	end
44	# TODO: What kind of error are we expecting here? This will capture the session errors, but maybe we should not be doing this.
45	# I could not figure out a way in tests to hit this error...
46	rescue => ex
47	Failure("Error saving project #{project.id} to Mediaflux: #{ex}")	×
48	end
49
50	def update_project_with_mediaflux_info(mediaflux_id:, project:)	4✔
51	project.mediaflux_id = mediaflux_id	97✔
52	project.metadata_model.status = Project::APPROVED_STATUS	96✔
53	project.save!	96✔
54	Success(project)	96✔
55	rescue => ex
56	# TODO: It was saved in mediaflux, so maybe a retry here? I don't want to destroy the project
57	Failure("Setting the mediaflux id the project(#{project.id}) : #{ex}")	1✔
58	end
59
60	def persist_users_in_mediaflux(project, current_user)	4✔
61	# Do nothing if there are no users to persist
62	return Success(project) if (project.metadata_model.ro_users + project.metadata_model.rw_users).empty?	96✔
63
64	# Add the data users to the project in Mediaflux
65	add_users_request = Mediaflux::ProjectUserAddRequest.new(session_token: current_user.mediaflux_session, project: project)	3✔
66	add_users_request.resolve	3✔
67
68	if add_users_request.error?	3✔
69	# TODO: what should we do with the project in this case? It got all the way to mediaflux, but the users were not added
70	Failure("Error adding users to mediaflux project #{project.mediaflux_id} #{add_users_request.response_error}")	×
71	else
72	user_debug = add_users_request.debug_output.to_s	3✔
73	Rails.logger.debug { "Project #{project.id} users have been added to MediaFlux: #{user_debug}" }	6✔
74	Success project	3✔
75	end
76	# TODO: What kind of error are we expecting here? This will capture the session errors, but maybe we should not be doing this.
77	# I could not figure out a way in tests to hit this error...
78	rescue => ex
79	Failure("Exception adding users to mediaflux project #{project.mediaflux_id}: #{ex}")	×
80	end
81
82	def activate_project(project, approver)	4✔
83	project.activate(current_user: approver)	96✔
84	Success(project)	95✔
85	rescue => ex
86	Failure("Error activate project #{project.id}: #{ex}")	1✔
87	end
88	end

pulibrary / tigerdata-app / bb6442c4-eb43-430c-9683-6ffb5848882a

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous