529f7cba-0651-41c2-9045-ff17f0a5a349

Committed 21 Oct 2025 09:43PM UTC coverage: 86.877%. Remained the same

Build # 529f7cba-0651-41c2-9045-ff17f0a5a349

Build Type

Pull #2070

circleci

Committed by

bess

Commit Message

Remove tests for special production behavior

Pull Request Pull Request #2070: Remove tests for special behavior in production

Run Details

2615 of 3010 relevant lines covered (86.88%)

340.18 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

89.09

/app/models/request.rb

# frozen_string_literal: true
# rubocop:disable Metrics/ClassLength
class Request < ApplicationRecord
  DRAFT = "draft" # default state set by database
  SUBMITTED = "submitted" # Ready to be approved

  def valid_to_submit?
    errors.clear
    # run all validations and then check for errors otherwise ruby stops at the first error
    valid_title?
    valid_data_sponsor?
    valid_data_manager?
    valid_departments?
    valid_quota?
    valid_project_purpose?
    valid_description?
    # Is parent folder really required?  For Skeletor let's skip it.
    # valid_parent_folder?
    valid_project_folder?
    # For Skeletor we are setting the requestor to the data sponsor
    # valid_requested_by?
    errors.count == 0
  end

  def valid_title?
    check_errors? do
      field_present?(project_title, :project_title)
      valid_length(project_title, 200, :project_title)
      no_quotes(project_title, :project_title)
    end
  end

  def valid_data_sponsor?
    check_errors? { validate_uid(data_sponsor, :data_sponsor) }
  end

  def valid_data_manager?
    check_errors? { validate_uid(data_manager, :data_manager) }
  end

  def valid_departments?
    check_errors? { field_present?(departments, :departments) }
  end

  def valid_project_purpose?
    check_errors? { project_purpose_present?(project_purpose, :project_purpose) }
  end

  def valid_description?
    check_errors? do
      field_present?(description, :description)
      valid_length(description, 1000, :description)
      no_quotes(description, :description)
    end
  end

  def valid_parent_folder?
    check_errors? do
      field_present?(parent_folder, :parent_folder)
      no_quotes(project_title, :parent_folder)
    end
  end

  def valid_project_folder?
    check_errors? do
      field_present?(project_folder, :project_folder)
      no_quotes(project_folder, :project_folder)
    end
  end

  def valid_quota?
    if ((quota == "500 GB") || (quota == "2 TB") || (quota == "10 TB") || (quota == "25 TB")) ||
       (custom_quota? && (storage_size.present? && (storage_size > 0)) && ((storage_unit == "GB") || (storage_unit == "TB")))
      true
    else
      errors.add(:quota, :invalid, message: "must be one of '500 GB', '2 TB', '10 TB', '25 TB', or 'custom'")
      false
    end
  end

  def custom_quota?
    quota == "custom"
  end

  def valid_requested_by?
    check_errors? { field_present?(requested_by, :requested_by) }
  end

  def approve(approver)
    create_project_operation = ProjectCreate.new
    result = create_project_operation.call(request: self, approver: approver)
    if result.success?
      result.value!
    else
      self.error_message = { message: result.failure }
      save!
      cleanup_incomplete_project
      raise ProjectCreate::ProjectCreateError, result.failure
    end
  end

  def approved_quota_size
    if approved_quota.present?
      if approved_quota == "custom"
        approved_storage_size.to_f
      else
        approved_quota.split.first.to_f
      end
    else
      requested_quota_size
    end
  end

  def requested_quota_size
    if custom_quota?
      storage_size.to_f
    else
      quota.split.first.to_f
    end
  end

  def approved_quota_unit
    if approved_quota.present?
      if approved_quota == "custom"
        approved_storage_unit
      else
        approved_quota.split.last
      end
    else
      requested_quota_unit
    end
  end

  def requested_quota_unit
    if custom_quota?
      storage_unit
    else
      quota.split.last
    end
  end

  def submitted?
    state == Request::SUBMITTED
  end

  private

    def check_errors?
      original_error_count = errors.count
      yield
      original_error_count == errors.count
    end

    def field_present?(value, name)
      if value.blank?
        errors.add(name, :invalid, message: "cannot be empty")
      end
    end

    def validate_uid(uid, field)
      if uid.blank?
        errors.add(field, :blank, message: "cannot be empty")
      elsif User.where(uid: uid).count == 0
        errors.add(field, :invalid, message: "must be a valid user")
      end
    end

    def project_purpose_present?(project_purpose, field)
      if project_purpose.blank?
        errors.add(field, :blank, message: "select a project purpose")
      end
    end

    def valid_length(value, length, field)
      return if value.blank?
      if value.length > length
        errors.add(field, :invalid, message: "cannot exceed #{length} characters")
      end
    end

    def no_quotes(value, field)
      return if value.blank?
      if value.include?('"')
        errors.add(field, :invalid, message: "cannot include quotes")
      end
    end

    # If a request fails to be a approved we make sure there were not orphan
    # project records left in our Rails database that do not have a matching
    # project in Mediaflux (i.e. collection asset).
    def cleanup_incomplete_project
      project = Project.find_by_id(project_id)
      if project && project.mediaflux_id.nil?
        Rails.logger.warn("Deleting project #{project.id} because the approval for request #{id} failed and it was not created in Mediaflux.")
        project.destroy!
      end
    end
end
# rubocop:enable Metrics/ClassLength

1	# frozen_string_literal: true
2	# rubocop:disable Metrics/ClassLength
3	class Request < ApplicationRecord	4✔
4	DRAFT = "draft" # default state set by database	4✔
5	SUBMITTED = "submitted" # Ready to be approved	4✔
6
7	def valid_to_submit?	4✔
8	errors.clear	49✔
9	# run all validations and then check for errors otherwise ruby stops at the first error
10	valid_title?	49✔
11	valid_data_sponsor?	49✔
12	valid_data_manager?	49✔
13	valid_departments?	49✔
14	valid_quota?	49✔
15	valid_project_purpose?	49✔
16	valid_description?	49✔
17	# Is parent folder really required? For Skeletor let's skip it.
18	# valid_parent_folder?
19	valid_project_folder?	49✔
20	# For Skeletor we are setting the requestor to the data sponsor
21	# valid_requested_by?
22	errors.count == 0	49✔
23	end
24
25	def valid_title?	4✔
26	check_errors? do	49✔
27	field_present?(project_title, :project_title)	49✔
28	valid_length(project_title, 200, :project_title)	49✔
29	no_quotes(project_title, :project_title)	49✔
30	end
31	end
32
33	def valid_data_sponsor?	4✔
34	check_errors? { validate_uid(data_sponsor, :data_sponsor) }	98✔
35	end
36
37	def valid_data_manager?	4✔
38	check_errors? { validate_uid(data_manager, :data_manager) }	98✔
39	end
40
41	def valid_departments?	4✔
42	check_errors? { field_present?(departments, :departments) }	98✔
43	end
44
45	def valid_project_purpose?	4✔
46	check_errors? { project_purpose_present?(project_purpose, :project_purpose) }	98✔
47	end
48
49	def valid_description?	4✔
50	check_errors? do	49✔
51	field_present?(description, :description)	49✔
52	valid_length(description, 1000, :description)	49✔
53	no_quotes(description, :description)	49✔
54	end
55	end
56
57	def valid_parent_folder?	4✔
58	check_errors? do	×
59	field_present?(parent_folder, :parent_folder)	×
60	no_quotes(project_title, :parent_folder)	×
61	end
62	end
63
64	def valid_project_folder?	4✔
65	check_errors? do	49✔
66	field_present?(project_folder, :project_folder)	49✔
67	no_quotes(project_folder, :project_folder)	49✔
68	end
69	end
70
71	def valid_quota?	4✔
72	if ((quota == "500 GB") \|\| (quota == "2 TB") \|\| (quota == "10 TB") \|\| (quota == "25 TB")) \|\|	49✔
73	(custom_quota? && (storage_size.present? && (storage_size > 0)) && ((storage_unit == "GB") \|\| (storage_unit == "TB")))	1✔
74	true	49✔
75	else
76	errors.add(:quota, :invalid, message: "must be one of '500 GB', '2 TB', '10 TB', '25 TB', or 'custom'")	×
77	false	×
78	end
79	end
80
81	def custom_quota?	4✔
82	quota == "custom"	287✔
83	end
84
85	def valid_requested_by?	4✔
86	check_errors? { field_present?(requested_by, :requested_by) }	×
87	end
88
89	def approve(approver)	4✔
90	create_project_operation = ProjectCreate.new	106✔
91	result = create_project_operation.call(request: self, approver: approver)	106✔
92	if result.success?	106✔
93	result.value!	105✔
94	else
95	self.error_message = { message: result.failure }	1✔
96	save!	1✔
97	cleanup_incomplete_project	1✔
98	raise ProjectCreate::ProjectCreateError, result.failure	1✔
99	end
100	end
101
102	def approved_quota_size	4✔
103	if approved_quota.present?	115✔
104	if approved_quota == "custom"	98✔
105	approved_storage_size.to_f	98✔
106	else
107	approved_quota.split.first.to_f	×
108	end
109	else
110	requested_quota_size	17✔
111	end
112	end
113
114	def requested_quota_size	4✔
115	if custom_quota?	143✔
116	storage_size.to_f	101✔
117	else
118	quota.split.first.to_f	42✔
119	end
120	end
121
122	def approved_quota_unit	4✔
123	if approved_quota.present?	115✔
124	if approved_quota == "custom"	98✔
125	approved_storage_unit	98✔
126	else
127	approved_quota.split.last	×
128	end
129	else
130	requested_quota_unit	17✔
131	end
132	end
133
134	def requested_quota_unit	4✔
135	if custom_quota?	143✔
136	storage_unit	101✔
137	else
138	quota.split.last	42✔
139	end
140	end
141
142	def submitted?	4✔
143	state == Request::SUBMITTED	68✔
144	end
145
146	private	4✔
147
148	def check_errors?	4✔
149	original_error_count = errors.count	343✔
150	yield	343✔
151	original_error_count == errors.count	343✔
152	end
153
154	def field_present?(value, name)	4✔
155	if value.blank?	196✔
156	errors.add(name, :invalid, message: "cannot be empty")	44✔
157	end
158	end
159
160	def validate_uid(uid, field)	4✔
161	if uid.blank?	98✔
162	errors.add(field, :blank, message: "cannot be empty")	24✔
163	elsif User.where(uid: uid).count == 0	74✔
164	errors.add(field, :invalid, message: "must be a valid user")	×
165	end
166	end
167
168	def project_purpose_present?(project_purpose, field)	4✔
169	if project_purpose.blank?	49✔
170	errors.add(field, :blank, message: "select a project purpose")	12✔
171	end
172	end
173
174	def valid_length(value, length, field)	4✔
175	return if value.blank?	98✔
176	if value.length > length	78✔
177	errors.add(field, :invalid, message: "cannot exceed #{length} characters")	4✔
178	end
179	end
180
181	def no_quotes(value, field)	4✔
182	return if value.blank?	147✔
183	if value.include?('"')	115✔
184	errors.add(field, :invalid, message: "cannot include quotes")	×
185	end
186	end
187
188	# If a request fails to be a approved we make sure there were not orphan
189	# project records left in our Rails database that do not have a matching
190	# project in Mediaflux (i.e. collection asset).
191	def cleanup_incomplete_project	4✔
192	project = Project.find_by_id(project_id)	1✔
193	if project && project.mediaflux_id.nil?	1✔
194	Rails.logger.warn("Deleting project #{project.id} because the approval for request #{id} failed and it was not created in Mediaflux.")	×
195	project.destroy!	×
196	end
197	end
198	end
199	# rubocop:enable Metrics/ClassLength

pulibrary / tigerdata-app / 529f7cba-0651-41c2-9045-ff17f0a5a349

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous