1f9ee909-20b2-467d-b493-b5be4964430d

Committed 22 Oct 2025 04:57PM UTC coverage: 91.212%. Remained the same

Build # 1f9ee909-20b2-467d-b493-b5be4964430d

Build Type

push

circleci

Committed by

web-flow

Commit Message

Fixing flaky tests (#2080)

10 times out of 10 one of these tests would fail for me locally.

Really we just have to look at the page for something new so that we are
sure the controller action has finished before we check for something
that is not waiting.

Run Details

2740 of 3004 relevant lines covered (91.21%)

755.12 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

100.0

/app/services/xml_element_builder.rb

# frozen_string_literal: true
class XmlElementBuilder < XmlNodeBuilder
  attr_reader :presenter, :name, :attributes, :content
  alias entry content
  delegate :blank?, to: :content

  # @return [Nokogiri::XML::Element] the XML element node
  def element
    @element ||= begin
                   created = @document.create_element(name)
                   @document.root = created
                   created
                 end
  end

  # @return [Nokogiri::XML::Element] the XML element node
  def build_attributes
    attributes.each do |key, attr_entry|
      value = attr_entry
      if attr_entry.is_a?(Hash) && attr_entry.key?(:object_method)
        allow_empty_attr = attr_entry.fetch(:allow_empty, true)

        message = attr_entry[:object_method]
        method_args = attr_entry[:args] || []
        method_args = @default_method_args + method_args
        value = presenter.send(message, *method_args)

        raise ArgumentError, "Value for #{key} cannot be nil" if value.nil? && !allow_empty_attr
      end

      element[key] = value unless value.nil?
    end

    element
  end

  # @return [String] the content for the XML element
  def build_content!
    allow_empty_content = entry.fetch(:allow_empty, true)

    message = entry[:object_method]
    method_args = entry[:args] || []
    method_args = @default_method_args + method_args
    @content = presenter.send(message, *method_args)

    raise ArgumentError, "Content for #{name} cannot be nil" if content.nil? && !allow_empty_content
    content
  end

  # rubocop:disable Metrics/AbcSize
  # rubocop:disable Metrics/CyclomaticComplexity
  # rubocop:disable Metrics/MethodLength
  # rubocop:disable Metrics/PerceivedComplexity
  #
  # @return [Nokogiri::XML::Element]
  def build
    if entry.is_a?(Hash) && entry.key?(:object_method)
      build_content!
    end

    built = build_attributes
    built.content = content

    built
  rescue ArgumentError => arg_error
    Rails.logger.warn("Error building XML project metadata: #{arg_error.message}")
    nil
  end
  # rubocop:enable Metrics/PerceivedComplexity
  # rubocop:enable Metrics/MethodLength
  # rubocop:enable Metrics/CyclomaticComplexity
  # rubocop:enable Metrics/AbcSize

  # @return [Nokogiri::XML::Element] the XML element node
  def node
    @node ||= build
  end

  def add_child(child)
    return if child.nil?

    # @see https://nokogiri.org/rdoc/Nokogiri/XML/Node.html#method-i-clone
    level = 1
    cloned = child.clone(level, document)
    node.add_child(cloned)

    cloned
  end

  # @param [ProjectXmlPresenter] presenter
  # @param [String] name
  # @param [Hash] attributes
  # @param [String] content
  # @param [Integer] index the index for the element (when there are multiple sibling nodes)
  # @param [Hash] options
  def initialize(presenter:, name:, attributes: {}, content: nil, index: nil, **options)
    super(**options)

    @presenter = presenter
    @name = name

    @attributes = attributes
    @content = content

    @index = index

    @default_method_args = []
    @default_method_args << @index unless @index.nil?
  end
end

1	# frozen_string_literal: true
2	class XmlElementBuilder < XmlNodeBuilder	5✔
3	attr_reader :presenter, :name, :attributes, :content	5✔
4	alias entry content	5✔
5	delegate :blank?, to: :content	5✔
6
7	# @return [Nokogiri::XML::Element] the XML element node
8	def element	5✔
9	@element \|\|= begin	9,362✔
10	created = @document.create_element(name)	3,166✔
11	@document.root = created	3,166✔
12	created	3,166✔
13	end
14	end
15
16	# @return [Nokogiri::XML::Element] the XML element node
17	def build_attributes	5✔
18	attributes.each do \|key, attr_entry\|	3,260✔
19	value = attr_entry	6,308✔
20	if attr_entry.is_a?(Hash) && attr_entry.key?(:object_method)	6,308✔
21	allow_empty_attr = attr_entry.fetch(:allow_empty, true)	1,094✔
22
23	message = attr_entry[:object_method]	1,094✔
24	method_args = attr_entry[:args] \|\| []	1,094✔
25	method_args = @default_method_args + method_args	1,094✔
26	value = presenter.send(message, *method_args)	1,094✔
27
28	raise ArgumentError, "Value for #{key} cannot be nil" if value.nil? && !allow_empty_attr	1,086✔
29	end
30
31	element[key] = value unless value.nil?	6,214✔
32	end
33
34	element	3,166✔
35	end
36
37	# @return [String] the content for the XML element
38	def build_content!	5✔
39	allow_empty_content = entry.fetch(:allow_empty, true)	1,994✔
40
41	message = entry[:object_method]	1,994✔
42	method_args = entry[:args] \|\| []	1,994✔
43	method_args = @default_method_args + method_args	1,994✔
44	@content = presenter.send(message, *method_args)	1,994✔
45
46	raise ArgumentError, "Content for #{name} cannot be nil" if content.nil? && !allow_empty_content	1,994✔
47	content	1,908✔
48	end
49
50	# rubocop:disable Metrics/AbcSize
51	# rubocop:disable Metrics/CyclomaticComplexity
52	# rubocop:disable Metrics/MethodLength
53	# rubocop:disable Metrics/PerceivedComplexity
54	#
55	# @return [Nokogiri::XML::Element]
56	def build	5✔
57	if entry.is_a?(Hash) && entry.key?(:object_method)	3,346✔
58	build_content!	1,994✔
59	end
60
61	built = build_attributes	3,260✔
62	built.content = content	3,166✔
63
64	built	3,166✔
65	rescue ArgumentError => arg_error
66	Rails.logger.warn("Error building XML project metadata: #{arg_error.message}")	180✔
67	nil	180✔
68	end
69	# rubocop:enable Metrics/PerceivedComplexity
70	# rubocop:enable Metrics/MethodLength
71	# rubocop:enable Metrics/CyclomaticComplexity
72	# rubocop:enable Metrics/AbcSize
73
74	# @return [Nokogiri::XML::Element] the XML element node
75	def node	5✔
76	@node \|\|= build	6,420✔
77	end
78
79	def add_child(child)	5✔
80	return if child.nil?	3,254✔
81
82	# @see https://nokogiri.org/rdoc/Nokogiri/XML/Node.html#method-i-clone
83	level = 1	3,074✔
84	cloned = child.clone(level, document)	3,074✔
85	node.add_child(cloned)	3,074✔
86
87	cloned	3,074✔
88	end
89
90	# @param [ProjectXmlPresenter] presenter
91	# @param [String] name
92	# @param [Hash] attributes
93	# @param [String] content
94	# @param [Integer] index the index for the element (when there are multiple sibling nodes)
95	# @param [Hash] options
96	def initialize(presenter:, name:, attributes: {}, content: nil, index: nil, **options)	5✔
97	super(**options)	3,346✔
98
99	@presenter = presenter	3,346✔
100	@name = name	3,346✔
101
102	@attributes = attributes	3,346✔
103	@content = content	3,346✔
104
105	@index = index	3,346✔
106
107	@default_method_args = []	3,346✔
108	@default_method_args << @index unless @index.nil?	3,346✔
109	end
110	end

pulibrary / tigerdata-app / 1f9ee909-20b2-467d-b493-b5be4964430d

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous