1066293a-cdf2-4cd3-84fa-dd37414d6e54

Committed 22 Oct 2025 08:18PM UTC coverage: 91.178%. Remained the same

Build # 1066293a-cdf2-4cd3-84fa-dd37414d6e54

Build Type

push

circleci

Committed by

web-flow

Commit Message

Fix for nil value in test (#2086)

Run Details

2739 of 3004 relevant lines covered (91.18%)

755.06 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

87.5

/app/controllers/requests_controller.rb

# frozen_string_literal: true
class RequestsController < ApplicationController
  before_action :set_breadcrumbs

  # GET /requests
  def index
    if current_user.eligible_sysadmin?
      add_breadcrumb("Project Requests - All")
      @draft_requests = Request.where(state: Request::DRAFT).map do |request|
        request.project_title = "no title set" if request.project_title.blank?
        request
      end
      @submitted_requests = Request.where(state: Request::SUBMITTED)
    else
      error_message = "You do not have access to this page."
      flash[:notice] = error_message
      redirect_to dashboard_path
    end
  end

  def show
    if current_user.developer || current_user.sysadmin || current_user.trainer
      @request_model = Request.find(params[:id])
      @request_presenter = RequestPresenter.new(@request_model)
      add_breadcrumb("Requests", requests_path)
      add_breadcrumb(@request_model.project_title, request_path(@request_model))
      render :show
    else
      error_message = "You do not have access to this page."
      flash[:notice] = error_message
      redirect_to dashboard_path
    end
  end

  # rubocop:disable Metrics/AbcSize
  # rubocop:disable Metrics/MethodLength
  # rubocop:disable Metrics/PerceivedComplexity
  # rubocop:disable Metrics/CyclomaticComplexity
  def approve
    if eligible_to_approve
      @request_model = Request.find(params[:id])
      if @request_model.valid_to_submit?
        project = @request_model.approve(current_user)
        @request_model.destroy!
        stub_message = "The request has been approved and this project was created in the TigerData web portal.  The request has been processed and deleted."
        TigerdataMailer.with(project_id: project.id, approver: current_user).project_creation.deliver_later
        redirect_to project_path(project.id), notice: stub_message
      else
        redirect_to new_project_review_and_submit_path(@request_model)
      end
    else
      error_message = "You do not have access to this page."
      flash[:notice] = error_message
      redirect_to dashboard_path
    end
  rescue StandardError => ex
    if ex.is_a?(Mediaflux::SessionExpired) || ex.cause.is_a?(Mediaflux::SessionExpired)
      raise
    elsif ex.is_a?(ProjectCreate::ProjectCreateError) && ex.message.include?("Session expired for token")
      raise Mediaflux::SessionExpired
    else
      Rails.logger.error "Error approving request #{params[:id]}. Details: #{ex.message}"
      Honeybadger.notify "Error approving request #{params[:id]}. Details: #{ex.message}"
      flash[:notice] = "Error approving request #{params[:id]}"
      redirect_to request_path(@request_model)
    end
  end
  # rubocop:enable Metrics/MethodLength
  # rubocop:enable Metrics/AbcSize
  # rubocop:enable Metrics/PerceivedComplexity
  # rubocop:enable Metrics/CyclomaticComplexity

  private

    def set_breadcrumbs
      add_breadcrumb("Dashboard", dashboard_path)
    end

    def eligible_to_approve
      current_user.sysadmin || (current_user.developer && !Rails.env.production?)
    end
end

1	# frozen_string_literal: true
2	class RequestsController < ApplicationController	3✔
3	before_action :set_breadcrumbs	3✔
4
5	# GET /requests
6	def index	3✔
7	if current_user.eligible_sysadmin?	10✔
8	add_breadcrumb("Project Requests - All")	4✔
9	@draft_requests = Request.where(state: Request::DRAFT).map do \|request\|	4✔
10	request.project_title = "no title set" if request.project_title.blank?	×
11	request	×
12	end
13	@submitted_requests = Request.where(state: Request::SUBMITTED)	4✔
14	else
15	error_message = "You do not have access to this page."	6✔
16	flash[:notice] = error_message	6✔
17	redirect_to dashboard_path	6✔
18	end
19	end
20
21	def show	3✔
22	if current_user.developer \|\| current_user.sysadmin \|\| current_user.trainer	30✔
23	@request_model = Request.find(params[:id])	22✔
24	@request_presenter = RequestPresenter.new(@request_model)	22✔
25	add_breadcrumb("Requests", requests_path)	22✔
26	add_breadcrumb(@request_model.project_title, request_path(@request_model))	22✔
27	render :show	22✔
28	else
29	error_message = "You do not have access to this page."	8✔
30	flash[:notice] = error_message	8✔
31	redirect_to dashboard_path	8✔
32	end
33	end
34
35	# rubocop:disable Metrics/AbcSize
36	# rubocop:disable Metrics/MethodLength
37	# rubocop:disable Metrics/PerceivedComplexity
38	# rubocop:disable Metrics/CyclomaticComplexity
39	def approve	3✔
40	if eligible_to_approve	36✔
41	@request_model = Request.find(params[:id])	26✔
42	if @request_model.valid_to_submit?	26✔
43	project = @request_model.approve(current_user)	20✔
44	@request_model.destroy!	16✔
45	stub_message = "The request has been approved and this project was created in the TigerData web portal. The request has been processed and deleted."	16✔
46	TigerdataMailer.with(project_id: project.id, approver: current_user).project_creation.deliver_later	16✔
47	redirect_to project_path(project.id), notice: stub_message	16✔
48	else
49	redirect_to new_project_review_and_submit_path(@request_model)	6✔
50	end
51	else
52	error_message = "You do not have access to this page."	10✔
53	flash[:notice] = error_message	10✔
54	redirect_to dashboard_path	10✔
55	end
56	rescue StandardError => ex
57	if ex.is_a?(Mediaflux::SessionExpired) \|\| ex.cause.is_a?(Mediaflux::SessionExpired)	4✔
58	raise	2✔
59	elsif ex.is_a?(ProjectCreate::ProjectCreateError) && ex.message.include?("Session expired for token")	2✔
60	raise Mediaflux::SessionExpired	2✔
61	else
62	Rails.logger.error "Error approving request #{params[:id]}. Details: #{ex.message}"	×
63	Honeybadger.notify "Error approving request #{params[:id]}. Details: #{ex.message}"	×
64	flash[:notice] = "Error approving request #{params[:id]}"	×
65	redirect_to request_path(@request_model)	×
66	end
67	end
68	# rubocop:enable Metrics/MethodLength
69	# rubocop:enable Metrics/AbcSize
70	# rubocop:enable Metrics/PerceivedComplexity
71	# rubocop:enable Metrics/CyclomaticComplexity
72
73	private	3✔
74
75	def set_breadcrumbs	3✔
76	add_breadcrumb("Dashboard", dashboard_path)	76✔
77	end
78
79	def eligible_to_approve	3✔
80	current_user.sysadmin \|\| (current_user.developer && !Rails.env.production?)	36✔
81	end
82	end

pulibrary / tigerdata-app / 1066293a-cdf2-4cd3-84fa-dd37414d6e54

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous