1066293a-cdf2-4cd3-84fa-dd37414d6e54

Committed 22 Oct 2025 08:18PM UTC coverage: 91.178%. Remained the same

Build # 1066293a-cdf2-4cd3-84fa-dd37414d6e54

Build Type

push

circleci

Committed by

web-flow

Commit Message

Fix for nil value in test (#2086)

Run Details

2739 of 3004 relevant lines covered (91.18%)

755.06 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

100.0

/app/services/princeton_users.rb

# frozen_string_literal: true
class PrincetonUsers
  CHARS_AND_NUMS =  ('a'..'z').to_a + (0..9).to_a + ['-']
  RDSS_DEVELOPERS = %w[bs3097 jrg5 cac9 hc8719 rl3667 kl37 pp9425 jh6441].freeze

  class << self


    # Returns a list of Users that match the given query
    def user_list_query(query)
      tokens = query.downcase.strip.split(/[^a-zA-Z\d]/).compact_blank
      return [] if tokens.count == 0

      user_query = tokens.inject(User.all) do |partial_query, token|
                     search_token = '%'+User.sanitize_sql_like(token)+'%'
                     partial_query.where("(LOWER(display_name) like ?) OR (LOWER(uid) like ?)", search_token, search_token)
                   end.order(:display_name)
      user_query.map{|user| { uid: user.uid, name: user.display_name, display_name: user.display_name_safe } }
    end

    def load_rdss_developers
      RDSS_DEVELOPERS.each do |netid|
        create_user_from_ldap_by_uid(netid)
        rescue TigerData::LdapError
        raise TigerData::LdapError, "Unable to create user from LDAP. Are you connected to VPN?"
      end
    end

    # Creates users from LDAP data, starting with the given uid prefix.
    def create_users_from_ldap(current_uid_start: "", ldap_connection: default_ldap_connection)
      CHARS_AND_NUMS.each do |char|
        filter =(~ Net::LDAP::Filter.eq( "pustatus", "guest" )) & Net::LDAP::Filter.eq("uid", "#{current_uid_start}#{char}*")
        people = ldap_connection.search(filter:, attributes: [:pudisplayname, :givenname, :sn, :uid, :edupersonprincipalname]);
        if ldap_connection.get_operation_result.message == "Success"
          people.each{|person| user_from_ldap(person)}
        else
          create_users_from_ldap(current_uid_start: "#{current_uid_start}#{char}", ldap_connection:)
        end
      end
    end

    def create_user_from_ldap_by_uid(uid, ldap_connection: default_ldap_connection)
      filter = Net::LDAP::Filter.eq('uid', uid)
      person = ldap_connection.search(filter:, attributes: [:pudisplayname, :givenname, :sn, :uid, :edupersonprincipalname]);
      raise TigerData::LdapError, "More than one user matches supplied uid: #{uid}" if person.length > 1
      raise TigerData::LdapError, "No user with uid #{uid} found" if person.empty?
      user_from_ldap(person.first)
    end

  # Creates or updates a User from an LDAP entry.
  # @param ldap_person [Net::LDAP::Entry] an LDAP entry representing a person
  # @return [User, nil] the created or updated User, or nil if the LDAP entry is missing a edupersonprincipalname
    def user_from_ldap(ldap_person)
      return if check_for_malformed_ldap_entries(ldap_person)
      uid = ldap_person[:uid].first.downcase
      current_entries = User.where(uid:)
      if current_entries.empty?
        User.create(uid: , display_name: ldap_person[:pudisplayname].first,
                    family_name: ldap_person[:sn].first, given_name: ldap_person[:givenname].first,
                    email: ldap_person[:edupersonprincipalname].first, provider: "cas")
      else
        user = current_entries.first
        if user.display_name.blank?
          user.display_name = ldap_person[:pudisplayname].first
          user.family_name = ldap_person[:sn].first
          user.given_name = ldap_person[:givenname].first
          user.provider = "cas"
          user.save
        end
        user
      end
    end

    # If any required LDAP fields are missing, return true
    # @param ldap_person [Net::LDAP::Entry] an LDAP entry representing a person
    # @return [Boolean] true if the LDAP entry is missing required fields, false otherwise
    def check_for_malformed_ldap_entries(ldap_person)
      uid_blank = ldap_person[:uid].blank?
      edupersonprincipalname_blank = ldap_person[:edupersonprincipalname].blank?
      malformed = uid_blank || edupersonprincipalname_blank
      malformed
    end

    def default_ldap_connection
      @default_ldap_connection ||= Net::LDAP.new host: "ldap.princeton.edu", base: "o=Princeton University,c=US", port: 636,
                                                  encryption: {
                                                    method: :simple_tls,
                                                    tls_options: OpenSSL::SSL::SSLContext::DEFAULT_PARAMS
                                                  }
    end
  end
end

1	# frozen_string_literal: true
2	class PrincetonUsers	3✔
3	CHARS_AND_NUMS = ('a'..'z').to_a + (0..9).to_a + ['-']	3✔
4	RDSS_DEVELOPERS = %w[bs3097 jrg5 cac9 hc8719 rl3667 kl37 pp9425 jh6441].freeze	3✔
5
6	class << self	3✔
7
8
9	# Returns a list of Users that match the given query
10	def user_list_query(query)	3✔
11	tokens = query.downcase.strip.split(/[^a-zA-Z\d]/).compact_blank	55✔
12	return [] if tokens.count == 0	55✔
13
14	user_query = tokens.inject(User.all) do \|partial_query, token\|	53✔
15	search_token = '%'+User.sanitize_sql_like(token)+'%'	85✔
16	partial_query.where("(LOWER(display_name) like ?) OR (LOWER(uid) like ?)", search_token, search_token)	85✔
17	end.order(:display_name)
18	user_query.map{\|user\| { uid: user.uid, name: user.display_name, display_name: user.display_name_safe } }	108✔
19	end
20
21	def load_rdss_developers	3✔
22	RDSS_DEVELOPERS.each do \|netid\|	4✔
23	create_user_from_ldap_by_uid(netid)	18✔
24	rescue TigerData::LdapError
25	raise TigerData::LdapError, "Unable to create user from LDAP. Are you connected to VPN?"	2✔
26	end
27	end
28
29	# Creates users from LDAP data, starting with the given uid prefix.
30	def create_users_from_ldap(current_uid_start: "", ldap_connection: default_ldap_connection)	3✔
31	CHARS_AND_NUMS.each do \|char\|	10✔
32	filter =(~ Net::LDAP::Filter.eq( "pustatus", "guest" )) & Net::LDAP::Filter.eq("uid", "#{current_uid_start}#{char}*")	370✔
33	people = ldap_connection.search(filter:, attributes: [:pudisplayname, :givenname, :sn, :uid, :edupersonprincipalname]);	370✔
34	if ldap_connection.get_operation_result.message == "Success"	370✔
35	people.each{\|person\| user_from_ldap(person)}	376✔
36	else
37	create_users_from_ldap(current_uid_start: "#{current_uid_start}#{char}", ldap_connection:)	2✔
38	end
39	end
40	end
41
42	def create_user_from_ldap_by_uid(uid, ldap_connection: default_ldap_connection)	3✔
43	filter = Net::LDAP::Filter.eq('uid', uid)	16✔
44	person = ldap_connection.search(filter:, attributes: [:pudisplayname, :givenname, :sn, :uid, :edupersonprincipalname]);	16✔
45	raise TigerData::LdapError, "More than one user matches supplied uid: #{uid}" if person.length > 1	16✔
46	raise TigerData::LdapError, "No user with uid #{uid} found" if person.empty?	16✔
47	user_from_ldap(person.first)	16✔
48	end
49
50	# Creates or updates a User from an LDAP entry.
51	# @param ldap_person [Net::LDAP::Entry] an LDAP entry representing a person
52	# @return [User, nil] the created or updated User, or nil if the LDAP entry is missing a edupersonprincipalname
53	def user_from_ldap(ldap_person)	3✔
54	return if check_for_malformed_ldap_entries(ldap_person)	32✔
55	uid = ldap_person[:uid].first.downcase	26✔
56	current_entries = User.where(uid:)	26✔
57	if current_entries.empty?	26✔
58	User.create(uid: , display_name: ldap_person[:pudisplayname].first,	24✔
59	family_name: ldap_person[:sn].first, given_name: ldap_person[:givenname].first,
60	email: ldap_person[:edupersonprincipalname].first, provider: "cas")
61	else
62	user = current_entries.first	2✔
63	if user.display_name.blank?	2✔
64	user.display_name = ldap_person[:pudisplayname].first	2✔
65	user.family_name = ldap_person[:sn].first	2✔
66	user.given_name = ldap_person[:givenname].first	2✔
67	user.provider = "cas"	2✔
68	user.save	2✔
69	end
70	user	2✔
71	end
72	end
73
74	# If any required LDAP fields are missing, return true
75	# @param ldap_person [Net::LDAP::Entry] an LDAP entry representing a person
76	# @return [Boolean] true if the LDAP entry is missing required fields, false otherwise
77	def check_for_malformed_ldap_entries(ldap_person)	3✔
78	uid_blank = ldap_person[:uid].blank?	34✔
79	edupersonprincipalname_blank = ldap_person[:edupersonprincipalname].blank?	34✔
80	malformed = uid_blank \|\| edupersonprincipalname_blank	34✔
81	malformed	34✔
82	end
83
84	def default_ldap_connection	3✔
85	@default_ldap_connection \|\|= Net::LDAP.new host: "ldap.princeton.edu", base: "o=Princeton University,c=US", port: 636,	18✔
86	encryption: {
87	method: :simple_tls,
88	tls_options: OpenSSL::SSL::SSLContext::DEFAULT_PARAMS
89	}
90	end
91	end
92	end

pulibrary / tigerdata-app / 1066293a-cdf2-4cd3-84fa-dd37414d6e54

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous