07f4d952-7d18-4551-a848-48bb16200c76

Committed 24 Oct 2025 03:07PM UTC coverage: 88.171% (-3.0%) from 91.202%

Build # 07f4d952-7d18-4551-a848-48bb16200c76

Build Type

Pull #2096

circleci

Committed by

carolyncole

Commit Message

Adding more details to the request index page

Pull Request Pull Request #2096: Adding more details to the request index page

Run Details

2 of 6 new or added lines in 1 file covered. (33.33%)

651 existing lines in 39 files now uncovered.

2661 of 3018 relevant lines covered (88.17%)

285.33 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

100.0

/app/models/request.rb

# frozen_string_literal: true
# rubocop:disable Metrics/ClassLength
class Request < ApplicationRecord
  DRAFT = "draft" # default state set by database
  SUBMITTED = "submitted" # Ready to be approved

  def valid_to_submit?
    errors.clear
    # run all validations and then check for errors otherwise ruby stops at the first error
    valid_title?
    valid_data_sponsor?
    valid_data_manager?
    valid_departments?
    valid_quota?
    valid_project_purpose?
    valid_description?
    # Is parent folder really required?  For Skeletor let's skip it.
    # valid_parent_folder?
    valid_project_folder?
    # For Skeletor we are setting the requestor to the data sponsor
    # valid_requested_by?
    errors.count == 0
  end

  def valid_title?
    check_errors? do
      field_present?(project_title, :project_title)
      valid_length(project_title, 200, :project_title)
      no_quotes(project_title, :project_title)
    end
  end

  def valid_data_sponsor?
    check_errors? { validate_uid(data_sponsor, :data_sponsor) }
  end

  def valid_data_manager?
    check_errors? { validate_uid(data_manager, :data_manager) }
  end

  def valid_departments?
    check_errors? { field_present?(departments, :departments) }
  end

  def valid_project_purpose?
    check_errors? { project_purpose_present?(project_purpose, :project_purpose) }
  end

  def valid_description?
    check_errors? do
      field_present?(description, :description)
      valid_length(description, 1000, :description)
      no_quotes(description, :description)
    end
  end

  def valid_parent_folder?
    check_errors? do
      field_present?(parent_folder, :parent_folder)
      no_quotes(project_title, :parent_folder)
    end
  end

  def valid_project_folder?
    check_errors? do
      field_present?(project_folder, :project_folder)
      no_quotes(project_folder, :project_folder)
    end
  end

  def valid_quota?
    if ((quota == "500 GB") || (quota == "2 TB") || (quota == "10 TB") || (quota == "25 TB")) ||
       (custom_quota? && (storage_size.present? && (storage_size > 0)) && ((storage_unit == "GB") || (storage_unit == "TB")))
      true
    else
      errors.add(:quota, :invalid, message: "must be one of '500 GB', '2 TB', '10 TB', '25 TB', or 'custom'")
      false
    end
  end

  def custom_quota?
    quota == "custom"
  end

  def valid_requested_by?
    check_errors? { field_present?(requested_by, :requested_by) }
  end

  def approve(approver)
    create_project_operation = ProjectCreate.new
    result = create_project_operation.call(request: self, approver: approver)
    if result.success?
      result.value!
    else
      self.error_message = { message: result.failure }
      save!
      cleanup_incomplete_project
      raise ProjectCreate::ProjectCreateError, result.failure
    end
  end

  def approved_quota_size
    if approved_quota.present?
      if approved_quota == "custom"
        approved_storage_size.to_f
      else
        approved_quota.split.first.to_f
      end
    else
      requested_quota_size
    end
  end

  def requested_quota_size
    if custom_quota?
      storage_size.to_f
    else
      quota.split.first.to_f
    end
  end

  def approved_quota_unit
    if approved_quota.present?
      if approved_quota == "custom"
        approved_storage_unit
      else
        approved_quota.split.last
      end
    else
      requested_quota_unit
    end
  end

  def requested_quota_unit
    if custom_quota?
      storage_unit
    else
      quota.split.last
    end
  end

  def submitted?
    state == Request::SUBMITTED
  end

  def project_path
    return project_folder if parent_folder.blank?

    [parent_folder, project_folder].join("/")
  end

  def requestor
    return "missing" if requested_by.blank?
    User.find_by(uid: requested_by).display_name_safe
  end

  private

    def check_errors?
      original_error_count = errors.count
      yield
      original_error_count == errors.count
    end

    def field_present?(value, name)
      if value.blank?
        errors.add(name, :invalid, message: "cannot be empty")
      end
    end

    def validate_uid(uid, field)
      if uid.blank?
        errors.add(field, :blank, message: "cannot be empty")
      elsif User.where(uid: uid).count == 0
        errors.add(field, :invalid, message: "must be a valid user")
      end
    end

    def project_purpose_present?(project_purpose, field)
      if project_purpose.blank?
        errors.add(field, :blank, message: "select a project purpose")
      end
    end

    def valid_length(value, length, field)
      return if value.blank?
      if value.length > length
        errors.add(field, :invalid, message: "cannot exceed #{length} characters")
      end
    end

    def no_quotes(value, field)
      return if value.blank?
      if value.include?('"')
        errors.add(field, :invalid, message: "cannot include quotes")
      end
    end

    # If a request fails to be a approved we make sure there were not orphan
    # project records left in our Rails database that do not have a matching
    # project in Mediaflux (i.e. collection asset).
    def cleanup_incomplete_project
      project = Project.find_by_id(project_id)
      if project && project.mediaflux_id.nil?
        Rails.logger.warn("Deleting project #{project.id} because the approval for request #{id} failed and it was not created in Mediaflux.")
        project.destroy!
      end
    end
end
# rubocop:enable Metrics/ClassLength

1	# frozen_string_literal: true
2	# rubocop:disable Metrics/ClassLength
3	class Request < ApplicationRecord	4✔
4	DRAFT = "draft" # default state set by database	4✔
5	SUBMITTED = "submitted" # Ready to be approved	4✔
6
7	def valid_to_submit?	4✔
8	errors.clear	52✔
9	# run all validations and then check for errors otherwise ruby stops at the first error
10	valid_title?	52✔
11	valid_data_sponsor?	52✔
12	valid_data_manager?	52✔
13	valid_departments?	52✔
14	valid_quota?	52✔
15	valid_project_purpose?	52✔
16	valid_description?	52✔
17	# Is parent folder really required? For Skeletor let's skip it.
18	# valid_parent_folder?
19	valid_project_folder?	52✔
20	# For Skeletor we are setting the requestor to the data sponsor
21	# valid_requested_by?
22	errors.count == 0	52✔
23	end
24
25	def valid_title?	4✔
26	check_errors? do	61✔
27	field_present?(project_title, :project_title)	61✔
28	valid_length(project_title, 200, :project_title)	61✔
29	no_quotes(project_title, :project_title)	61✔
30	end
31	end
32
33	def valid_data_sponsor?	4✔
34	check_errors? { validate_uid(data_sponsor, :data_sponsor) }	110✔
35	end
36
37	def valid_data_manager?	4✔
38	check_errors? { validate_uid(data_manager, :data_manager) }	110✔
39	end
40
41	def valid_departments?	4✔
42	check_errors? { field_present?(departments, :departments) }	108✔
43	end
44
45	def valid_project_purpose?	4✔
46	check_errors? { project_purpose_present?(project_purpose, :project_purpose) }	104✔
47	end
48
49	def valid_description?	4✔
50	check_errors? do	57✔
51	field_present?(description, :description)	57✔
52	valid_length(description, 1000, :description)	57✔
53	no_quotes(description, :description)	57✔
54	end
55	end
56
57	def valid_parent_folder?	4✔
58	check_errors? do	2✔
59	field_present?(parent_folder, :parent_folder)	2✔
60	no_quotes(project_title, :parent_folder)	2✔
61	end
62	end
63
64	def valid_project_folder?	4✔
65	check_errors? do	55✔
66	field_present?(project_folder, :project_folder)	55✔
67	no_quotes(project_folder, :project_folder)	55✔
68	end
69	end
70
71	def valid_quota?	4✔
72	if ((quota == "500 GB") \|\| (quota == "2 TB") \|\| (quota == "10 TB") \|\| (quota == "25 TB")) \|\|	60✔
73	(custom_quota? && (storage_size.present? && (storage_size > 0)) && ((storage_unit == "GB") \|\| (storage_unit == "TB")))	5✔
74	true	57✔
75	else
76	errors.add(:quota, :invalid, message: "must be one of '500 GB', '2 TB', '10 TB', '25 TB', or 'custom'")	3✔
77	false	3✔
78	end
79	end
80
81	def custom_quota?	4✔
82	quota == "custom"	229✔
83	end
84
85	def valid_requested_by?	4✔
86	check_errors? { field_present?(requested_by, :requested_by) }	4✔
87	end
88
89	def approve(approver)	4✔
90	create_project_operation = ProjectCreate.new	86✔
91	result = create_project_operation.call(request: self, approver: approver)	86✔
92	if result.success?	86✔
93	result.value!	83✔
94	else
95	self.error_message = { message: result.failure }	3✔
96	save!	3✔
97	cleanup_incomplete_project	3✔
98	raise ProjectCreate::ProjectCreateError, result.failure	3✔
99	end
100	end
101
102	def approved_quota_size	4✔
103	if approved_quota.present?	88✔
104	if approved_quota == "custom"	76✔
105	approved_storage_size.to_f	75✔
106	else
107	approved_quota.split.first.to_f	1✔
108	end
109	else
UNCOV 110	requested_quota_size	12✔
111	end
112	end
113
114	def requested_quota_size	4✔
115	if custom_quota?	112✔
116	storage_size.to_f	78✔
117	else
UNCOV 118	quota.split.first.to_f	34✔
119	end
120	end
121
122	def approved_quota_unit	4✔
123	if approved_quota.present?	91✔
124	if approved_quota == "custom"	78✔
125	approved_storage_unit	77✔
126	else
127	approved_quota.split.last	1✔
128	end
129	else
UNCOV 130	requested_quota_unit	13✔
131	end
132	end
133
134	def requested_quota_unit	4✔
135	if custom_quota?	112✔
136	storage_unit	78✔
137	else
UNCOV 138	quota.split.last	34✔
139	end
140	end
141
142	def submitted?	4✔
UNCOV 143	state == Request::SUBMITTED	55✔
144	end
145
146	def project_path	4✔
NEW 147	return project_folder if parent_folder.blank?	3✔
148
NEW 149	[parent_folder, project_folder].join("/")	1✔
150	end
151
152	def requestor	4✔
NEW 153	return "missing" if requested_by.blank?	2✔
NEW 154	User.find_by(uid: requested_by).display_name_safe	1✔
155	end
156
157	private	4✔
158
159	def check_errors?	4✔
160	original_error_count = errors.count	393✔
161	yield	393✔
162	original_error_count == errors.count	393✔
163	end
164
165	def field_present?(value, name)	4✔
166	if value.blank?	231✔
167	errors.add(name, :invalid, message: "cannot be empty")	86✔
168	end
169	end
170
171	def validate_uid(uid, field)	4✔
172	if uid.blank?	110✔
173	errors.add(field, :blank, message: "cannot be empty")	37✔
174	elsif User.where(uid: uid).count == 0	73✔
175	errors.add(field, :invalid, message: "must be a valid user")	2✔
176	end
177	end
178
179	def project_purpose_present?(project_purpose, field)	4✔
180	if project_purpose.blank?	52✔
181	errors.add(field, :blank, message: "select a project purpose")	25✔
182	end
183	end
184
185	def valid_length(value, length, field)	4✔
186	return if value.blank?	118✔
187	if value.length > length	78✔
188	errors.add(field, :invalid, message: "cannot exceed #{length} characters")	8✔
189	end
190	end
191
192	def no_quotes(value, field)	4✔
193	return if value.blank?	175✔
194	if value.include?('"')	110✔
195	errors.add(field, :invalid, message: "cannot include quotes")	5✔
196	end
197	end
198
199	# If a request fails to be a approved we make sure there were not orphan
200	# project records left in our Rails database that do not have a matching
201	# project in Mediaflux (i.e. collection asset).
202	def cleanup_incomplete_project	4✔
203	project = Project.find_by_id(project_id)	3✔
204	if project && project.mediaflux_id.nil?	3✔
205	Rails.logger.warn("Deleting project #{project.id} because the approval for request #{id} failed and it was not created in Mediaflux.")	2✔
206	project.destroy!	2✔
207	end
208	end
209	end
210	# rubocop:enable Metrics/ClassLength

pulibrary / tigerdata-app / 07f4d952-7d18-4551-a848-48bb16200c76

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous