8306569a-4f72-444d-ba8a-d69ed227106c

Committed 05 Nov 2025 07:43PM UTC coverage: 91.527% (+0.03%) from 91.5%

Build # 8306569a-4f72-444d-ba8a-d69ed227106c

Build Type

push

circleci

Committed by

web-flow

Commit Message

Set the displayed value to the entire name (#2151)

Centralize the view and javascript for data manager and sponsor
Set the displayed value to the entire name and have a hidden field with
the uid

fix spec error "not to search for nil"
<img width="1707" height="1085" alt="Screenshot 2025-11-05 at 2 38
43 PM"
src="https://github.com/user-attachments/assets/82278712-d16d-4b58-8b9c-5c33587a7810"
/>

Run Details

6 of 10 new or added lines in 1 file covered. (60.0%)

1010 existing lines in 37 files now uncovered.

2841 of 3104 relevant lines covered (91.53%)

792.96 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

100.0

/app/models/request.rb

# frozen_string_literal: true
# rubocop:disable Metrics/ClassLength
class Request < ApplicationRecord
  DRAFT = "draft" # default state set by database
  SUBMITTED = "submitted" # Ready to be approved

  def valid_to_submit?
    errors.clear
    # run all validations and then check for errors otherwise ruby stops at the first error
    valid_title?
    valid_data_sponsor?
    valid_data_manager?
    valid_departments?
    valid_quota?
    valid_project_purpose?
    valid_description?
    # Is parent folder really required?  For Skeletor let's skip it.
    # valid_parent_folder?
    valid_project_folder?
    # For Skeletor we are setting the requestor to the data sponsor
    # valid_requested_by?
    errors.count == 0
  end

  def valid_title?
    check_errors? do
      field_present?(project_title, :project_title)
      valid_length(project_title, 200, :project_title)
      no_quotes(project_title, :project_title)
    end
  end

  def valid_data_sponsor?
    check_errors? { validate_uid(data_sponsor, :data_sponsor) }
  end

  def valid_data_manager?
    check_errors? { validate_uid(data_manager, :data_manager) }
  end

  def valid_departments?
    check_errors? { field_present?(departments, :departments) }
  end

  def valid_project_purpose?
    check_errors? { project_purpose_present?(project_purpose, :project_purpose) }
  end

  def valid_description?
    check_errors? do
      field_present?(description, :description)
      valid_length(description, 1000, :description)
      no_quotes(description, :description)
    end
  end

  def valid_parent_folder?
    check_errors? do
      field_present?(parent_folder, :parent_folder)
      no_quotes(project_title, :parent_folder)
    end
  end

  def valid_project_folder?
    check_errors? do
      field_present?(project_folder, :project_folder)
      no_quotes(project_folder, :project_folder)
    end
  end

  def valid_quota?
    if ((quota == "500 GB") || (quota == "2 TB") || (quota == "10 TB") || (quota == "25 TB")) ||
       (custom_quota? && (storage_size.present? && (storage_size > 0)) && ((storage_unit == "GB") || (storage_unit == "TB")))
      true
    else
      errors.add(:quota, :invalid, message: "must be one of '500 GB', '2 TB', '10 TB', '25 TB', or 'custom'")
      false
    end
  end

  def custom_quota?
    quota == "custom"
  end

  def valid_requested_by?
    check_errors? { field_present?(requested_by, :requested_by) }
  end

  def approve(approver)
    create_project_operation = ProjectCreate.new
    result = create_project_operation.call(request: self, approver: approver)
    if result.success?
      result.value!
    else
      self.error_message = { message: result.failure }
      save!
      cleanup_incomplete_project
      raise ProjectCreate::ProjectCreateError, result.failure
    end
  end

  def approved_quota_size
    if approved_quota.present?
      if approved_quota == "custom"
        approved_storage_size.to_f
      else
        approved_quota.split.first.to_f
      end
    else
      requested_quota_size
    end
  end

  def requested_quota_size
    if custom_quota?
      storage_size.to_f
    else
      quota.split.first.to_f
    end
  end

  def approved_quota_unit
    if approved_quota.present?
      if approved_quota == "custom"
        approved_storage_unit
      else
        approved_quota.split.last
      end
    else
      requested_quota_unit
    end
  end

  def requested_quota_unit
    if custom_quota?
      storage_unit
    else
      quota.split.last
    end
  end

  def submitted?
    state == Request::SUBMITTED
  end

  def project_path
    return project_folder if parent_folder.blank?

    [parent_folder, project_folder].join("/")
  end

  def requestor
    return "missing" if requested_by.blank?
    User.find_by(uid: requested_by).display_name_safe
  end

  def data_manager_name
    user_name(data_manager)
  end

  def data_sponsor_name
    user_name(data_sponsor)
  end

  private

    def user_name(uid)
      return "" if uid.blank?
      user = User.find_by(uid: uid)
      if user.present?
        user.display_name_safe
      else
        uid
      end
    end

    def check_errors?
      original_error_count = errors.count
      yield
      original_error_count == errors.count
    end

    def field_present?(value, name)
      if value.blank?
        errors.add(name, :invalid, message: "cannot be empty")
      end
    end

    def validate_uid(uid, field)
      if uid.blank?
        errors.add(field, :blank, message: "cannot be empty")
      elsif User.where(uid: uid).count == 0
        errors.add(field, :invalid, message: "must be a valid user")
      end
    end

    def project_purpose_present?(project_purpose, field)
      if project_purpose.blank?
        errors.add(field, :blank, message: "select a project purpose")
      end
    end

    def valid_length(value, length, field)
      return if value.blank?
      if value.length > length
        errors.add(field, :invalid, message: "cannot exceed #{length} characters")
      end
    end

    def no_quotes(value, field)
      return if value.blank?
      if value.include?('"')
        errors.add(field, :invalid, message: "cannot include quotes")
      end
    end

    # If a request fails to be a approved we make sure there were not orphan
    # project records left in our Rails database that do not have a matching
    # project in Mediaflux (i.e. collection asset).
    def cleanup_incomplete_project
      project = Project.find_by_id(project_id)
      if project && project.mediaflux_id.nil?
        Rails.logger.warn("Deleting project #{project.id} because the approval for request #{id} failed and it was not created in Mediaflux.")
        project.destroy!
      end
    end
end
# rubocop:enable Metrics/ClassLength

1	# frozen_string_literal: true
2	# rubocop:disable Metrics/ClassLength
3	class Request < ApplicationRecord	5✔
4	DRAFT = "draft" # default state set by database	5✔
5	SUBMITTED = "submitted" # Ready to be approved	5✔
6
7	def valid_to_submit?	5✔
8	errors.clear	97✔
9	# run all validations and then check for errors otherwise ruby stops at the first error
10	valid_title?	97✔
11	valid_data_sponsor?	97✔
12	valid_data_manager?	97✔
13	valid_departments?	97✔
14	valid_quota?	97✔
15	valid_project_purpose?	97✔
16	valid_description?	97✔
17	# Is parent folder really required? For Skeletor let's skip it.
18	# valid_parent_folder?
19	valid_project_folder?	97✔
20	# For Skeletor we are setting the requestor to the data sponsor
21	# valid_requested_by?
22	errors.count == 0	97✔
23	end
24
25	def valid_title?	5✔
26	check_errors? do	115✔
27	field_present?(project_title, :project_title)	115✔
28	valid_length(project_title, 200, :project_title)	115✔
29	no_quotes(project_title, :project_title)	115✔
30	end
31	end
32
33	def valid_data_sponsor?	5✔
34	check_errors? { validate_uid(data_sponsor, :data_sponsor) }	206✔
35	end
36
37	def valid_data_manager?	5✔
38	check_errors? { validate_uid(data_manager, :data_manager) }	206✔
39	end
40
41	def valid_departments?	5✔
42	check_errors? { field_present?(departments, :departments) }	202✔
43	end
44
45	def valid_project_purpose?	5✔
46	check_errors? { project_purpose_present?(project_purpose, :project_purpose) }	194✔
47	end
48
49	def valid_description?	5✔
50	check_errors? do	107✔
51	field_present?(description, :description)	107✔
52	valid_length(description, 1000, :description)	107✔
53	no_quotes(description, :description)	107✔
54	end
55	end
56
57	def valid_parent_folder?	5✔
58	check_errors? do	4✔
59	field_present?(parent_folder, :parent_folder)	4✔
60	no_quotes(project_title, :parent_folder)	4✔
61	end
62	end
63
64	def valid_project_folder?	5✔
65	check_errors? do	103✔
66	field_present?(project_folder, :project_folder)	103✔
67	no_quotes(project_folder, :project_folder)	103✔
68	end
69	end
70
71	def valid_quota?	5✔
72	if ((quota == "500 GB") \|\| (quota == "2 TB") \|\| (quota == "10 TB") \|\| (quota == "25 TB")) \|\|	113✔
73	(custom_quota? && (storage_size.present? && (storage_size > 0)) && ((storage_unit == "GB") \|\| (storage_unit == "TB")))	10✔
74	true	106✔
75	else
76	errors.add(:quota, :invalid, message: "must be one of '500 GB', '2 TB', '10 TB', '25 TB', or 'custom'")	7✔
77	false	7✔
78	end
79	end
80
81	def custom_quota?	5✔
82	quota == "custom"	880✔
83	end
84
85	def valid_requested_by?	5✔
86	check_errors? { field_present?(requested_by, :requested_by) }	8✔
87	end
88
89	def approve(approver)	5✔
90	create_project_operation = ProjectCreate.new	360✔
91	result = create_project_operation.call(request: self, approver: approver)	360✔
92	if result.success?	360✔
93	result.value!	354✔
94	else
95	self.error_message = { message: result.failure }	6✔
96	save!	6✔
97	cleanup_incomplete_project	6✔
98	raise ProjectCreate::ProjectCreateError, result.failure	6✔
99	end
100	end
101
102	def approved_quota_size	5✔
103	if approved_quota.present?	396✔
104	if approved_quota == "custom"	345✔
105	approved_storage_size.to_f	342✔
106	else
107	approved_quota.split.first.to_f	3✔
108	end
109	else
110	requested_quota_size	51✔
111	end
112	end
113
114	def requested_quota_size	5✔
115	if custom_quota?	435✔
116	storage_size.to_f	351✔
117	else
118	quota.split.first.to_f	84✔
119	end
120	end
121
122	def approved_quota_unit	5✔
123	if approved_quota.present?	402✔
124	if approved_quota == "custom"	349✔
125	approved_storage_unit	346✔
126	else
127	approved_quota.split.last	3✔
128	end
129	else
130	requested_quota_unit	53✔
131	end
132	end
133
134	def requested_quota_unit	5✔
135	if custom_quota?	435✔
136	storage_unit	351✔
137	else
138	quota.split.last	84✔
139	end
140	end
141
142	def submitted?	5✔
143	state == Request::SUBMITTED	191✔
144	end
145
146	def project_path	5✔
147	return project_folder if parent_folder.blank?	4✔
148
149	[parent_folder, project_folder].join("/")	2✔
150	end
151
152	def requestor	5✔
153	return "missing" if requested_by.blank?	3✔
154	User.find_by(uid: requested_by).display_name_safe	3✔
155	end
156
157	def data_manager_name	5✔
158	user_name(data_manager)	32✔
159	end
160
161	def data_sponsor_name	5✔
162	user_name(data_sponsor)	32✔
163	end
164
165	private	5✔
166
167	def user_name(uid)	5✔
168	return "" if uid.blank?	64✔
NEW 169	user = User.find_by(uid: uid)	16✔
NEW 170	if user.present?	16✔
NEW 171	user.display_name_safe	14✔
172	else
NEW 173	uid	2✔
174	end
175	end
176
177	def check_errors?	5✔
178	original_error_count = errors.count	737✔
179	yield	737✔
180	original_error_count == errors.count	737✔
181	end
182
183	def field_present?(value, name)	5✔
184	if value.blank?	434✔
185	errors.add(name, :invalid, message: "cannot be empty")	138✔
186	end
187	end
188
189	def validate_uid(uid, field)	5✔
190	if uid.blank?	206✔
191	errors.add(field, :blank, message: "cannot be empty")	56✔
192	elsif User.where(uid: uid).count == 0	150✔
193	errors.add(field, :invalid, message: "must be a valid user")	4✔
194	end
195	end
196
197	def project_purpose_present?(project_purpose, field)	5✔
198	if project_purpose.blank?	97✔
199	errors.add(field, :blank, message: "select a project purpose")	41✔
200	end
201	end
202
203	def valid_length(value, length, field)	5✔
204	return if value.blank?	222✔
205	if value.length > length	158✔
206	errors.add(field, :invalid, message: "cannot exceed #{length} characters")	12✔
207	end
208	end
209
210	def no_quotes(value, field)	5✔
211	return if value.blank?	329✔
212	if value.include?('"')	224✔
213	errors.add(field, :invalid, message: "cannot include quotes")	10✔
214	end
215	end
216
217	# If a request fails to be a approved we make sure there were not orphan
218	# project records left in our Rails database that do not have a matching
219	# project in Mediaflux (i.e. collection asset).
220	def cleanup_incomplete_project	5✔
221	project = Project.find_by_id(project_id)	6✔
222	if project && project.mediaflux_id.nil?	6✔
223	Rails.logger.warn("Deleting project #{project.id} because the approval for request #{id} failed and it was not created in Mediaflux.")	4✔
224	project.destroy!	4✔
225	end
226	end
227	end
228	# rubocop:enable Metrics/ClassLength

pulibrary / tigerdata-app / 8306569a-4f72-444d-ba8a-d69ed227106c

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous