21b3684e-2cf2-4e1c-adb5-a44be328e358

Committed 07 Nov 2025 03:59PM UTC coverage: 82.627% (-8.4%) from 91.075%

Build # 21b3684e-2cf2-4e1c-adb5-a44be328e358

Build Type

Pull #2163

circleci

Committed by

carolyncole

Commit Message

Handle error fetching project list

Pull Request Pull Request #2163: Logs Mediaflux errors when fetching the project list

Run Details

5 of 8 new or added lines in 1 file covered. (62.5%)

891 existing lines in 32 files now uncovered.

2592 of 3137 relevant lines covered (82.63%)

353.31 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

92.31

/app/models/project.rb

# frozen_string_literal: true
class Project < ApplicationRecord

  validates_with ProjectValidator
  has_many :provenance_events, dependent: :destroy
  before_save do |project|
    # Ensure that the metadata JSONB postgres field is persisted properly
    project.metadata = project.metadata_model
  end

  # Valid project status described in ADR 7
  # See `architecture-decisions/0007-valid-project-statuses.md`
  APPROVED_STATUS = "approved"
  ACTIVE_STATUS = "active"

  delegate :to_json, to: :metadata_json # field in the database

  def create!(initial_metadata:, user:)
    self.metadata_model = initial_metadata
    if self.valid?
      if initial_metadata.project_id == ProjectMetadata::DOI_NOT_MINTED
        self.draft_doi(user: user)
        self.save!
        ProvenanceEvent.generate_submission_events(project: self, user: user)
      else
        self.save!
      end
      # return doi
      self.metadata_model.project_id
    else
      nil
    end
  end

  def activate(current_user:)
    raise StandardError.new("Only approved projects can be activated") if self.status != Project::APPROVED_STATUS
    metadata_request = Mediaflux::AssetMetadataRequest.new(session_token: current_user.mediaflux_session, id: self.mediaflux_id)
    metadata_request.resolve
    raise metadata_request.response_error if metadata_request.error?
    if self.title == metadata_request.metadata[:title]
      self.metadata_model.status = Project::ACTIVE_STATUS
      self.save!
    else
      raise StandardError.new("Title mismatch: #{self.title} != #{metadata_request.metadata[:title]}")
    end
  end

  def draft_doi(user: nil)
    puldatacite = PULDatacite.new
    self.metadata_model.project_id = puldatacite.draft_doi
  end

  # Ideally this method should return a ProjectMetadata object (like `metadata_model` does)
  # but we'll keep them both while we are refactoring the code so that we don't break
  # everything at once since `metadata` is used everywhere.
  def metadata
    @metadata_hash = (metadata_json || {}).with_indifferent_access
  end

  def metadata_model
    @metadata_model ||= ProjectMetadata.new_from_hash(self.metadata)
  end

  def metadata_model=(new_metadata_model)
    @metadata_model = new_metadata_model
  end

  def metadata=(metadata_model)
    # Convert our metadata to a hash so it can be saved on our JSONB field
    metadata_hash = JSON.parse(metadata_model.to_json)
    self.metadata_json = metadata_hash
  end

  def title
    self.metadata_model.title
  end

  def departments
    unsorted = metadata_model.departments || []
    unsorted.sort
  end

  def project_directory
    metadata_model.project_directory || ""
  end

  def project_directory_short
    project_directory
  end

  def status
    metadata_model.status
  end

  def in_mediaflux?
    mediaflux_id.present?
  end

  # This method narrows the list down returned by `all_projects` to only those projects where the user has
  # been given a role (e.g. sponsor, manager, or data user.) For most users `all_projects` and `user_projects`
  # are identical, but for administrators the lists can be very different since they are not part of most
  # projects even though they have access to them in Mediaflux.
  def self.users_projects(user)
    all_projects(user).select do |project|
      project[:data_manager] == user.uid || project[:data_sponsor] == user.uid || project[:data_users].include?(user.uid)
    end
  end

  # Returns the projects that the current user has access in Mediaflux given their credentials
  def self.all_projects(user, aql_query = "xpath(tigerdata:project/ProjectID) has value")
    request = Mediaflux::ProjectListRequest.new(session_token: user.mediaflux_session, aql_query:)
    request.resolve
    if request.error?
      Rails.logger.error("Error fetching project list for user #{user&.uid}: #{request.response_error[:message]}")
      Honeybadger.notify("Error fetching project list for user #{user&.uid}: #{request.response_error[:message]}")
      []
    else
      request.results
    end
  end

  def created_by_user
    User.find_by(uid: metadata_model.created_by)
  end

  # @return [String] XML representation of the <meta> element
  def mediaflux_meta_xml(user:)
    doc = ProjectMediaflux.document(project: self, user: user)
    doc.xpath("/response/reply/result/asset/meta").to_s
  end

  def mediaflux_metadata(session_id:)
    @mediaflux_metadata ||= begin
      metadata_request = Mediaflux::AssetMetadataRequest.new(session_token: session_id, id: mediaflux_id)
      metadata_request.metadata
    end
    @mediaflux_metadata
  end

  def asset_count(session_id:)
    values = mediaflux_metadata(session_id:)
    values.fetch(:total_file_count, 0)
  end

  def self.default_storage_unit
    "KB"
  end

  def self.default_storage_usage
    "0 #{default_storage_unit}"
  end

  def storage_usage(session_id:)
    values = mediaflux_metadata(session_id:)
    values.fetch(:quota_used, self.class.default_storage_usage) # if the storage is empty use the default
  end

  def storage_usage_raw(session_id:)
    values = mediaflux_metadata(session_id:)
    values.fetch(:quota_used_raw, 0) # if the storage raw is empty use zero
  end

  def self.default_storage_capacity
    "0 GB"
  end

  def storage_capacity(session_id:)
    values = mediaflux_metadata(session_id:)
    quota_value = values.fetch(:quota_allocation, '') #if quota does not exist, set value to an empty string
    if quota_value.blank?
      return self.class.default_storage_capacity
    else
      return quota_value
    end
  end

  def storage_capacity_raw(session_id:)
    values = mediaflux_metadata(session_id:)
    quota_value = values.fetch(:quota_allocation_raw, 0) #if quota does not exist, set value to 0
    quota_value
  end

  # Fetches the first n files
  def file_list(session_id:, size: 10)
    return { files: [] } if mediaflux_id.nil?

    query_req = Mediaflux::QueryRequest.new(session_token: session_id, collection: mediaflux_id, deep_search: true, aql_query: "type!='application/arc-asset-collection'")
    iterator_id = query_req.result

    iterator_req = Mediaflux::IteratorRequest.new(session_token: session_id, iterator: iterator_id, size: size)
    results = iterator_req.result

    # Destroy _after_ fetching the first set of results from iterator_req.
    # This call is required since it possible that we have read less assets than
    # what the collection has but we are done with the iterator.
    Mediaflux::IteratorDestroyRequest.new(session_token: session_id, iterator: iterator_id).resolve

    results
  end

  # Fetches the entire file list to a file
  def file_list_to_file(session_id:, filename:)
    return { files: [] } if mediaflux_id.nil?

    query_req = Mediaflux::QueryRequest.new(session_token: session_id, collection: mediaflux_id, deep_search: true,  aql_query: "type!='application/arc-asset-collection'")
    iterator_id = query_req.result

    start_time = Time.zone.now
    prefix = "file_list_to_file #{session_id[0..7]} #{self.metadata_model.project_id}"
    log_elapsed(start_time, prefix, "STARTED")

    File.open(filename, "w") do |file|
      page_number = 0
      # file header
      file.write("ID, PATH, NAME, COLLECTION?, LAST_MODIFIED, SIZE\r\n")
      loop do
        iterator_start_time = Time.zone.now
        page_number += 1
        iterator_req = Mediaflux::IteratorRequest.new(session_token: session_id, iterator: iterator_id, size: 1000)
        iterator_resp = iterator_req.result
        log_elapsed(iterator_start_time, prefix, "FETCHED page #{page_number} from iterator")
        lines = files_from_iterator(iterator_resp)
        file.write(lines.join("\r\n") + "\r\n")
        break if iterator_resp[:complete] || iterator_req.error?
      end
      log_elapsed(start_time, prefix, "ENDED")
    end

    # Destroy _after_ fetching the results from iterator_req
    # This call is technically not necessary since Mediaflux automatically deletes the iterator
    # once we have ran through it and by now we have. But it does not hurt either.
    Mediaflux::IteratorDestroyRequest.new(session_token: session_id, iterator: iterator_id).resolve
  end


  private

    def files_from_iterator(iterator_resp)
      lines = []
      iterator_resp[:files].each do |asset|
        lines << "#{asset.id}, #{asset.path_only}, #{asset.name}, #{asset.collection}, #{asset.last_modified}, #{asset.size}"
      end
      lines
    end

    def project_directory_pathname
      # allow the directory to be modified by changes in the metadata_json
      @project_directory_pathname = nil if @original_directory.present? && @original_directory != metadata_model.project_directory

      @project_directory_pathname ||= begin
        @original_directory = metadata_model.project_directory
        Pathname.new(@original_directory)
      end
    end

    # Ensure that the project directory is a valid path
    def safe_directory(directory)
      Project.safe_directory(directory)
    end

    def log_elapsed(start_time, prefix, message)
      elapsed_time = Time.zone.now - start_time
      timing_info = "#{format('%.2f', elapsed_time)} s"
      Rails.logger.info "#{prefix}: #{message}, #{timing_info}"
    end
end

1	# frozen_string_literal: true
2	class Project < ApplicationRecord	3✔
3
4	validates_with ProjectValidator	3✔
5	has_many :provenance_events, dependent: :destroy	3✔
6	before_save do \|project\|	3✔
7	# Ensure that the metadata JSONB postgres field is persisted properly
8	project.metadata = project.metadata_model	868✔
9	end
10
11	# Valid project status described in ADR 7
12	# See `architecture-decisions/0007-valid-project-statuses.md`
13	APPROVED_STATUS = "approved"	3✔
14	ACTIVE_STATUS = "active"	3✔
15
16	delegate :to_json, to: :metadata_json # field in the database	3✔
17
18	def create!(initial_metadata:, user:)	3✔
UNCOV 19	self.metadata_model = initial_metadata	5✔
UNCOV 20	if self.valid?	5✔
UNCOV 21	if initial_metadata.project_id == ProjectMetadata::DOI_NOT_MINTED	3✔
UNCOV 22	self.draft_doi(user: user)	2✔
UNCOV 23	self.save!	2✔
UNCOV 24	ProvenanceEvent.generate_submission_events(project: self, user: user)	2✔
25	else
UNCOV 26	self.save!	1✔
27	end
28	# return doi
UNCOV 29	self.metadata_model.project_id	3✔
30	else
31	nil
32	end
33	end
34
35	def activate(current_user:)	3✔
36	raise StandardError.new("Only approved projects can be activated") if self.status != Project::APPROVED_STATUS	199✔
37	metadata_request = Mediaflux::AssetMetadataRequest.new(session_token: current_user.mediaflux_session, id: self.mediaflux_id)	199✔
38	metadata_request.resolve	199✔
39	raise metadata_request.response_error if metadata_request.error?	199✔
40	if self.title == metadata_request.metadata[:title]	199✔
41	self.metadata_model.status = Project::ACTIVE_STATUS	199✔
42	self.save!	199✔
43	else
44	raise StandardError.new("Title mismatch: #{self.title} != #{metadata_request.metadata[:title]}")	×
45	end
46	end
47
48	def draft_doi(user: nil)	3✔
49	puldatacite = PULDatacite.new	207✔
50	self.metadata_model.project_id = puldatacite.draft_doi	207✔
51	end
52
53	# Ideally this method should return a ProjectMetadata object (like `metadata_model` does)
54	# but we'll keep them both while we are refactoring the code so that we don't break
55	# everything at once since `metadata` is used everywhere.
56	def metadata	3✔
57	@metadata_hash = (metadata_json \|\| {}).with_indifferent_access	392✔
58	end
59
60	def metadata_model	3✔
61	@metadata_model \|\|= ProjectMetadata.new_from_hash(self.metadata)	10,615✔
62	end
63
64	def metadata_model=(new_metadata_model)	3✔
65	@metadata_model = new_metadata_model	32✔
66	end
67
68	def metadata=(metadata_model)	3✔
69	# Convert our metadata to a hash so it can be saved on our JSONB field
70	metadata_hash = JSON.parse(metadata_model.to_json)	1,790✔
71	self.metadata_json = metadata_hash	1,790✔
72	end
73
74	def title	3✔
75	self.metadata_model.title	259✔
76	end
77
78	def departments	3✔
79	unsorted = metadata_model.departments \|\| []	×
80	unsorted.sort	×
81	end
82
83	def project_directory	3✔
84	metadata_model.project_directory \|\| ""	34✔
85	end
86
87	def project_directory_short	3✔
88	project_directory	10✔
89	end
90
91	def status	3✔
92	metadata_model.status	512✔
93	end
94
95	def in_mediaflux?	3✔
96	mediaflux_id.present?	18✔
97	end
98
99	# This method narrows the list down returned by `all_projects` to only those projects where the user has
100	# been given a role (e.g. sponsor, manager, or data user.) For most users `all_projects` and `user_projects`
101	# are identical, but for administrators the lists can be very different since they are not part of most
102	# projects even though they have access to them in Mediaflux.
103	def self.users_projects(user)	3✔
104	all_projects(user).select do \|project\|	71✔
105	project[:data_manager] == user.uid \|\| project[:data_sponsor] == user.uid \|\| project[:data_users].include?(user.uid)	3,251✔
106	end
107	end
108
109	# Returns the projects that the current user has access in Mediaflux given their credentials
110	def self.all_projects(user, aql_query = "xpath(tigerdata:project/ProjectID) has value")	3✔
111	request = Mediaflux::ProjectListRequest.new(session_token: user.mediaflux_session, aql_query:)	76✔
112	request.resolve	76✔
113	if request.error?	76✔
NEW 114	Rails.logger.error("Error fetching project list for user #{user&.uid}: #{request.response_error[:message]}")	1✔
NEW 115	Honeybadger.notify("Error fetching project list for user #{user&.uid}: #{request.response_error[:message]}")	1✔
NEW 116	[]	1✔
117	else
118	request.results	75✔
119	end
120	end
121
122	def created_by_user	3✔
123	User.find_by(uid: metadata_model.created_by)	×
124	end
125
126	# @return [String] XML representation of the <meta> element
127	def mediaflux_meta_xml(user:)	3✔
128	doc = ProjectMediaflux.document(project: self, user: user)	1✔
129	doc.xpath("/response/reply/result/asset/meta").to_s	1✔
130	end
131
132	def mediaflux_metadata(session_id:)	3✔
UNCOV 133	@mediaflux_metadata \|\|= begin	815✔
UNCOV 134	metadata_request = Mediaflux::AssetMetadataRequest.new(session_token: session_id, id: mediaflux_id)	123✔
UNCOV 135	metadata_request.metadata	123✔
136	end
UNCOV 137	@mediaflux_metadata	815✔
138	end
139
140	def asset_count(session_id:)	3✔
141	values = mediaflux_metadata(session_id:)	25✔
142	values.fetch(:total_file_count, 0)	25✔
143	end
144
145	def self.default_storage_unit	3✔
UNCOV 146	"KB"	216✔
147	end
148
149	def self.default_storage_usage	3✔
UNCOV 150	"0 #{default_storage_unit}"	215✔
151	end
152
153	def storage_usage(session_id:)	3✔
154	values = mediaflux_metadata(session_id:)	214✔
155	values.fetch(:quota_used, self.class.default_storage_usage) # if the storage is empty use the default	214✔
156	end
157
158	def storage_usage_raw(session_id:)	3✔
159	values = mediaflux_metadata(session_id:)	141✔
160	values.fetch(:quota_used_raw, 0) # if the storage raw is empty use zero	141✔
161	end
162
163	def self.default_storage_capacity	3✔
164	"0 GB"	×
165	end
166
167	def storage_capacity(session_id:)	3✔
168	values = mediaflux_metadata(session_id:)	214✔
169	quota_value = values.fetch(:quota_allocation, '') #if quota does not exist, set value to an empty string	214✔
170	if quota_value.blank?	214✔
171	return self.class.default_storage_capacity	×
172	else
173	return quota_value	214✔
174	end
175	end
176
177	def storage_capacity_raw(session_id:)	3✔
178	values = mediaflux_metadata(session_id:)	172✔
179	quota_value = values.fetch(:quota_allocation_raw, 0) #if quota does not exist, set value to 0	172✔
180	quota_value	172✔
181	end
182
183	# Fetches the first n files
184	def file_list(session_id:, size: 10)	3✔
UNCOV 185	return { files: [] } if mediaflux_id.nil?	28✔
186
UNCOV 187	query_req = Mediaflux::QueryRequest.new(session_token: session_id, collection: mediaflux_id, deep_search: true, aql_query: "type!='application/arc-asset-collection'")	28✔
UNCOV 188	iterator_id = query_req.result	28✔
189
UNCOV 190	iterator_req = Mediaflux::IteratorRequest.new(session_token: session_id, iterator: iterator_id, size: size)	28✔
UNCOV 191	results = iterator_req.result	28✔
192
193	# Destroy _after_ fetching the first set of results from iterator_req.
194	# This call is required since it possible that we have read less assets than
195	# what the collection has but we are done with the iterator.
UNCOV 196	Mediaflux::IteratorDestroyRequest.new(session_token: session_id, iterator: iterator_id).resolve	28✔
197
UNCOV 198	results	28✔
199	end
200
201	# Fetches the entire file list to a file
202	def file_list_to_file(session_id:, filename:)	3✔
203	return { files: [] } if mediaflux_id.nil?	2✔
204
205	query_req = Mediaflux::QueryRequest.new(session_token: session_id, collection: mediaflux_id, deep_search: true, aql_query: "type!='application/arc-asset-collection'")	2✔
206	iterator_id = query_req.result	2✔
207
208	start_time = Time.zone.now	2✔
209	prefix = "file_list_to_file #{session_id[0..7]} #{self.metadata_model.project_id}"	2✔
210	log_elapsed(start_time, prefix, "STARTED")	2✔
211
212	File.open(filename, "w") do \|file\|	2✔
213	page_number = 0	2✔
214	# file header
215	file.write("ID, PATH, NAME, COLLECTION?, LAST_MODIFIED, SIZE\r\n")	2✔
216	loop do	2✔
217	iterator_start_time = Time.zone.now	2✔
218	page_number += 1	2✔
219	iterator_req = Mediaflux::IteratorRequest.new(session_token: session_id, iterator: iterator_id, size: 1000)	2✔
220	iterator_resp = iterator_req.result	2✔
221	log_elapsed(iterator_start_time, prefix, "FETCHED page #{page_number} from iterator")	2✔
222	lines = files_from_iterator(iterator_resp)	2✔
223	file.write(lines.join("\r\n") + "\r\n")	2✔
224	break if iterator_resp[:complete] \|\| iterator_req.error?	2✔
225	end
226	log_elapsed(start_time, prefix, "ENDED")	2✔
227	end
228
229	# Destroy _after_ fetching the results from iterator_req
230	# This call is technically not necessary since Mediaflux automatically deletes the iterator
231	# once we have ran through it and by now we have. But it does not hurt either.
232	Mediaflux::IteratorDestroyRequest.new(session_token: session_id, iterator: iterator_id).resolve	2✔
233	end
234
235
236	private	3✔
237
238	def files_from_iterator(iterator_resp)	3✔
239	lines = []	2✔
240	iterator_resp[:files].each do \|asset\|	2✔
241	lines << "#{asset.id}, #{asset.path_only}, #{asset.name}, #{asset.collection}, #{asset.last_modified}, #{asset.size}"	16✔
242	end
243	lines	2✔
244	end
245
246	def project_directory_pathname	3✔
247	# allow the directory to be modified by changes in the metadata_json
248	@project_directory_pathname = nil if @original_directory.present? && @original_directory != metadata_model.project_directory	×
249
250	@project_directory_pathname \|\|= begin	×
251	@original_directory = metadata_model.project_directory	×
252	Pathname.new(@original_directory)	×
253	end
254	end
255
256	# Ensure that the project directory is a valid path
257	def safe_directory(directory)	3✔
258	Project.safe_directory(directory)	×
259	end
260
261	def log_elapsed(start_time, prefix, message)	3✔
262	elapsed_time = Time.zone.now - start_time	6✔
263	timing_info = "#{format('%.2f', elapsed_time)} s"	6✔
264	Rails.logger.info "#{prefix}: #{message}, #{timing_info}"	6✔
265	end
266	end

pulibrary / tigerdata-app / 21b3684e-2cf2-4e1c-adb5-a44be328e358

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous