4cbb8474-5468-4637-8988-22e24d3182e1

Committed 10 Nov 2025 04:47PM UTC coverage: 95.253% (-0.2%) from 95.41%

Build # 4cbb8474-5468-4637-8988-22e24d3182e1

Build Type

Pull #5339

circleci

Committed by

christinach

Commit Message

Update the hidden_service_options_fill_in with a new check for annex_no_items service
Update the submittable services to include annex_no_items
Include annex_no_items where needed by the code
Add new annex abstract method and subclasses for digitize , noitems and pickup
Pass patron as an argument in the new annex services
Update items validator with annex_no_items

Add a new condition in categorize_by_delivery_and_location method
that checks for an item type of annex_no_items && edd?
to set the item type to annex_edd (Illiad request)

related to [#4183]

Pull Request Pull Request #5339: Annex requests with no items should email forranx@princeton.edu

Run Details

49 of 62 new or added lines in 8 files covered. (79.03%)

13 existing lines in 1 file now uncovered.

6241 of 6552 relevant lines covered (95.25%)

1445.25 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

86.67

/app/models/requests/service_eligibility/annex/abstract_annex.rb

# frozen_string_literal: true
module Requests
  module ServiceEligibility
    module Annex
      # Abstract class for other annex classes to inherit from
      class AbstractAnnex
        def initialize(requestable:, patron:)
          @requestable = requestable
          @patron = patron
        end

        def to_s
          raise "Please implement to_s in the subclass"
        end

        protected

          def requestable_eligible?
            raise "Please implement requestable_eligible? in the subclass"
          end

          def patron_eligible?
            patron.core_patron_group? || patron.affiliate_patron_group?
          end

          attr_reader :requestable, :patron
      end
    end
  end
end

1	# frozen_string_literal: true
2	module Requests	3✔
3	module ServiceEligibility	3✔
4	module Annex	3✔
5	# Abstract class for other annex classes to inherit from
6	class AbstractAnnex	3✔
7	def initialize(requestable:, patron:)	3✔
8	@requestable = requestable	4,567✔
9	@patron = patron	4,567✔
10	end
11
12	def to_s	3✔
NEW 13	raise "Please implement to_s in the subclass"	×
14	end
15
16	protected	3✔
17
18	def requestable_eligible?	3✔
NEW 19	raise "Please implement requestable_eligible? in the subclass"	×
20	end
21
22	def patron_eligible?	3✔
23	patron.core_patron_group? \|\| patron.affiliate_patron_group?	154✔
24	end
25
26	attr_reader :requestable, :patron	3✔
27	end
28	end
29	end
30	end

pulibrary / orangelight / 4cbb8474-5468-4637-8988-22e24d3182e1

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous