pulibrary / tigerdata-app / 863e578f-15a5-4c93-8357-08f855de0bbc

coverage: 87.366% (-0.7%) from 88.064%
863e578f-15a5-4c93-8357-08f855de0bbc

Pull #2235

circleci

carolyncole 
Do not redirect from home page when login is disabled
fixes #2188
Pull Request #2235: Do not redirect from home page when login is disabled

5 of 5 new or added lines in 2 files covered. (100.0%)

834 existing lines in 48 files now uncovered.

2773 of 3174 relevant lines covered (87.37%)

499.78 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

93.33
/app/controllers/edit_requests_controller.rb
1 
# frozen_string_literal: true
UNCOV
2 
class EditRequestsController < ApplicationController
2✔
UNCOV
3 
  layout "edit_request"
2✔
UNCOV
4 
  before_action :set_breadcrumbs
2✔
5 










UNCOV

6



  before_action :set_request_model, only: %i[edit update]




2✔






UNCOV

7



  before_action :check_access




2✔





8












9



  # GET /edit_requests/1/edit











UNCOV

10



  def edit




2✔






UNCOV

11



    add_breadcrumb(@request_model.project_title, request_path(@request_model))




1✔






UNCOV

12



    add_breadcrumb("Edit Submitted Request")




1✔






UNCOV

13



  end










14












15



  # PATCH/PUT /edit_requests/1 or /edit_requests/1.json











UNCOV

16



  def update




2✔






UNCOV

17



    respond_to do |format|




2✔






UNCOV

18



      if @request_model.update(request_params) && @request_model.valid_to_submit?




2✔






UNCOV

19



        format.html { redirect_to request_url(@request_model), notice: I18n.t(:successful_update) }




2✔






UNCOV

20



        format.json { render :show, status: :ok, location: @request_model }




1✔






UNCOV

21



      else











UNCOV

22



        format.html { render :edit, status: :unprocessable_entity }




2✔






UNCOV

23



        format.json { render json: @request_model.errors, status: :unprocessable_entity }




1✔






UNCOV

24



      end











UNCOV

25



    end











UNCOV

26



  end










27













UNCOV

28



  private




2✔





29












30



    # Use callbacks to share common setup or constraints between actions.











UNCOV

31



    def set_request_model




2✔






UNCOV

32



      @princeton_departments = Affiliation.all




5✔






UNCOV

33



      @request_model = Request.find(params[:id])




5✔






UNCOV

34



    end










35












36



    # Only allow a list of trusted parameters through.











UNCOV

37



    def request_params




2✔






UNCOV

38



      request_params = params.fetch(:request, {}).permit(:request_title, :project_title, :state, :data_sponsor, :data_manager,




2✔






UNCOV

39



                                        :description, :project_purpose, :parent_folder, :project_folder, :project_id, :quota,











UNCOV

40



                                        :requested_by, :storage_size, :storage_unit, :number_of_files, :hpc, :smb, :globus,











UNCOV

41



                                        user_roles: [], departments: [])










42













UNCOV

43



      if request_params[:departments].present?




2✔






UNCOV

44



        request_params[:departments] = request_params[:departments].compact_blank.map { |dep_str| JSON.parse(dep_str) }




3✔






UNCOV

45



      end











UNCOV

46



      if request_params[:user_roles].present?




2✔





47



        request_params[:user_roles] = request_params[:user_roles].compact_blank.map { |role_str| JSON.parse(role_str) }




×








UNCOV

48



      end











UNCOV

49



      move_approved_values(request_params)




2✔






UNCOV

50



    end










51













UNCOV

52



    def move_approved_values(request_params)




2✔






UNCOV

53



      if request_params[:quota].present?




2✔






UNCOV

54



        request_params[:approved_quota] = request_params.delete(:quota)




1✔






UNCOV

55



      end











UNCOV

56



      if request_params[:storage_size].present?




2✔





57



        request_params[:approved_storage_size] = request_params.delete(:storage_size)




×








UNCOV

58



      end











UNCOV

59



      if request_params[:storage_unit].present?




2✔





60



        request_params[:approved_storage_unit] = request_params.delete(:storage_unit)




×








UNCOV

61



      end











UNCOV

62



      request_params




2✔






UNCOV

63



    end










64













UNCOV

65



    def set_breadcrumbs




2✔






UNCOV

66



      add_breadcrumb("Dashboard", dashboard_path)




5✔






UNCOV

67



      add_breadcrumb("Requests", requests_path)




5✔






UNCOV

68



    end










69













UNCOV

70



    def check_access




2✔






UNCOV

71



      return if user_eligible_to_modify_request?




5✔





72












73



      # request can not be modified by this user, redirect to the request











UNCOV

74



      flash[:notice] = I18n.t(:no_modify_submitted)




2✔






UNCOV

75



      redirect_to request_path(@request_model)




2✔






UNCOV

76



    end










77













UNCOV

78



    def user_eligible_to_modify_request?




2✔





79



      # elevated privs for the current user











UNCOV

80



      if current_user.sysadmin || (current_user.developer && !Rails.env.production?)




5✔






UNCOV

81



        true




3✔






UNCOV

82



      else











UNCOV

83



        false




2✔






UNCOV

84



      end











UNCOV

85



    end











UNCOV

86



end
























    

  • 

    •