8479a24a-e310-45e5-8d6b-ec6c71da8281

Committed 24 Nov 2025 02:38PM UTC coverage: 73.002% (-15.1%) from 88.064%

Build # 8479a24a-e310-45e5-8d6b-ec6c71da8281

Build Type

Pull #2235

circleci

Committed by

carolyncole

Commit Message

Do not redirect from home page when login is disabled
fixes #2188

Pull Request Pull Request #2235: Do not redirect from home page when login is disabled

Run Details

2 of 5 new or added lines in 2 files covered. (40.0%)

320 existing lines in 38 files now uncovered.

2320 of 3178 relevant lines covered (73.0%)

209.4 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

79.31

/app/models/project_validator.rb

class ProjectValidator < ActiveModel::Validator
    def validate(project)
        @schema = TigerdataSchema.new(namespace: "tigerdata", type: "tigerdata:project")

        # we need this because this method references the metadata_json which is not updated until the project is saved
        project.metadata = project.metadata_model

        # Required fields, always validate
        validate_role(project:, netid: project.metadata_model.data_manager, role: "Data Manager")
        validate_role(project:, netid: project.metadata_model.data_sponsor, role: "Data Sponsor")

        # Validate if present
        project.metadata_model.data_user_read_only&.each { |read_only| validate_role(project:, netid: read_only, role: "Data User Read Only")}
        project.metadata_model.data_user_read_write&.each { |read_write| validate_role(project:, netid: read_write, role: "Data User Read Write")}

        # validate all required fields
        required_metadata_field_errors = []
        required_metadata = required_attributes(project:)
        if required_metadata.values.include?(nil)
            required_keys.each do |attr|
                value = required_metadata[attr]
                required_metadata_field_errors << "Missing metadata value for #{attr}" if value.nil? && project.metadata_json.include?(attr)
            end
        end
        if required_metadata_field_errors.count > 0
            project.errors.add :base, "Invalid Project Metadata it does not match the schema #{TigerdataSchema::SCHEMA_VERSION}\n #{required_metadata_field_errors.join(", ")}"
        end
    end

    private

    def validate_role(project:, netid:, role:)
        if netid.blank?
            project.errors.add :base, "Missing netid for role #{role}"
        elsif User.where(uid: netid).empty?
            project.errors.add :base, "Invalid netid: #{netid} for role #{role}"
        end
    end

    def required_field_labels
        @schema.required_project_schema_fields.pluck(:name)
    end

    def required_keys
        tableized = required_field_labels.map { |v| v.underscore }
        tableized
    end

    def required_attributes(project:)
        project.metadata_json.select { |k, _v| required_keys.include?(k) }
    end

end

1	class ProjectValidator < ActiveModel::Validator	1✔
2	def validate(project)	1✔
3	@schema = TigerdataSchema.new(namespace: "tigerdata", type: "tigerdata:project")	478✔
4
5	# we need this because this method references the metadata_json which is not updated until the project is saved
6	project.metadata = project.metadata_model	478✔
7
8	# Required fields, always validate
9	validate_role(project:, netid: project.metadata_model.data_manager, role: "Data Manager")	478✔
10	validate_role(project:, netid: project.metadata_model.data_sponsor, role: "Data Sponsor")	478✔
11
12	# Validate if present
13	project.metadata_model.data_user_read_only&.each { \|read_only\| validate_role(project:, netid: read_only, role: "Data User Read Only")}	573✔
14	project.metadata_model.data_user_read_write&.each { \|read_write\| validate_role(project:, netid: read_write, role: "Data User Read Write")}	483✔
15
16	# validate all required fields
17	required_metadata_field_errors = []	478✔
18	required_metadata = required_attributes(project:)	478✔
19	if required_metadata.values.include?(nil)	478✔
UNCOV 20	required_keys.each do \|attr\|	×
UNCOV 21	value = required_metadata[attr]	×
UNCOV 22	required_metadata_field_errors << "Missing metadata value for #{attr}" if value.nil? && project.metadata_json.include?(attr)	×
23	end
24	end
25	if required_metadata_field_errors.count > 0	478✔
UNCOV 26	project.errors.add :base, "Invalid Project Metadata it does not match the schema #{TigerdataSchema::SCHEMA_VERSION}\n #{required_metadata_field_errors.join(", ")}"	×
27	end
28	end
29
30	private	1✔
31
32	def validate_role(project:, netid:, role:)	1✔
33	if netid.blank?	1,056✔
UNCOV 34	project.errors.add :base, "Missing netid for role #{role}"	×
35	elsif User.where(uid: netid).empty?	1,056✔
UNCOV 36	project.errors.add :base, "Invalid netid: #{netid} for role #{role}"	×
37	end
38	end
39
40	def required_field_labels	1✔
41	@schema.required_project_schema_fields.pluck(:name)	11,482✔
42	end
43
44	def required_keys	1✔
45	tableized = required_field_labels.map { \|v\| v.underscore }	91,856✔
46	tableized	11,482✔
47	end
48
49	def required_attributes(project:)	1✔
50	project.metadata_json.select { \|k, _v\| required_keys.include?(k) }	11,960✔
51	end
52
53	end

pulibrary / tigerdata-app / 8479a24a-e310-45e5-8d6b-ec6c71da8281

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous