6940292d-58ec-4f2a-a05e-c8fb9b4787e9

Committed 24 Nov 2025 06:47PM UTC coverage: 87.586% (+17.2%) from 70.412%

Build # 6940292d-58ec-4f2a-a05e-c8fb9b4787e9

Build Type

Pull #2238

circleci

Committed by

hectorcorrea

Commit Message

Remove a bit of unused JavaScript

Pull Request Pull Request #2238: Remove a bit of unused JavaScript

Run Details

2787 of 3182 relevant lines covered (87.59%)

358.54 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

86.42

/app/presenters/request_presenter.rb

# frozen_string_literal: true
class RequestPresenter
  attr_reader :request
  def initialize(request)
    @request = request
  end

  def eligible_to_edit?(user)
    return false if user.nil?
    if request.submitted?
      user.eligible_sysadmin?
    else
      user.uid == request.requested_by || user.eligible_sysadmin?
    end
  end

  def data_sponsor
    full_name(request.data_sponsor)
  end

  def data_manager
    full_name(request.data_manager)
  end

  def project_directory
    request.parent_folder.present? ? File.join(request.parent_folder, request.project_folder) : request.project_folder
  end

  def project_purpose
    ProjectPurpose.label_for(request.project_purpose)
  end

  def departments_list
    return "" if request.departments.blank?
    dept_list = []
    request.departments.each do |dept|
      dept_list << "#{dept['name']} (#{dept['code']})"
    end
    dept_list.join(", ")
  end

  def user_list
    return "" if request.user_roles.blank?
    usr_list = []
    request.user_roles.each do |usr|
      name = full_name(usr["uid"])
      name += " read only" if usr["read_only"]
      usr_list << name
    end
    usr_list.join(", ")
  end

  def full_name(uid)
    return "" if uid.blank?
    user = User.find_by(uid: uid)
    user.display_name_safe.to_s
  end

  # Returns the correct CSS class suffix for the sidebar navigation progress for a given
  # step/substep.
  def sidebar_progress(controller, step, substep = nil)
    controller_name = controller.controller_name
    case step
    when 1
      step1_css_suffix(controller_name, substep)
    when 2
      step2_css_suffix(controller_name)
    when 3
      step3_css_suffix(controller_name)
    when 4
      step4_css_suffix(controller_name)
    else
      "-incomplete"
    end
  end

  private

    def step1_css_suffix(controller_name, substep = nil)
      css_suffix = "-incomplete"
      if substep.nil?
        return "-current" if controller_name.start_with?("project_information")
        if step1_valid?
          css_suffix = "-completed"
        end
      elsif substep == "Basic Details"
        return "-current" if controller_name == "project_information"
        if step1_valid?
          css_suffix = "-completed"
        end
      end
      css_suffix
    end

    def step2_css_suffix(controller_name)
      return "-current" if controller_name == "roles_and_people"
      if step2_valid?
        "-completed"
      else
        "-incomplete"
      end
    end

    def step3_css_suffix(controller_name)
      return "-current" if controller_name == "storage_and_access"
      if step3_valid?
        "-completed"
      else
        "-incomplete"
      end
    end

    def step4_css_suffix(controller_name)
      return "-current" if controller_name == "review_and_submit"
      if step4_valid?
        "-completed"
      else
        "-incomplete"
      end
    end

    def step1_valid?
      return false if request.project_title.blank? || request.project_folder.blank? || request.project_purpose.blank? || request.description.blank? || request.departments.blank?
      true
    end

    def step2_valid?
      return false if request.data_manager.blank? || request.data_sponsor.blank?
      true
    end

    def step3_valid?
      return false if request.storage_size.nil?
      true
    end

    def step4_valid?
      step1_valid? && step2_valid? && step3_valid?
    end
end

1	# frozen_string_literal: true
2	class RequestPresenter	4✔
3	attr_reader :request	4✔
4	def initialize(request)	4✔
5	@request = request	51✔
6	end
7
8	def eligible_to_edit?(user)	4✔
9	return false if user.nil?	10✔
10	if request.submitted?	10✔
11	user.eligible_sysadmin?	4✔
12	else
13	user.uid == request.requested_by \|\| user.eligible_sysadmin?	6✔
14	end
15	end
16
17	def data_sponsor	4✔
18	full_name(request.data_sponsor)	1✔
19	end
20
21	def data_manager	4✔
22	full_name(request.data_manager)	2✔
23	end
24
25	def project_directory	4✔
26	request.parent_folder.present? ? File.join(request.parent_folder, request.project_folder) : request.project_folder	×
27	end
28
29	def project_purpose	4✔
30	ProjectPurpose.label_for(request.project_purpose)	×
31	end
32
33	def departments_list	4✔
34	return "" if request.departments.blank?	2✔
35	dept_list = []	1✔
36	request.departments.each do \|dept\|	1✔
37	dept_list << "#{dept['name']} (#{dept['code']})"	2✔
38	end
39	dept_list.join(", ")	1✔
40	end
41
42	def user_list	4✔
43	return "" if request.user_roles.blank?	2✔
44	usr_list = []	1✔
45	request.user_roles.each do \|usr\|	1✔
46	name = full_name(usr["uid"])	2✔
47	name += " read only" if usr["read_only"]	2✔
48	usr_list << name	2✔
49	end
50	usr_list.join(", ")	1✔
51	end
52
53	def full_name(uid)	4✔
54	return "" if uid.blank?	8✔
55	user = User.find_by(uid: uid)	6✔
56	user.display_name_safe.to_s	6✔
57	end
58
59	# Returns the correct CSS class suffix for the sidebar navigation progress for a given
60	# step/substep.
61	def sidebar_progress(controller, step, substep = nil)	4✔
62	controller_name = controller.controller_name	60✔
63	case step	60✔
64	when 1
65	step1_css_suffix(controller_name, substep)	24✔
66	when 2
67	step2_css_suffix(controller_name)	12✔
68	when 3
69	step3_css_suffix(controller_name)	12✔
70	when 4
71	step4_css_suffix(controller_name)	12✔
72	else
73	"-incomplete"	×
74	end
75	end
76
77	private	4✔
78
79	def step1_css_suffix(controller_name, substep = nil)	4✔
80	css_suffix = "-incomplete"	24✔
81	if substep.nil?	24✔
82	return "-current" if controller_name.start_with?("project_information")	12✔
83	if step1_valid?	8✔
84	css_suffix = "-completed"	×
85	end
86	elsif substep == "Basic Details"	12✔
87	return "-current" if controller_name == "project_information"	12✔
88	if step1_valid?	10✔
89	css_suffix = "-completed"	×
90	end
91	end
92	css_suffix	18✔
93	end
94
95	def step2_css_suffix(controller_name)	4✔
96	return "-current" if controller_name == "roles_and_people"	12✔
97	if step2_valid?	11✔
98	"-completed"	×
99	else
100	"-incomplete"	11✔
101	end
102	end
103
104	def step3_css_suffix(controller_name)	4✔
105	return "-current" if controller_name == "storage_and_access"	12✔
106	if step3_valid?	11✔
107	"-completed"	×
108	else
109	"-incomplete"	11✔
110	end
111	end
112
113	def step4_css_suffix(controller_name)	4✔
114	return "-current" if controller_name == "review_and_submit"	12✔
115	if step4_valid?	10✔
116	"-completed"	×
117	else
118	"-incomplete"	10✔
119	end
120	end
121
122	def step1_valid?	4✔
123	return false if request.project_title.blank? \|\| request.project_folder.blank? \|\| request.project_purpose.blank? \|\| request.description.blank? \|\| request.departments.blank?	28✔
124	true	×
125	end
126
127	def step2_valid?	4✔
128	return false if request.data_manager.blank? \|\| request.data_sponsor.blank?	11✔
129	true	×
130	end
131
132	def step3_valid?	4✔
133	return false if request.storage_size.nil?	11✔
134	true	×
135	end
136
137	def step4_valid?	4✔
138	step1_valid? && step2_valid? && step3_valid?	10✔
139	end
140	end

pulibrary / tigerdata-app / 6940292d-58ec-4f2a-a05e-c8fb9b4787e9

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous